From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@lst.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts
Date: Tue, 31 Jul 2018 00:54:20 +0300 [thread overview]
Message-ID: <CAHp75VfJBdDxgV3dnv5UrG-DHg-_3at+BeO3j8kFAXUn2t11pQ@mail.gmail.com> (raw)
In-Reply-To: <20180730213028.GC45322@bhelgaas-glaptop.roam.corp.google.com>
On Tue, Jul 31, 2018 at 12:30 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> [+cc Thomas, Christoph, LKML]
>
> On Mon, Jul 30, 2018 at 12:03:42AM +0200, Heiner Kallweit wrote:
>> If we have a threaded interrupt with the handler being NULL, then
>> request_threaded_irq() -> __setup_irq() will complain and bail out
>> if the IRQF_ONESHOT flag isn't set. Therefore check for the handler
>> being NULL and set IRQF_ONESHOT in this case.
>>
>> This change is needed to migrate the mei_me driver to
>> pci_alloc_irq_vectors() and pci_request_irq().
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> I'd like an ack from Thomas because this requirement about IRQF_ONESHOT
> usage isn't mentioned in the request_threaded_irq() function doc or
> Documentation/
* IRQF_ONESHOT - Interrupt is not reenabled after the hardirq handler finished.
* Used by threaded interrupts which need to keep the
* irq line disabled until the threaded handler has been run.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-07-30 21:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d004975f-03a8-59f5-56ef-f4e1f8e12dfb@gmail.com>
2018-07-30 21:30 ` [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts Bjorn Helgaas
2018-07-30 21:50 ` Heiner Kallweit
2018-07-30 21:54 ` Andy Shevchenko [this message]
2018-07-30 22:36 ` Thomas Gleixner
2018-07-31 6:15 ` Marc Zyngier
2018-08-01 19:51 ` Heiner Kallweit
2018-08-03 14:09 ` Thomas Gleixner
2018-08-03 19:25 ` Heiner Kallweit
2018-08-03 19:40 ` Thomas Gleixner
2018-08-03 20:55 ` Heiner Kallweit
2018-07-30 22:42 ` Bjorn Helgaas
2018-07-30 22:50 ` Thomas Gleixner
2018-07-31 7:29 ` Lee Jones
2018-07-31 8:01 ` Russell King - ARM Linux
2018-07-31 11:13 ` Bjorn Helgaas
2018-07-31 8:08 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfJBdDxgV3dnv5UrG-DHg-_3at+BeO3j8kFAXUn2t11pQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).