From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>,
platform-driver-x86@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Lee, Chun-Yi" <jlee@suse.com>
Subject: Re: [PATCH v2] acer-wmi: setup accelerometer when machine has appropriate notify event
Date: Tue, 27 Dec 2016 14:00:01 +0200 [thread overview]
Message-ID: <CAHp75VfJi_1LaPmE=Gxz_H-AcWqHnSRSGJgdA=GpZtUQwOs91Q@mail.gmail.com> (raw)
In-Reply-To: <1478132332-25284-1-git-send-email-jlee@suse.com>
On Thu, Nov 3, 2016 at 2:18 AM, Lee, Chun-Yi <joeyli.kernel@gmail.com> wrote:
> The accelerometer event relies on on the ACERWMID_EVENT_GUID notify.
> So, this patch changes the codes to setup accelerometer input device
> when detected ACERWMID_EVENT_GUID. It avoids that the accel input
> device created on every acer machines.
>
> In addition, patch adds a clearly parsing logic of accelerometer hid
> to acer_wmi_get_handle_cb callback function. It is positive matching
> the "SENR" name with "BST0001" device to avoid non-supported hardware.
>
Pushed to testing with slightly massaged commit message.
Thanks.
> v2:
> Fix the string comparison logic of SENR.
>
> Reported-by: Bjørn Mork <bjorn@mork.no>
> Cc: Darren Hart <dvhart@infradead.org>
> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> ---
> drivers/platform/x86/acer-wmi.c | 22 ++++++++++++++++++----
> 1 file changed, 18 insertions(+), 4 deletions(-)
>
> Index: linux/drivers/platform/x86/acer-wmi.c
> ===================================================================
> --- linux.orig/drivers/platform/x86/acer-wmi.c
> +++ linux/drivers/platform/x86/acer-wmi.c
> @@ -1808,11 +1808,24 @@ static int __init acer_wmi_enable_lm(voi
> return status;
> }
>
> +#define ACER_WMID_ACCEL_HID "BST0001"
> +
> static acpi_status __init acer_wmi_get_handle_cb(acpi_handle ah, u32 level,
> void *ctx, void **retval)
> {
> + struct acpi_device *dev;
> +
> + if (!strcmp(ctx, "SENR")) {
> + if (acpi_bus_get_device(ah, &dev))
> + return AE_OK;
> + if (!strcmp(ACER_WMID_ACCEL_HID, acpi_device_hid(dev)))
> + return AE_OK;
> + } else
> + return AE_OK;
> +
> *(acpi_handle *)retval = ah;
> - return AE_OK;
> +
> + return AE_CTRL_TERMINATE;
> }
>
> static int __init acer_wmi_get_handle(const char *name, const char *prop,
> @@ -1839,7 +1852,7 @@ static int __init acer_wmi_accel_setup(v
> {
> int err;
>
> - err = acer_wmi_get_handle("SENR", "BST0001", &gsensor_handle);
> + err = acer_wmi_get_handle("SENR", ACER_WMID_ACCEL_HID, &gsensor_handle);
> if (err)
> return err;
>
> @@ -2177,10 +2190,11 @@ static int __init acer_wmi_init(void)
> err = acer_wmi_input_setup();
> if (err)
> return err;
> + err = acer_wmi_accel_setup();
> + if (err)
> + return err;
> }
>
> - acer_wmi_accel_setup();
> -
> err = platform_driver_register(&acer_platform_driver);
> if (err) {
> pr_err("Unable to register platform driver\n");
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2016-12-27 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 0:18 [PATCH v2] acer-wmi: setup accelerometer when machine has appropriate notify event Lee, Chun-Yi
2016-12-27 12:00 ` Andy Shevchenko [this message]
2017-01-03 0:16 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfJi_1LaPmE=Gxz_H-AcWqHnSRSGJgdA=GpZtUQwOs91Q@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=jlee@suse.com \
--cc=joeyli.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).