From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45E2FC56202 for ; Tue, 17 Nov 2020 11:09:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D85D9207D3 for ; Tue, 17 Nov 2020 11:09:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LS2ZmMQw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728218AbgKQLIf (ORCPT ); Tue, 17 Nov 2020 06:08:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgKQLIf (ORCPT ); Tue, 17 Nov 2020 06:08:35 -0500 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F103BC0613CF; Tue, 17 Nov 2020 03:08:34 -0800 (PST) Received: by mail-pl1-x641.google.com with SMTP id k7so10060577plk.3; Tue, 17 Nov 2020 03:08:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LwT11DXQwSCtx7U2eB/ExlhlW4IxfqaVPsUn4voZxRQ=; b=LS2ZmMQwgssAtfBRB55d/qTPCkX1nmjRI9GL3uiuXmRYL+TW9upIuZwD3/zIsBgRJb 8oGZZKobwM8UtIQwyZepk8L3AlBNWNpbiW69f2LbhyMYMNVmdLjKFF7sjWWZKpyqPtml dy4B50twysl0MVBoROJXQSlGMH7gW6NZpvqkpbOJ7y/yK4BhPyXwG1qdo1eOwLCJA8XW R2xPoZ0Hvb887kmqPUeB0XvmkMCWbOFKBtusixLZgHHVLVo/ktTVci3uLxEDgU2HA9kz W0/HCjiO4md07I5qtH4/rtRSzrYp3tDbmzRMt3nxSoqoOtKdufwBi+Tp7JSLUE7F4SEM TbhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LwT11DXQwSCtx7U2eB/ExlhlW4IxfqaVPsUn4voZxRQ=; b=dz99GfyNmVNR8bFjksuEME7rlaH67n2L675bo/JKV6B/vb3WI5NtHs0+nXLNqhm+zs hhQagWyAnH0oM/a7qr64eT7EiHKToh8u3t0DZemdy9FiFBG4wAdQdbVc/4762WOwo4Eh p++urvOY7zzFl/YdHOhjf8F49IzN1aE7lOQzUpK5yNTdGKrsHfpOQ5h2g2ljY5r52tRT 3AbdBI8f2AAYj4R3KBXOLaX9Ke+UwuCU2rUlqUePULF6Om1mo/rUJbNLAk7vJ2gyjRg4 TFBf4sosK2z6SsjfcFNcGeYKVB5lZ0j7enMbI44yMrLiRYVj4qolfQ4OzOnUM+So6GIj Ow/w== X-Gm-Message-State: AOAM533iSRNoESZvbE3akxIMmteWU6oq5ii0+/ZQyUuM/Oco3vVvQNp8 lDDrkDdYw6D2hN9lQyzH8OcfqnDf/S8JPtEWDAU= X-Google-Smtp-Source: ABdhPJzbk+P2lNbfZC5aFBEC7lyxF1Vrb13IESw37uOHQUuKaT9qFUbz6yXtgEd7j6cb9uAZHbSVqX4K8Wot5UOapLA= X-Received: by 2002:a17:90a:d90a:: with SMTP id c10mr2241273pjv.129.1605611314600; Tue, 17 Nov 2020 03:08:34 -0800 (PST) MIME-Version: 1.0 References: <20201117075254.4861-1-alexandru.ardelean@analog.com> <20201117104126.00000516@Huawei.com> In-Reply-To: <20201117104126.00000516@Huawei.com> From: Andy Shevchenko Date: Tue, 17 Nov 2020 13:08:18 +0200 Message-ID: Subject: Re: [PATCH 1/3] iio: adc: ad7887: convert dual-channel mode to DT/ACPI To: Jonathan Cameron Cc: Alexandru Ardelean , linux-iio , devicetree , Linux Kernel Mailing List , Jonathan Cameron , Rob Herring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 17, 2020 at 12:42 PM Jonathan Cameron wrote: > > On Tue, 17 Nov 2020 09:52:52 +0200 > Alexandru Ardelean wrote: > > > This change converts the configuration of the dual-channel mode from the > > old platform-data, to the device_property_present() function, which > > supports both device-tree and ACPI configuration setups. > > > > With this change the old platform_data include of the driver can be > > removed. > > > > Signed-off-by: Alexandru Ardelean > Hi Alex, > > I'm a bit in too minds about device_property_present() > vs device_property_read_bool() which are the same thing under the hood. > > Not sure which one conveys the correct semantics here. > I don't feel strongly enough about it though to do more than raise > eyebrows (i.e. not blocking this series). The idea as I understand it is that the 'present' can be run against any type of property, while 'bool' is specifically for boolean (the similarities is a detail of implementation). -- With Best Regards, Andy Shevchenko