From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752615AbdGELs5 (ORCPT ); Wed, 5 Jul 2017 07:48:57 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:33676 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbdGELsz (ORCPT ); Wed, 5 Jul 2017 07:48:55 -0400 MIME-Version: 1.0 In-Reply-To: <20170705101358.17458-1-chris.packham@alliedtelesis.co.nz> References: <20170705101358.17458-1-chris.packham@alliedtelesis.co.nz> From: Andy Shevchenko Date: Wed, 5 Jul 2017 14:48:54 +0300 Message-ID: Subject: Re: [PATCH v2 0/4] i2c: pca-platform: additional improvements To: Chris Packham Cc: Wolfram Sang , Yoshinori Sato , linux-i2c , Linux-SH , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 5, 2017 at 1:13 PM, Chris Packham wrote: > This series addresses some of the points identified by Andy. The series is > based on top of i2c/for-next. 2 of the patches from v1 have already been > applied so I've dropped them from this version. > > I have compile tested patch 1/1 but I don't have access to sh hardware > to actually test the changes on. Entire series looks good to me: Reviewed-by: Andy Shevchenko Further improvement is to get timeout value via device properties API and get rid of legacy platform data completely. This can be done in further series. > > Chris Packham (4): > sh: sh7785lcr: add GPIO lookup table for i2c controller reset > i2c: pca-platform: unconditionally use devm_gpiod_get_optional > i2c: pca-platform: use device_property_read_u32 > i2c: pca-platform: drop gpio from platform data > > arch/blackfin/mach-bf561/boards/acvilon.c | 1 - > arch/sh/boards/board-sh7785lcr.c | 11 +++++++++- > drivers/i2c/busses/i2c-pca-platform.c | 34 +++++++++---------------------- > include/linux/i2c-pca-platform.h | 3 --- > 4 files changed, 20 insertions(+), 29 deletions(-) > > -- > 2.13.0 > -- With Best Regards, Andy Shevchenko