linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Vaibhav Murkute <vaibhavmurkute88@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	linux-bluetooth@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: bluetooth: hci_serdev: Removed unnecessary curly braces
Date: Mon, 14 May 2018 01:49:54 +0300	[thread overview]
Message-ID: <CAHp75VfLuiyLC-C=0HKAeWH3-Qd_fJ6WCOTN7s4VAwLkRzakdw@mail.gmail.com> (raw)
In-Reply-To: <1526076752-5871-1-git-send-email-vaibhavmurkute88@gmail.com>

On Sat, May 12, 2018 at 1:12 AM, Vaibhav Murkute
<vaibhavmurkute88@gmail.com> wrote:
> checkpatch.pl shows a warning for these unnecessary curly braces.
> so just removed those curly braces.
>
> Signed-off-by: Vaibhav Murkute <vaibhavmurkute88@gmail.com>
> ---
>  drivers/bluetooth/hci_serdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c
> index e0e6461..137c314 100644
> --- a/drivers/bluetooth/hci_serdev.c
> +++ b/drivers/bluetooth/hci_serdev.c
> @@ -204,9 +204,9 @@ static int hci_uart_setup(struct hci_dev *hdev)
>                 return 0;
>         }
>
> -       if (skb->len != sizeof(*ver)) {
> +       if (skb->len != sizeof(*ver))
>                 bt_dev_err(hdev, "Event length mismatch for version info");
> -       }
> +
>
>         kfree_skb(skb);
>         return 0;

Why did you add redundant empty line(s) instead?


-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2018-05-13 22:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11 22:12 [PATCH] drivers: bluetooth: hci_serdev: Removed unnecessary curly braces Vaibhav Murkute
2018-05-13 22:49 ` Andy Shevchenko [this message]
2018-05-14 21:38 Vaibhav Murkute
2018-05-22  7:25 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VfLuiyLC-C=0HKAeWH3-Qd_fJ6WCOTN7s4VAwLkRzakdw@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=vaibhavmurkute88@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).