linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-arch <linux-arch@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v9 9/9] gpio: uniphier: Utilize for_each_set_clump8 macro
Date: Tue, 12 Mar 2019 11:09:06 +0200	[thread overview]
Message-ID: <CAHp75VfMvReunZgtBbA42Xw6GtzTO8Xfr2V9nZyV8xYjPnBm4w@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNATQN5TJkmOq0r1BzxQCk1T4AmsUmhR1zU+gq8e_f5-FQw@mail.gmail.com>

On Tue, Mar 12, 2019 at 10:58 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> On Tue, Mar 12, 2019 at 4:19 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Tue, Mar 12, 2019 at 6:40 AM Masahiro Yamada
> > <yamada.masahiro@socionext.com> wrote:
> > > On Sun, Mar 3, 2019 at 4:51 PM William Breathitt Gray
> > > <vilhelm.gray@gmail.com> wrote:
> > > >
> > > > Replace verbose implementation in set_multiple callback with
> > > > for_each_set_clump8 macro to simplify code and improve clarity. An
> > > > improvement in this case is that banks that are not masked will now be
> > > > skipped.
> >
> > > Please do not do this.
> > >
> > > Nothing in this driver says the GPIO width is 8-bit.
> >
> > Huh?
> >
> > https://elixir.bootlin.com/linux/latest/source/include/dt-bindings/gpio/uniphier-gpio.h#L9
> >
> > Isn't a hardcoding?
>
>
> Semi-hardcoding.
>
> I needed to factor out some magic numbers
> shared between DT and drivers.

Effectively means you introduced an ABI, which we are not supposed to
change, where the number is carved in stone for all hardware covered
by this driver + DT pair.
If you would ever need another one it would require extending existing
bindings without dropping them away.

> Then, dt-bindings is out of realm of operating system.

Exactly!

> If I am doing wrong, I take back my comments, though.

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2019-03-12  9:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-03  7:44 [PATCH v9 0/9] Introduce the for_each_set_clump8 macro William Breathitt Gray
2019-03-03  7:47 ` William Breathitt Gray
2019-03-03  7:48 ` [PATCH v9 1/9] bitops: " William Breathitt Gray
2019-03-08  8:31   ` Linus Walleij
2019-03-08  8:57     ` William Breathitt Gray
2019-03-08  9:19       ` Andy Shevchenko
2019-03-12  5:36       ` Masahiro Yamada
2019-03-12  7:22         ` William Breathitt Gray
2019-03-12 14:54           ` Andy Shevchenko
2019-03-12  1:01     ` Andrew Morton
2019-03-12 10:43       ` William Breathitt Gray
2019-03-12  3:52   ` Masahiro Yamada
2019-03-12  5:03   ` Masahiro Yamada
2019-03-12  7:14     ` Andy Shevchenko
2019-03-03  7:48 ` [PATCH v9 2/9] lib/test_bitmap.c: Add for_each_set_clump8 test cases William Breathitt Gray
2019-03-11  7:56   ` [LKP] [lib/test_bitmap.c] ecdc93614a: kernel_selftests.lib.bitmap.sh.fail kernel test robot
2019-03-03  7:49 ` [PATCH v9 3/9] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro William Breathitt Gray
2019-03-03  7:49 ` [PATCH v9 4/9] gpio: 104-idi-48: " William Breathitt Gray
2019-03-03  7:50 ` [PATCH v9 5/9] gpio: gpio-mm: " William Breathitt Gray
2019-03-03  7:50 ` [PATCH v9 6/9] gpio: ws16c48: " William Breathitt Gray
2019-03-03  7:51 ` [PATCH v9 7/9] gpio: pci-idio-16: " William Breathitt Gray
2019-03-03  7:51 ` [PATCH v9 8/9] gpio: pcie-idio-24: " William Breathitt Gray
2019-03-03  7:51 ` [PATCH v9 9/9] gpio: uniphier: " William Breathitt Gray
2019-03-12  4:36   ` Masahiro Yamada
2019-03-12  7:17     ` Andy Shevchenko
2019-03-12  8:57       ` Masahiro Yamada
2019-03-12  9:09         ` Andy Shevchenko [this message]
2019-03-12  7:29     ` William Breathitt Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VfMvReunZgtBbA42Xw6GtzTO8Xfr2V9nZyV8xYjPnBm4w@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=vilhelm.gray@gmail.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).