From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-iio <linux-iio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH] iio:accel:dmard06: Optimize when CONFIG_OF isn't set
Date: Fri, 26 Aug 2022 19:10:33 +0300 [thread overview]
Message-ID: <CAHp75VfP-5-MPJs81denx9MT_MY_gi_QXkYqm63FY2sK+Kykcg@mail.gmail.com> (raw)
In-Reply-To: <20220826180609.01262f0a@endymion.delvare>
On Fri, Aug 26, 2022 at 7:06 PM Jean Delvare <jdelvare@suse.de> wrote:
> On Fri, 26 Aug 2022 18:18:20 +0300, Andy Shevchenko wrote:
> > On Fri, Aug 26, 2022 at 1:46 PM Jean Delvare <jdelvare@suse.de> wrote:
> > > therefore of_match_ptr() should be
> > > removed from the kernel entirely?
> >
> > (...) But for some cases it still
> > makes sense: platform is known to never be non-OF, component is known
> > to be used only on such platforms, etc.
>
> Well, I can't see the value of of_match_ptr() in such case either. In
> fact I've submitted a couple patches to remove such occurrences lately:
>
> https://patchwork.kernel.org/project/linux-mediatek/patch/20220730144833.0a0d9825@endymion.delvare/
> https://patchwork.kernel.org/project/linux-pm/patch/20220804135938.7f69f5d9@endymion.delvare/
They are different to what we are discussing here, but yes, in common
denominator the of_match_ptr() is useless in almost 100% cases.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-08-26 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 12:40 [PATCH] iio:accel:dmard06: Optimize when CONFIG_OF isn't set Jean Delvare
2022-08-25 20:12 ` Andy Shevchenko
2022-08-26 10:46 ` Jean Delvare
2022-08-26 15:18 ` Andy Shevchenko
2022-08-26 16:06 ` Jean Delvare
2022-08-26 16:10 ` Andy Shevchenko [this message]
2022-08-28 16:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfP-5-MPJs81denx9MT_MY_gi_QXkYqm63FY2sK+Kykcg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=jdelvare@suse.de \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).