From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: peng.hao2@zte.com.cn
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
hutao@cn.fujitsu.com
Subject: Re: [PATCH V2 3/4] misc/pvpanic: add support to pvpanic device information by using FDT
Date: Wed, 24 Oct 2018 16:12:47 +0300 [thread overview]
Message-ID: <CAHp75VfQQEsn8J_PWsET_ux-SagOVzavwo6Gy6EHQxuRD=78AQ@mail.gmail.com> (raw)
In-Reply-To: <1540401136-78500-3-git-send-email-peng.hao2@zte.com.cn>
On Wed, Oct 24, 2018 at 12:02 PM Peng Hao <peng.hao2@zte.com.cn> wrote:
>
> By default, when ACPI tables and FDT coexist for ARM64,
> current kernel takes precedence over FDT to get device information.
> This patch increases the way to get information through FDT.
> * pvpanic.c - pvpanic Device Support
> *
> * Copyright (C) 2013 Fujitsu.
> + * Copyright (C) 2018 ZTE.
> *
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License as published by
This hunk would be a separate patch which includes switch to SPDX and
removing the file name from the file itself.
> @@ -25,6 +26,10 @@
> #include <linux/init.h>
> #include <linux/types.h>
> #include <linux/acpi.h>
> +#include <linux/of.h>
> +#include <linux/of_address.h>
> +#include <asm/virt.h>
asm/* goes after linux/*
> +#include <linux/platform_device.h>
Better to keep sorted.
> + if (!mem)
> + return -EINVAL;
> +
> + if (!devm_request_mem_region(&pdev->dev, mem->start,
> + resource_size(mem), pdev->name))
> + return -EBUSY;
> +
> + base = devm_ioremap(&pdev->dev, mem->start,
> + resource_size(mem));
> + if (base == NULL)
> + return -EFAULT;
devm_ioremap_resource()
> +static const struct of_device_id pvpanic_mmio_match[] = {
> + { .compatible = "qemu,pvpanic-mmio", },
> + {},
terminators better w/o comma.
> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-10-24 13:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 17:12 [PATCH V2 1/4] misc/pvpanic: move pvpanic to misc as common driver Peng Hao
2018-10-24 13:08 ` Andy Shevchenko
2018-10-24 17:12 ` [PATCH V2 2/4] misc/pvpanic: add MMIO support Peng Hao
2018-10-24 13:09 ` Andy Shevchenko
[not found] ` <201810261140543493998@zte.com.cn>
2018-10-26 7:11 ` Arnd Bergmann
2018-10-24 17:12 ` [PATCH V2 3/4] misc/pvpanic: add support to pvpanic device information by using FDT Peng Hao
2018-10-24 13:12 ` Andy Shevchenko [this message]
2018-10-24 17:12 ` [PATCH V2 4/4] misc/pvpanic : pvpanic: add document for pvpanic-mmio DT Peng Hao
2018-10-24 13:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfQQEsn8J_PWsET_ux-SagOVzavwo6Gy6EHQxuRD=78AQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hutao@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peng.hao2@zte.com.cn \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).