From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Al Cooper <alcooperx@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: Re: [-next] serial: 8250: Match legacy NS16550A UARTs
Date: Thu, 15 Apr 2021 13:44:34 +0300 [thread overview]
Message-ID: <CAHp75VfQetCJJZ_U70xEduVBQHEx_GkHeKBs2uzNtvcq9H0BqQ@mail.gmail.com> (raw)
In-Reply-To: <20210414134539.42332-1-alcooperx@gmail.com>
On Wed, Apr 14, 2021 at 7:13 PM Al Cooper <alcooperx@gmail.com> wrote:
>
> From: Florian Fainelli <f.fainelli@gmail.com>
>
> Older 32-bit only Broadcom STB chips used a NS16550A compatible UART,
> the 8250_bcm7271.c driver can drive those UARTs just fine provided that
> we let it match the appropriate compatible string.
This sounds not correct to me, ns16550a is a national semiconductor product.
Why is it here and not in generic 8250_of?
> + {
> + .compatible = "ns16550a",
> + .data = brcmstb_rate_table_16550a,
> + },
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-04-15 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 13:45 [-next] serial: 8250: Match legacy NS16550A UARTs Al Cooper
2021-04-15 8:11 ` Greg Kroah-Hartman
2021-04-15 10:44 ` Andy Shevchenko [this message]
2021-04-21 19:04 ` Alan Cooper
2021-04-21 19:57 ` Andy Shevchenko
2021-04-21 20:00 ` Florian Fainelli
2021-04-21 20:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfQetCJJZ_U70xEduVBQHEx_GkHeKBs2uzNtvcq9H0BqQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).