From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc: Alexander Lobakin <alexandr.lobakin@intel.com>,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] linux/bits.h: fix -Wtype-limits warnings in GENMASK_INPUT_CHECK()
Date: Mon, 7 Mar 2022 18:33:11 +0200 [thread overview]
Message-ID: <CAHp75VfS0wSB+5dXHvoYfQqe0qEW0dOXGChunqu7PX0BZ4orMA@mail.gmail.com> (raw)
In-Reply-To: <CAMZ6RqK=yxLwVnotZuGRiao4Vu4eFEfVXfPaZV1r4rEOmQARig@mail.gmail.com>
On Mon, Mar 7, 2022 at 4:06 PM Vincent MAILHOL
<mailhol.vincent@wanadoo.fr> wrote:
> On Mon. 7 Mar 2022 at 22:40, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Mon, Mar 7, 2022 at 1:00 PM Alexander Lobakin
> > <alexandr.lobakin@intel.com> wrote:
> > > From: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > Date: Fri, 4 Mar 2022 20:46:08 +0200
> > > > On Fri, Mar 4, 2022 at 7:36 PM Vincent Mailhol
> > > > <mailhol.vincent@wanadoo.fr> wrote:
...
> > > > Have you fixed W=1 warnings?
> > > > Without fixing W=1 (which makes much more sense, when used with
> > > > WERROR=y && COMPILE_TEST=y) this has no value.
> > >
> > > How is this connected?
> >
> > By priorities.
> > I don't see much value in fixing W=2 per se if the code doesn't compile for W=1.
>
> *My code* compiles for W=1. For me, fixing this W=2 in the next in line
> if speaking of priorities.
> I do not understand why I should be forbidden to fix a W=2 in the
> file which I am maintaining on the grounds that some code to which
> I do not care still has some W=1.
It's not forbidden. I said something different.
Whatever, thank you for doing it, perhaps we will have less noise in W=2 case.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-07 16:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 12:44 [PATCH] linux/bits.h: fix -Wtype-limits warnings in GENMASK_INPUT_CHECK() Vincent Mailhol
2022-03-04 18:46 ` Andy Shevchenko
2022-03-05 12:43 ` Vincent MAILHOL
2022-03-05 21:33 ` Andy Shevchenko
2022-03-06 5:35 ` Vincent MAILHOL
2022-03-07 10:33 ` Andy Shevchenko
2022-03-07 10:58 ` Alexander Lobakin
2022-03-07 12:15 ` Arnd Bergmann
2022-03-07 13:50 ` Vincent MAILHOL
2022-03-07 15:07 ` Alexander Lobakin
2022-03-07 16:30 ` Andy Shevchenko
2022-03-08 12:20 ` Vincent MAILHOL
2022-03-07 13:40 ` Andy Shevchenko
2022-03-07 14:06 ` Vincent MAILHOL
2022-03-07 16:33 ` Andy Shevchenko [this message]
2022-03-08 12:22 ` Vincent MAILHOL
2022-03-08 12:32 ` Andy Shevchenko
2022-03-08 14:12 ` [PATCH v2] linux/bits.h: GENMASK_INPUT_CHECK: reduce W=2 noise by 31% treewide Vincent Mailhol
2022-03-08 18:13 ` Linus Torvalds
2022-03-09 2:23 ` Vincent MAILHOL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfS0wSB+5dXHvoYfQqe0qEW0dOXGChunqu7PX0BZ4orMA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexandr.lobakin@intel.com \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=rikard.falkeborn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).