From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACFA2C433F5 for ; Tue, 2 Nov 2021 14:13:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96B4760FC2 for ; Tue, 2 Nov 2021 14:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231326AbhKBOQX (ORCPT ); Tue, 2 Nov 2021 10:16:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbhKBOQW (ORCPT ); Tue, 2 Nov 2021 10:16:22 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D805C061714; Tue, 2 Nov 2021 07:13:47 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id m14so23419557edd.0; Tue, 02 Nov 2021 07:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+j8hsXOY8XFBcUQY09d3Bm6u2Cd3NbaccVLoECv3HYE=; b=Tdf1K3H+Lg7s+DMqBUPbp1Zj4RDwqdxJ5f9UrW88BlRUYlgBYic1r7/n7I13XZNDBU oG5MV/LgkcrxjTcxXakGCMiekxd9Xs7A8uQyu6Zq5gkIAyFJyUVtqhjDvIBm0ML77BZx SXq829uwldsaG4eMoTAK8Crrhzm2EkP6TsmBkUDwg2/pHv0aLXJXh9z3brShcJwYF/D5 DijQxGvU1JDSkzbIxedUwKVc+Qm/OQO2bLj74ptbpKXHkcTfPEFOdtliboFWtJCxPZkw cH/KR6rcdAAbql0GwZz/RxdfBGSWaRjJ3bad2XkBiCIrZlVJ+2tukjBswD2rsr2IdD7i roWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+j8hsXOY8XFBcUQY09d3Bm6u2Cd3NbaccVLoECv3HYE=; b=emZMSV1Iln4zjpD/elp9Ewo0lQHX0YUV0lkDofhK6DU9oAbgFf1vZZcVGloSIZggrg SQu3v6Dm1QWYszhgIaX/cK/qSZo6fy+X8Mw5z26jLIl45l2XWIXSR87pK+XaizjekXDB lFsBsqqFPklZ8yNLYPXtneR7Mree9u6lX9YoVLUc6OARoLjlWh67NAB6un/Dnqwj7uYp ICDpVFIY+5UpBMoCKe2qHrzHeen2iLALPGmtRr7ZXkI39DH2obKIZOIS4RVCVMPN84NA 47zGhaSidqKeSPNqkP6RNAATjcluDDkqUKJBU4/caSoZW87XoHGrIt4uTZ7DN8efLoY/ l3/w== X-Gm-Message-State: AOAM531QnNbRIYOn2IE/+bolNcddt46rMvWTo4A1A8J1mRZISrJH3Vga gwMO+b2XLme9q0EFgEPhbsxlQqoyIIwJwt76Q8w= X-Google-Smtp-Source: ABdhPJyKcI23macxqNFIt9wwe+SVKY0dzoujCECZBAvK1EiUAl8fA0zKRHCqPQRXJB+c9kWKLTkoHkxrArinkXDo700= X-Received: by 2002:a17:907:7601:: with SMTP id jx1mr45648690ejc.69.1635862424213; Tue, 02 Nov 2021 07:13:44 -0700 (PDT) MIME-Version: 1.0 References: <20211102094907.31271-1-hdegoede@redhat.com> <20211102094907.31271-8-hdegoede@redhat.com> In-Reply-To: <20211102094907.31271-8-hdegoede@redhat.com> From: Andy Shevchenko Date: Tue, 2 Nov 2021 16:12:54 +0200 Message-ID: Subject: Re: [PATCH v5 07/11] platform/x86: int3472: Split into 2 drivers To: Hans de Goede Cc: "Rafael J . Wysocki" , Mark Gross , Andy Shevchenko , Wolfram Sang , Mika Westerberg , Daniel Scally , Laurent Pinchart , Mauro Carvalho Chehab , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Len Brown , ACPI Devel Maling List , Platform Driver , Linux Kernel Mailing List , linux-i2c , Sakari Ailus , Kate Hsuan , Linux Media Mailing List , linux-clk Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 2, 2021 at 11:49 AM Hans de Goede wrote: > > The intel_skl_int3472.ko module contains 2 separate drivers, > the int3472_discrete platform driver and the int3472_tps68470 > I2C-driver. > > These 2 drivers contain very little shared code, only > skl_int3472_get_acpi_buffer() and skl_int3472_fill_cldb() are > shared. > > Split the module into 2 drivers, linking the little shared code > directly into both. > > This will allow us to add soft-module dependencies for the > tps68470 clk, gpio and regulator drivers to the new > intel_skl_int3472_tps68470.ko to help with probe ordering issues > without causing these modules to get loaded on boards which only > use the int3472_discrete platform driver. > > While at it also rename the .c and .h files to remove the > cumbersome intel_skl_int3472_ prefix. > > Signed-off-by: Hans de Goede > --- > Note git rename detection is failing for the new common.c but this is > just the old intel_skl_int3472_common.c with the driver registering > bits removed. -M accepts a parameter (in percents) to set the threshold. Default is something like ~70 (?). You may play with it and see when it starts detecting the rename. -- With Best Regards, Andy Shevchenko