From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: peng.hao2@zte.com.cn
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
hutao@cn.fujitsu.com,
Linux Documentation List <linux-doc@vger.kernel.org>
Subject: Re: Re: [PATCH V3 3/5] misc/pvpanic: add MMIO support
Date: Tue, 30 Oct 2018 11:54:03 +0200 [thread overview]
Message-ID: <CAHp75VfVitVWoXbUs0gQbv9Ny2gwccON-+qU06YaCs19tF9oAw@mail.gmail.com> (raw)
In-Reply-To: <201810301107515541204@zte.com.cn>
On Tue, Oct 30, 2018 at 5:08 AM <peng.hao2@zte.com.cn> wrote:
> >On Mon, Oct 29, 2018 at 12:54 PM <peng.hao2@zte.com.cn> wrote:
> >I would consider it as a bug if on some architectures iounmap() is not
> >able to take a base got from ioport_map().
> I added TYPE_PVPANIC_MMIO in QEMU to the architecture that does not support IOPORT.
> If some architectures does not support IOPORT, set TYPE_PVPANIC_MMIO in qemu. This setting is reflected in the kernel pvpanic driver
> and does not invoke ioport_map (calling ioremap). So I think the situation you described above will not happen.
> But I should resume one check like this to deal with the failure of ioremap/ioport_map.
> if (base)
> iounmap(base)
I'm a bit confused, how come that base == NULL when you about to call
iounmap()? Where you would like to put this check?
> The patch of QEMU is still in review.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-10-30 9:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 11:32 [PATCH V3 1/5] pvpanic: move pvpanic to misc as common driver Peng Hao
2018-10-29 10:15 ` Andy Shevchenko
[not found] ` <201810291843424704356@zte.com.cn>
2018-10-29 11:37 ` Andy Shevchenko
2018-10-29 11:32 ` [PATCH V3 2/5] misc/pvpanic : convert to SPDX license tags Peng Hao
2018-10-29 11:32 ` [PATCH V3 3/5] misc/pvpanic: add MMIO support Peng Hao
2018-10-29 10:30 ` Andy Shevchenko
[not found] ` <201810291854235724652@zte.com.cn>
2018-10-29 11:57 ` Andy Shevchenko
[not found] ` <201810301107515541204@zte.com.cn>
2018-10-30 9:54 ` Andy Shevchenko [this message]
2018-10-29 11:32 ` [PATCH V4 4/5] misc/pvpanic: add support to get pvpanic device info by FDT Peng Hao
2018-10-29 11:37 ` Andy Shevchenko
2018-10-29 11:32 ` [PATCH 5/5] dt-bindings/misc/pvpanic :add document for pvpanic-mmio Peng Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfVitVWoXbUs0gQbv9Ny2gwccON-+qU06YaCs19tF9oAw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hutao@cn.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peng.hao2@zte.com.cn \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).