From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934016AbdAFR2r (ORCPT ); Fri, 6 Jan 2017 12:28:47 -0500 Received: from mail-qk0-f179.google.com ([209.85.220.179]:34482 "EHLO mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbdAFR2i (ORCPT ); Fri, 6 Jan 2017 12:28:38 -0500 MIME-Version: 1.0 In-Reply-To: <1483670635-25060-4-git-send-email-david@lechnology.com> References: <1483670635-25060-1-git-send-email-david@lechnology.com> <1483670635-25060-4-git-send-email-david@lechnology.com> From: Andy Shevchenko Date: Fri, 6 Jan 2017 19:28:37 +0200 Message-ID: Subject: Re: [PATCH 3/3] Input: pwm-beeper: add optional enable gpio To: David Lechner Cc: Dmitry Torokhov , Rob Herring , Mark Rutland , linux-input , devicetree , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 6, 2017 at 4:43 AM, David Lechner wrote: > This adds an optional enable gpio to the pwm-beeper device. This gpio is > used in cases where the beeper needs to be switched on before using it. Isn't it a property of pin muxing? > For > example, there may be an amplifier that is not always powered on. This looks like GPIO based fixed voltage regulator. > > Tested on LEGO MINDSTORMS EV3, which has a speaker connected to PWM through > an amplifier. The amplifier has an enable pin that is connected to a gpio. -- With Best Regards, Andy Shevchenko