From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Sekhar Nori <nsekhar@ti.com>,
David Lechner <david@lechnology.com>,
Wolfram Sang <wsa@the-dreams.de>,
devicetree <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>
Subject: Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses
Date: Thu, 29 Jun 2017 14:56:03 +0300 [thread overview]
Message-ID: <CAHp75Vf_SL3ReKLK0=8v3bDwHs5qwi2qc9p=XzJK9BXzOsLKLA@mail.gmail.com> (raw)
In-Reply-To: <1498736351-9021-3-git-send-email-claudiu.beznea@microchip.com>
On Thu, Jun 29, 2017 at 2:39 PM, Claudiu Beznea
<claudiu.beznea@microchip.com> wrote:
> Add support for reading from different offsets of EEPROM.
> The offset is initialized via device tree. If nothing is
> given as input the old value, 0x90, is used. In this way
> the driver could be used as generic driver for different
> vendor memories by only changing the reading offset via
> device tree.
> + err = device_property_read_u8(dev, "start-offset", &chip->offset);
This property has to be documented.
Moreover, the name looks too broad (I checked current use of
"*-offset" type of properties and they either vendor specific, or data
type specific.
Taking above into consideration mac-offset sounds better to me.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-06-29 11:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 11:39 [RFC PATCH 0/3] Add at24 functionality to read form different EEPROM offsets Claudiu Beznea
2017-06-29 11:39 ` [PATCH 1/3] dt-bindings: i2c: eeprom: document all at24 bindings Claudiu Beznea
2017-06-29 11:39 ` [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses Claudiu Beznea
2017-06-29 11:56 ` Andy Shevchenko [this message]
2017-06-29 13:30 ` Ludovic Desroches
2017-07-05 9:31 ` m18063
2017-06-29 15:32 ` David Lechner
2017-07-05 9:33 ` m18063
2017-06-30 7:20 ` Uwe Kleine-König
2017-07-05 9:33 ` m18063
2017-06-29 11:39 ` [RFC PATCH 3/3] dt-bindings: i2c: eeprom: document "start-offset" binding Claudiu Beznea
2017-07-06 15:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vf_SL3ReKLK0=8v3bDwHs5qwi2qc9p=XzJK9BXzOsLKLA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=claudiu.beznea@microchip.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).