From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756203AbdKCMCl (ORCPT ); Fri, 3 Nov 2017 08:02:41 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:51778 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753775AbdKCMCi (ORCPT ); Fri, 3 Nov 2017 08:02:38 -0400 X-Google-Smtp-Source: ABhQp+QOX0dthu+nl6DMnNVYhbaQw6bxQY+ru+Wh5H2rB5nJRUkB3cj/33MA8yDm3ttZJep3lRovi7XeIJnqCbRmET0= MIME-Version: 1.0 In-Reply-To: <17ee534c-9fe6-19c4-0522-76cd3cbe5f88@users.sourceforge.net> References: <17ee534c-9fe6-19c4-0522-76cd3cbe5f88@users.sourceforge.net> From: Andy Shevchenko Date: Fri, 3 Nov 2017 14:02:37 +0200 Message-ID: Subject: Re: [PATCH v2 0/3] Sony-laptop: Adjustments for sony_nc_setup_rfkill() To: SF Markus Elfring Cc: Platform Driver , Darren Hart , Marco Chiappero , Matthew Garrett , Mattia Dongili , LKML , kernel-janitors@vger.kernel.org, Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 1, 2017 at 8:45 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 1 Nov 2017 19:34:56 +0100 > > Three update suggestions were taken into account > from static source code analysis. I have applied first two, the last one is subject to discuss a necessity of it. So, if Darren on my side than we won't apply it, if he opposes, I would hear an argument why we might need it. > > Markus Elfring (3): > Fix exception handling > Delete an unnecessary variable initialisation > Use common error handling code > --- > > v2: > Two additional suggestions were taken into account from a corresponding > source code review. > > drivers/platform/x86/sony-laptop.c | 33 ++++++++++++++++++--------------- > 1 file changed, 18 insertions(+), 15 deletions(-) > > -- > 2.14.3 > -- With Best Regards, Andy Shevchenko