From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dianders@chromium.org" <dianders@chromium.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"Vineet.Gupta1@synopsys.com" <Vineet.Gupta1@synopsys.com>,
"Eugeniy.Paltsev@synopsys.com" <Eugeniy.Paltsev@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Evgeniy.Didin@synopsys.com" <Evgeniy.Didin@synopsys.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Subject: Re: [PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO overflow calculation for 32-bit systems
Date: Tue, 27 Feb 2018 12:49:06 +0200 [thread overview]
Message-ID: <CAHp75Vfb6HQvx531bDi_j1wG=-vae73o+hcOyCGfOeQKEUpYeg@mail.gmail.com> (raw)
In-Reply-To: <20180227115243.7ca84b3b@xhacker.debian>
On Tue, Feb 27, 2018 at 5:52 AM, Jisheng Zhang
<Jisheng.Zhang@synaptics.com> wrote:
> On Mon, 26 Feb 2018 20:27:22 +0000 Alexey Brodkin wrote:
>> On Mon, 2018-02-26 at 20:30 +0200, Andy Shevchenko wrote:
>> > On Mon, Feb 26, 2018 at 7:14 PM, Evgeniy Didin
>> > <Evgeniy.Didin@synopsys.com> wrote:
>> > > On Mon, 2018-02-26 at 18:53 +0200, Andy Shevchenko wrote:
>> > > > On Mon, Feb 26, 2018 at 5:14 PM, Evgeniy Didin
>> > > > > > IIRC, someone commented on this or similar, i.e.
>> > > > > > DIV_ROUND_UP_ULL() ?
^^^^^^^^^^^^
>> So maybe we need to add export of __udivdi3() for other arches, what do you think?
> Per my understanding, Linux kernel prefer to make use of do_div or implementations
> in <linux/math64.h> for 64bit divide
To everyone in this thread. See just above. That's solution which will work.
Other than that, drop COMPILE_TEST from the Kconfig and put a comment
that driver will not compile on architectures w/o division library.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-02-27 10:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 14:34 [PATCH 0/2 v3] mmc: dw_mmc: Fix DTO/STO timeout overflow calculation Evgeniy Didin
2018-02-26 14:34 ` [PATCH 1/2 v3] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems Evgeniy Didin
2018-02-26 14:40 ` Andy Shevchenko
2018-02-27 1:14 ` Shawn Lin
2018-03-01 1:22 ` kbuild test robot
2018-02-26 14:34 ` [PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO " Evgeniy Didin
2018-02-26 14:39 ` Andy Shevchenko
2018-02-26 15:14 ` Evgeniy Didin
2018-02-26 16:53 ` Andy Shevchenko
2018-02-26 17:14 ` Evgeniy Didin
2018-02-26 18:30 ` Andy Shevchenko
2018-02-26 20:27 ` Alexey Brodkin
2018-02-27 3:52 ` Jisheng Zhang
2018-02-27 10:49 ` Andy Shevchenko [this message]
2018-02-27 3:02 ` [PATCH 0/2 v3] mmc: dw_mmc: Fix DTO/STO timeout overflow calculation Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vfb6HQvx531bDi_j1wG=-vae73o+hcOyCGfOeQKEUpYeg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Evgeniy.Didin@synopsys.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).