From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Haowen Bai <baihaowen@meizu.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: gp2ap020a00f: Fix signedness bug
Date: Thu, 14 Apr 2022 16:47:12 +0300 [thread overview]
Message-ID: <CAHp75VfbZhMvs7dHwadvNs6maPsBVOY3Mk5wkKSwZ1RANQQHDA@mail.gmail.com> (raw)
In-Reply-To: <1649933135-14236-1-git-send-email-baihaowen@meizu.com>
On Thu, Apr 14, 2022 at 2:19 PM Haowen Bai <baihaowen@meizu.com> wrote:
>
> function gp2ap020a00f_get_thresh_reg() is unsigned but returning -EINVAL
> errcode, and thresh_reg_l is unsigned but receiving -EINVAL errcode. so
> we have to change u8 -> s8.
s8 is not enough to hold an (arbitrary) error code. To be on the safe
side you need to use int.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-04-14 15:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 10:45 [PATCH] iio: gp2ap020a00f: Fix signedness bug Haowen Bai
2022-04-14 13:47 ` Andy Shevchenko [this message]
2022-04-15 1:20 ` [PATCH V2] " Haowen Bai
2022-04-15 17:52 ` Jonathan Cameron
2022-04-18 2:19 ` [PATCH V3] " Haowen Bai
2022-04-28 18:41 ` Jonathan Cameron
2022-04-29 1:36 ` [PATCH V4] " Haowen Bai
2022-05-01 15:03 ` Jonathan Cameron
2022-04-18 2:20 ` [PATCH V2] " baihaowen
2022-04-15 1:21 ` [PATCH] " baihaowen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfbZhMvs7dHwadvNs6maPsBVOY3Mk5wkKSwZ1RANQQHDA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=baihaowen@meizu.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).