From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E41FC3A5AB for ; Thu, 5 Sep 2019 08:08:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45BD121743 for ; Thu, 5 Sep 2019 08:08:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ldqIJr7r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732415AbfIEII0 (ORCPT ); Thu, 5 Sep 2019 04:08:26 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:37773 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730809AbfIEII0 (ORCPT ); Thu, 5 Sep 2019 04:08:26 -0400 Received: by mail-pl1-f195.google.com with SMTP id b10so922750plr.4; Thu, 05 Sep 2019 01:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p4cc3HD6wCgRlnUtcn0OOHFmBZxcsFw0lbNwPOQXaMs=; b=ldqIJr7rYiw3PfQqdQzuOi7dClRQkPVHQ78j0B22mJIViZA3bBPXpqOgqQfRYw477s HSy1oDmzKI7o2tp87ZoXVsuCMMg1FTgRrNOA125vjse2m5crWv6rqwXnRW/56VJ3R5Gl 5lbkaq+trdJvu3B3FD95traiLrl5n0Frg1kDdyfgETxTIwvuH7fJ3Xbi+9rw6I0LpPyh 9dEC67LHeKADIOu3uUCU5Ja1B30P0AB6ewmQ72l5j0LBBBQ7bK0tBlz8PBniTjaLAE0E RQEM8MjW7Get5PgLg3Azvc4wbNxm1078ev2AKbDiNFD7yruPq+HkHQUu0Q7SgZ/te7KX y1DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p4cc3HD6wCgRlnUtcn0OOHFmBZxcsFw0lbNwPOQXaMs=; b=EYkkE0Owejf6lNjiB9gQCxhtZgMJpWkTugTEJZOZJ+psCFQCEwQIgfs57LUIvPnYba ALZ0Cz50FqZYnHBdEHXMvUOkODG+TQEeHrKQBaCQC841myb4h3I9QHtYzCIeRmwvjNip GJ4q1SxzBbyKSWWqecZCUmsjwFj0/ZTmHpvCsibUKDjgD+JHIxQikDkWtQoGL2bsXtp8 2LKDbDF36lkUnawkqmoWSfwM688CDlfFaWAV4lvYZaE6NKL/zbO4aM1QDTo6fBlYxqz4 HPIcjh2sagwumjqUZt+sbU+7t8iQ0PP4YhiclEEx6tRIHREi5Yv56WR8DkGXVkGzUHxE XMdg== X-Gm-Message-State: APjAAAXIqN4OTT2Xo+Ue6qNUMJGhjIrA/TEXbQnyRUV52cgD8LcMZ0vR UYc8LAyp4HAeXlyilpD3Kgi/AhX1LC/r71xKTKI= X-Google-Smtp-Source: APXvYqwWrgyUGsctjbz9xkNUlborGLECclh7l27G2fO9h6X4J9/miCFZcTmLyyj7sm/bNj1c3Gs23ePhQy3qAsUB81A= X-Received: by 2002:a17:902:9348:: with SMTP id g8mr2103599plp.18.1567670905658; Thu, 05 Sep 2019 01:08:25 -0700 (PDT) MIME-Version: 1.0 References: <20190904061245.30770-1-rashmica.g@gmail.com> In-Reply-To: From: Andy Shevchenko Date: Thu, 5 Sep 2019 11:08:13 +0300 Message-ID: Subject: Re: [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks To: Rashmica Gupta Cc: Linus Walleij , "open list:GPIO SUBSYSTEM" , Bartosz Golaszewski , linux-arm Mailing List , linux-aspeed@lists.ozlabs.org, Linux Kernel Mailing List , Joel Stanley , Andrew Jeffery Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 5, 2019 at 2:17 AM Rashmica Gupta wrote: > On Wed, 2019-09-04 at 19:27 +0300, Andy Shevchenko wrote: > > On Wed, Sep 4, 2019 at 9:14 AM Rashmica Gupta > > wrote: > > > - banks = gpio->config->nr_gpios >> 5; > > > + banks = (gpio->config->nr_gpios >> 5) + 1; > > > > Shouldn't be rather DIV_ROUND_UP(nr_gpios, sizeof(u32)) ? > > I agree that DIV_ROUND_UP is the right thing to use here, but wouldn't > it be DIV_ROUND_UP(nr_gpios, 32)? Right. Either this or BITS_PER_TYPE(u32). > > > gpio->dcache = devm_kcalloc(&pdev->dev, > > > banks, sizeof(u32), > > > GFP_KERNEL); -- With Best Regards, Andy Shevchenko