From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751665AbdFGNry (ORCPT ); Wed, 7 Jun 2017 09:47:54 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:35730 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbdFGNrw (ORCPT ); Wed, 7 Jun 2017 09:47:52 -0400 MIME-Version: 1.0 In-Reply-To: <20170601111750.20880-3-jthumshirn@suse.de> References: <20170601111750.20880-1-jthumshirn@suse.de> <20170601111750.20880-3-jthumshirn@suse.de> From: Andy Shevchenko Date: Wed, 7 Jun 2017 16:47:51 +0300 Message-ID: Subject: Re: [PATCH v2 2/8] nvme: rename uuid to nguid in nvme_ns To: Johannes Thumshirn Cc: Christoph Hellwig , Sagi Grimberg , Keith Busch , Hannes Reinecke , maxg@mellanox.com, Linux NVMe Mailinglist , Linux Kernel Mailinglist Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 1, 2017 at 2:17 PM, Johannes Thumshirn wrote: > The uuid field in the nvme_ns structure represents the nguid field > from the identify namespace command. And as NVMe 1.3 introduced an > UUID in the NVMe Namespace Identification Descriptor this will > collide. > > So rename the uuid to nguid to prevent any further > confusion. Unfortunately we export the nguid to sysfs in the uuid > sysfs attribute, but this can't be changed anymore without possibly > breaking existing userspace. > > Signed-off-by: Johannes Thumshirn > Reviewed-by: Christoph Hellwig > Reviewed-by: Hannes Reinecke I suppose it should go through UUID tree? -- With Best Regards, Andy Shevchenko