From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756484AbdAKB7X (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Jan 2017 20:59:23 -0500
Received: from mail-qt0-f196.google.com ([209.85.216.196]:34675 "EHLO
        mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754718AbdAKB7V (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Jan 2017 20:59:21 -0500
MIME-Version: 1.0
In-Reply-To: <a9b14d1d-de5c-5a22-fcd0-021d7b01cb36@users.sourceforge.net>
References: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> <a9b14d1d-de5c-5a22-fcd0-021d7b01cb36@users.sourceforge.net>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Wed, 11 Jan 2017 03:59:20 +0200
Message-ID: <CAHp75Vfd_OEUcJacRGi5m1fkNiiGuu9HQv0zb6turiDMkpiNxA@mail.gmail.com>
Subject: Re: [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area_init()
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Harjani Ritesh <riteshh@codeaurora.org>, Jens Axboe <axboe@fb.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Mike Christie <mchristi@redhat.com>,
        Shawn Lin <shawn.lin@rock-chips.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jan 8, 2017 at 11:42 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 8 Jan 2017 18:44:26 +0100
>
> * A multiplication for the size determination of a memory allocation
>   indicated that an array data structure should be processed.
>   Thus use the corresponding function "kmalloc_array".
>
>   This issue was detected by using the Coccinelle software.
>
> * Replace the specification of a data structure by a pointer dereference
>   to make the corresponding size determination a bit safer according to
>   the Linux coding style convention.

For the whole series FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>


P.S. Few years back I run those tests a lot, even did some
modifications, but now Nokia Mobile just gone :-)

>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/mmc/core/mmc_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index 3ab6e52d106c..e85ef503d7ce 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -1579,7 +1579,7 @@ static int mmc_test_area_init(struct mmc_test_card *test, int erase, int fill)
>         if (!t->mem)
>                 return -ENOMEM;
>
> -       t->sg = kmalloc(sizeof(struct scatterlist) * t->max_segs, GFP_KERNEL);
> +       t->sg = kmalloc_array(t->max_segs, sizeof(*t->sg), GFP_KERNEL);
>         if (!t->sg) {
>                 ret = -ENOMEM;
>                 goto out_free;
> --
> 2.11.0
>



-- 
With Best Regards,
Andy Shevchenko