From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 0/8] HID: Consolidate serializing ope/close in transport drivers
Date: Wed, 7 Jun 2017 11:45:39 +0300 [thread overview]
Message-ID: <CAHp75Vfhf4vfrJP4uorMyqNVYBFr3X8U0iZWuk1jCnw2qPoB=A@mail.gmail.com> (raw)
In-Reply-To: <20170607065938.33332-1-dmitry.torokhov@gmail.com>
On Wed, Jun 7, 2017 at 9:59 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> This originally came about as report of uhid sending duplicate open and
> premature close when hidraw was used alongside of input. After looking at
> the drivers I think we should consolidate user tracking inside of the HID
> core. While implementing this, there were a few cleanups as well.
>
> V2:
>
> - added greybus hid changes
> - added error handling in hiddev around hid_hw_open which is __much_check
FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Dmitry Torokhov (8):
> HID: hiddev: use hid_hw_open/close instead of usbhid_open/close
> HID: hiddev: use hid_hw_power instead of usbhid_get/put_power
> HID: usbhid: do not rely on hid->open when deciding to do IO
> HID: serialize hid_hw_open and hid_hw_close
> HID: i2c-hid: remove custom locking from i2c_hid_open/close
> HID: usbhid: remove custom locking from usbhid_open/close
> greybus: hid: remove custom locking from gb_hid_open/close
> HID: remove no longer used hid->open field
>
> drivers/hid/hid-core.c | 89 +++++++++++++++++++++++++
> drivers/hid/i2c-hid/i2c-hid.c | 32 +++------
> drivers/hid/usbhid/hid-core.c | 150 ++++++++++++++++++++----------------------
> drivers/hid/usbhid/hiddev.c | 24 +++----
> drivers/hid/usbhid/usbhid.h | 15 +++--
> drivers/staging/greybus/hid.c | 43 ++++--------
> include/linux/hid.h | 73 +++-----------------
> 7 files changed, 214 insertions(+), 212 deletions(-)
>
> Thanks.
>
> --
> Dmitry
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-06-07 8:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 6:59 [PATCH v2 0/8] HID: Consolidate serializing ope/close in transport drivers Dmitry Torokhov
2017-06-07 6:59 ` [PATCH v2 1/8] HID: hiddev: use hid_hw_open/close instead of usbhid_open/close Dmitry Torokhov
2017-06-07 6:59 ` [PATCH v2 2/8] HID: hiddev: use hid_hw_power instead of usbhid_get/put_power Dmitry Torokhov
2017-06-07 8:40 ` Andy Shevchenko
2017-06-07 6:59 ` [PATCH v2 3/8] HID: usbhid: do not rely on hid->open when deciding to do IO Dmitry Torokhov
2017-06-07 6:59 ` [PATCH v2 4/8] HID: serialize hid_hw_open and hid_hw_close Dmitry Torokhov
2017-06-07 6:59 ` [PATCH v2 5/8] HID: i2c-hid: remove custom locking from i2c_hid_open/close Dmitry Torokhov
2017-06-07 6:59 ` [PATCH v2 6/8] HID: usbhid: remove custom locking from usbhid_open/close Dmitry Torokhov
2017-06-07 6:59 ` [PATCH v2 7/8] greybus: hid: remove custom locking from gb_hid_open/close Dmitry Torokhov
2017-06-07 7:56 ` Greg Kroah-Hartman
2017-06-07 10:02 ` Viresh Kumar
2017-06-07 6:59 ` [PATCH v2 8/8] HID: remove no longer used hid->open field Dmitry Torokhov
2017-06-07 8:45 ` Andy Shevchenko [this message]
2017-06-07 13:43 ` [PATCH v2 0/8] HID: Consolidate serializing ope/close in transport drivers Benjamin Tissoires
2017-06-08 11:56 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vfhf4vfrJP4uorMyqNVYBFr3X8U0iZWuk1jCnw2qPoB=A@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).