From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB93C43217 for ; Fri, 22 Oct 2021 13:36:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 531136112F for ; Fri, 22 Oct 2021 13:36:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232868AbhJVNjG (ORCPT ); Fri, 22 Oct 2021 09:39:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231658AbhJVNjE (ORCPT ); Fri, 22 Oct 2021 09:39:04 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F5FFC061764; Fri, 22 Oct 2021 06:36:46 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id e19so3227197edy.0; Fri, 22 Oct 2021 06:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3VqjR5oI/ait3rohMOusYdeugPboOfYtc3O9o05eMHQ=; b=Q1yRtDerJPfkd6V6vThQqZzlZX02K8g1faPyh5JvGtWbxyqlvyJdVLUGTYwPQ3saLq //fIB06jwTGHRGxKPLs8MJWyLB830xmXmsTkCETeG1taPcahOXie4rvc7CK5zltFt8oF oPUshuRuTnd0iZXy0ny9kVNx8mrm1ouS31YXXV69DYolYaT48xWqECVE7DhkqpFj8Azm VWMFDlsZTra/bzin+kya2NessF7ZGFHODA9zaBsoaYq5uCJaZikR/QWJcRu4iqFGwBxl 7SUxGngqa3kITyZSSsSKeCn5rbO8WWtCwQv7XozRKVi8eu+fjf3xq7bGmV9vMO/W2GeJ DmEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3VqjR5oI/ait3rohMOusYdeugPboOfYtc3O9o05eMHQ=; b=LA0O2ritGvHs42KGT2DfYX62qe8ITDzUTgz14pdTQ+Ni3AIMsYNJcA40Pn5JOabVnK 87brKmiOojCeim57Kn+uUWiTdUQnb34hf6CvomFeL2qRkZNdOscWyHoWxwyhS4c1uOP7 MxqPczorrJT46LtNePqqPBjn3DAXg5Ndoj4hDx3IL3vLEiDlMTjdH+wWgm0dvaXKyRZU SrTMT8KhUlbWi2Y924iVUpBeTIxEHzHvo7/VYtS5qeJE+ESnIMVmumuODQoLDmuMSNLG VSvoygyK/RZYigSjMDhGQYmou2BW9i+PGOU5O6Ln+bmTE/I8mB5ys7gTCpfZq21XSFMq 3GHA== X-Gm-Message-State: AOAM5318jS0lKWZF04wL+wimiEv+AuQOU5uWYs63r2B+KakiCXel7Ruh yyGYxtyrdky1OwUpy6cALAS+zFqZ/EFuSTLHAyU= X-Google-Smtp-Source: ABdhPJxTUPfm1rVOGx8gokzVv5igP9B4UGk9EquAWiBprb/AKADuLLwJMD4BsQNPgSHNpLkA0ym/zi0SHdqrUZTvc64= X-Received: by 2002:a17:906:5a47:: with SMTP id my7mr14903725ejc.128.1634909805119; Fri, 22 Oct 2021 06:36:45 -0700 (PDT) MIME-Version: 1.0 References: <20211021174223.43310-1-kernel@esmil.dk> <20211021174223.43310-7-kernel@esmil.dk> In-Reply-To: From: Andy Shevchenko Date: Fri, 22 Oct 2021 16:35:49 +0300 Message-ID: Subject: Re: [PATCH v2 06/16] clk: starfive: Add JH7100 clock generator driver To: Emil Renner Berthing Cc: linux-riscv , devicetree , linux-clk , "open list:GPIO SUBSYSTEM" , "open list:SERIAL DRIVERS" , Geert Uytterhoeven , Palmer Dabbelt , Paul Walmsley , Rob Herring , Michael Turquette , Stephen Boyd , Thomas Gleixner , Marc Zyngier , Philipp Zabel , Linus Walleij , Greg Kroah-Hartman , Daniel Lezcano , Andy Shevchenko , Jiri Slaby , Maximilian Luz , Sagar Kadam , Drew Fustini , Michael Zhu , Fu Wei , Anup Patel , Atish Patra , Matteo Croce , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 22, 2021 at 4:13 PM Emil Renner Berthing wrote: > On Fri, 22 Oct 2021 at 14:34, Andy Shevchenko wrote: ... > Hmm.. this function doesn't return int, but struct clk_hw *, hence the ERR_PTR. Ah, indeed, sorry. Got your point. Of course one may try 'return ERR_PTR(dev_err_probe())', but this looks ugly. -- With Best Regards, Andy Shevchenko