From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 612B2C47098 for ; Fri, 4 Jun 2021 10:23:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40EC861404 for ; Fri, 4 Jun 2021 10:23:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230101AbhFDKYr (ORCPT ); Fri, 4 Jun 2021 06:24:47 -0400 Received: from mail-pj1-f53.google.com ([209.85.216.53]:52844 "EHLO mail-pj1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbhFDKYq (ORCPT ); Fri, 4 Jun 2021 06:24:46 -0400 Received: by mail-pj1-f53.google.com with SMTP id h16so5309372pjv.2; Fri, 04 Jun 2021 03:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aUTAR6wf3YjHvE8+6bjBL3/E962RYRKJQK58myGqUmo=; b=L30wT9Gqzu4Awu7kONktI1IDMc9NsZdNoJ8lA7zfngTzBLSGNIdxGF27OrmMGpOes2 NCHhHQqIIvIuIrghRnAUcYJFwQkPv+bVNz28ZyWSkQnxBV/ySlmFlc/tNXEu1keHQKcU tOyJTfyocsBvW4COyd7jQyNEmqdxJ2TYsyEeLkmo+goJIEdTDkGRIiV06oxzN+mgSV0A cvBKAmYQ9iZ5h35JJmLAWsEVklfeTKWclOgJ9qnXC5fQmPut7pKgGjirxe6IZc9DDy53 lHsTUWh0L5vLGSj4IrUPGXAIvsbPpAKCf49KClLz+aSsX3snEKv6pBEdp40bkof5BySK nOrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aUTAR6wf3YjHvE8+6bjBL3/E962RYRKJQK58myGqUmo=; b=e5jMALYzshO2ciXGPEB0sI9UfhsbuaWMOF6U45+vqF98btd1r6jXUqixjXN/H7zySo WRUXZXT9A4ZeXcuLsT5D4pg4mvc+8vVyr97O5Uh9QQph1WkNtD0wAFXN4+424JqHJn3E mazOG15vm7AMSAMixNGhZqzY3G4UBiiXR9OXPO/S9L6wKra09EFtW0+awV2jkDp3rRpg ToCTYwXecoPt21w5D8vIwAJ2GTSugff1BABkbB6mwoCYvalnbEcnYpWKkhczSBhOETfw rhJNfbI6OawcB9k36v8CZKmC3Mg4wwdAtLvsbKyNQRZkgw0rTyXmWBzKmU/Q/hBZkn4h l5Cg== X-Gm-Message-State: AOAM5301LA/XkRPvgtzyxXuUBpU26rojzUqPlG9NCstpAKcWNSCNZ83h AVltw8/rJAh8qQTMyjRaVFWZtKo6+LJAulGJrrk= X-Google-Smtp-Source: ABdhPJz0oU98a0IEMUBvGYHgVWiHvtHkWNGD3vRTHMitz6twCDnTyAUyXMyaiL9RpUbfVkqVHjdEnWAwNttkcCue/po= X-Received: by 2002:a17:90a:17ad:: with SMTP id q42mr16339993pja.181.1622802120096; Fri, 04 Jun 2021 03:22:00 -0700 (PDT) MIME-Version: 1.0 References: <20210603101822.9645-1-steven_lee@aspeedtech.com> <20210603101822.9645-4-steven_lee@aspeedtech.com> <20210604021422.GA25112@aspeedtech.com> In-Reply-To: <20210604021422.GA25112@aspeedtech.com> From: Andy Shevchenko Date: Fri, 4 Jun 2021 13:21:43 +0300 Message-ID: Subject: Re: [PATCH v3 3/5] gpio: gpio-aspeed-sgpio: Add AST2600 sgpio support To: Steven Lee Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Joel Stanley , Andrew Jeffery , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , "Hongweiz@ami.com" , Ryan Chen , Billy Tsai Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 4, 2021 at 5:14 AM Steven Lee wrote: > The 06/03/2021 19:05, Andy Shevchenko wrote: > > On Thu, Jun 3, 2021 at 1:19 PM Steven Lee wrote: > > > +#define GPIO_OFFSET(x) ((x) & 0x1f) > > > > GENMASK() > > > > ... > > > > Do you mean the macro should be modified as follows? > #define GPIO_OFFSET(x) ((x) & GENMASK(4, 0)) Yes. -- With Best Regards, Andy Shevchenko