From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98353C433ED for ; Mon, 27 Jul 2020 13:39:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BD1A2083B for ; Mon, 27 Jul 2020 13:39:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sRkfP9q3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729087AbgG0NjA (ORCPT ); Mon, 27 Jul 2020 09:39:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729069AbgG0Niz (ORCPT ); Mon, 27 Jul 2020 09:38:55 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B792DC0619D2; Mon, 27 Jul 2020 06:38:55 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id t6so8012917plo.3; Mon, 27 Jul 2020 06:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ocZOH/qAxVzRpNDtMIHAj3P48sK/ccO+2zMNnR18J60=; b=sRkfP9q3WiUQNGxVKytVTA1DxMULQ/VpKMX43DZfHIchAb8n8WZeFwIcz7WFSx0GFt I5pi6jULLnS1k1rcTUtnuCjfKn8GD6VSztgUjZn9iTnNr7DF8cjShczCSXPemWLuhBnD VhJSQPrl6F00RB7O1eum8MXUk4H/LrqTYmyFSz/nF9V50sABvZvWSLb2UQVS6g0itTzs AY2rx0Dt51Q8dTGMOt3kjZ55kmGjxOCkBJo+67SJbdRoWXvmWiAkpXqBYirPmMq+6pGy H/b0GRm473V71yIkzP5jGOgWdLFNP2gAtrlyNVxmhTwKs7lQKXF+ULCG3jdkDviFE2Kr UPRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ocZOH/qAxVzRpNDtMIHAj3P48sK/ccO+2zMNnR18J60=; b=PZCHAFukM3ocBNzung60vQSSkDWhwCLuscQWJIafyJLitRJsC9Bg6b+/irzkVcEuvO no8jNCrv353Q+s535tCO36fuVpJO6gA88JQwNe/0dTj3QPZqpL8bBZCBxYg14lovVI7d sl+XMuyDlSETOIQQfpxYK9o3Q1lT5jB8SO2eIcH/nAxq9KGpD8/SkPLgiQPaRRYxM+YF jDvJRu4HU84/GUk2CVwf6jIS9qK/eXLNdR6tV/1xyglOwcNfjwEhEoa0uDyvF83Vjqyt 1QQj14fKtVOHFwdqj11EQDcZu+Z/147O6x9bcv2vY7MdfAkiMT/4lkEl29lgwAMAKPwM jgXw== X-Gm-Message-State: AOAM530nLEjArBy0v3gDWeQUcUE0mpKGfKjo+N9BoBepEKMcuuyigVmN qxLduY3Xc0nHR/BZl0cNKBt5P09cyEmVEO3BrywVlyJrgAk= X-Google-Smtp-Source: ABdhPJwaumQ02E9kw/pSB9Ks/8s/ndn264SasBMVkqJLVdv2Odq4jIRDRFnIFEdRIJwqqZ6RH6bxyj0fK/UPvLukTjo= X-Received: by 2002:a17:90a:a393:: with SMTP id x19mr16574129pjp.228.1595857135248; Mon, 27 Jul 2020 06:38:55 -0700 (PDT) MIME-Version: 1.0 References: <20200727131742.82289-1-vaibhavgupta40@gmail.com> In-Reply-To: <20200727131742.82289-1-vaibhavgupta40@gmail.com> From: Andy Shevchenko Date: Mon, 27 Jul 2020 16:38:40 +0300 Message-ID: Subject: Re: [PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable To: Vaibhav Gupta Cc: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Mark Brown , linux-spi , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2020 at 4:21 PM Vaibhav Gupta wrote: > > Before generic upgrade, both .suspend() and .resume() were invoking > pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both > states. (Normal trend is .suspend() enables and .resume() disables the > wakeup.) > > This was ambiguous and may be buggy. Instead of replicating the legacy > behavior, drop the wakeup-disable call. > > Fix: f185bcc77980("spi: spi-topcliff-pch: use generic power management") Fixes: and missed space. Note: % grep one ~/.gitconfig one = show -s --pretty='format:%h (\"%s\")' % git one f185bcc77980 f185bcc77980 ("spi: spi-topcliff-pch: use generic power management") > Reported by: Andy Shevchenko Missed dash. Does checkpatch complain? > Signed-off-by: Vaibhav Gupta > --- > drivers/spi/spi-topcliff-pch.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c > index 281a90f1b5d8..c73a03ddf5f3 100644 > --- a/drivers/spi/spi-topcliff-pch.c > +++ b/drivers/spi/spi-topcliff-pch.c > @@ -1648,8 +1648,6 @@ static int __maybe_unused pch_spi_resume(struct device *dev) > > dev_dbg(dev, "%s ENTRY\n", __func__); > > - device_wakeup_disable(dev); > - > /* set suspend status to false */ > pd_dev_save->board_dat->suspend_sts = false; > > -- > 2.27.0 > -- With Best Regards, Andy Shevchenko