linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the gpio tree
@ 2020-04-01  4:19 Stephen Rothwell
  2020-04-01  7:49 ` Geert Uytterhoeven
  2020-04-01  8:19 ` Linus Walleij
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2020-04-01  4:19 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Thierry Reding

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

Hi all,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: "of_pinctrl_get" [drivers/gpio/gpio-tegra186.ko] undefined!

Caused by commit

  b64d6c9a6a05 ("gpio: tegra186: Add support for pin ranges")

and not fixed by commit

  e45ee71ae101 ("pinctrl: Define of_pinctrl_get() dummy for !PINCTRL")

CONFIG_OF=y
CONFIG_PINCTRL=y
CONFIG_GPIO_TEGRA186=m

I applied this patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 1 Apr 2020 15:14:32 +1100
Subject: [PATCH] gpio: export of_pinctrl_get to modules

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/pinctrl/devicetree.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/devicetree.c b/drivers/pinctrl/devicetree.c
index 1ed20ac2243f..c6fe7d64c913 100644
--- a/drivers/pinctrl/devicetree.c
+++ b/drivers/pinctrl/devicetree.c
@@ -103,6 +103,7 @@ struct pinctrl_dev *of_pinctrl_get(struct device_node *np)
 {
 	return get_pinctrl_dev_from_of_node(np);
 }
+EXPORT_SYMBOL_GPL(of_pinctrl_get);
 
 static int dt_to_map_one_config(struct pinctrl *p,
 				struct pinctrl_dev *hog_pctldev,
-- 
2.25.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2020-04-01  4:19 linux-next: build failure after merge of the gpio tree Stephen Rothwell
@ 2020-04-01  7:49 ` Geert Uytterhoeven
  2020-04-01  7:57   ` Stephen Rothwell
  2020-04-01  8:18   ` Linus Walleij
  2020-04-01  8:19 ` Linus Walleij
  1 sibling, 2 replies; 103+ messages in thread
From: Geert Uytterhoeven @ 2020-04-01  7:49 UTC (permalink / raw)
  To: Stephen Rothwell, Linus Walleij
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Thierry Reding

Hi Stephen, LinusW,

On Wed, Apr 1, 2020 at 6:21 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 1 Apr 2020 15:14:32 +1100
> Subject: [PATCH] gpio: export of_pinctrl_get to modules
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Thanks for your patch, which I assume is a quick build fix.
I see LinusW has already applied it...

> --- a/drivers/pinctrl/devicetree.c
> +++ b/drivers/pinctrl/devicetree.c
> @@ -103,6 +103,7 @@ struct pinctrl_dev *of_pinctrl_get(struct device_node *np)
>  {
>         return get_pinctrl_dev_from_of_node(np);
>  }
> +EXPORT_SYMBOL_GPL(of_pinctrl_get);
>
>  static int dt_to_map_one_config(struct pinctrl *p,
>                                 struct pinctrl_dev *hog_pctldev,

As exporting symbols has its (space) cost, and of_pinctrl_get() is a tiny
function, what about making it an inline function in
include/linux/pinctrl/pinctrl.h instead?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2020-04-01  7:49 ` Geert Uytterhoeven
@ 2020-04-01  7:57   ` Stephen Rothwell
  2020-04-01  8:18   ` Linus Walleij
  1 sibling, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2020-04-01  7:57 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linus Walleij, Linux Next Mailing List,
	Linux Kernel Mailing List, Thierry Reding

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

Hi Geert,

On Wed, 1 Apr 2020 09:49:00 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Thanks for your patch, which I assume is a quick build fix.

Yep, rather than reverting the other patches again.

> I see LinusW has already applied it...
> 
> > --- a/drivers/pinctrl/devicetree.c
> > +++ b/drivers/pinctrl/devicetree.c
> > @@ -103,6 +103,7 @@ struct pinctrl_dev *of_pinctrl_get(struct device_node *np)
> >  {
> >         return get_pinctrl_dev_from_of_node(np);
> >  }
> > +EXPORT_SYMBOL_GPL(of_pinctrl_get);
> >
> >  static int dt_to_map_one_config(struct pinctrl *p,
> >                                 struct pinctrl_dev *hog_pctldev,  
> 
> As exporting symbols has its (space) cost, and of_pinctrl_get() is a tiny
> function, what about making it an inline function in
> include/linux/pinctrl/pinctrl.h instead?

Makes sense to me.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2020-04-01  7:49 ` Geert Uytterhoeven
  2020-04-01  7:57   ` Stephen Rothwell
@ 2020-04-01  8:18   ` Linus Walleij
  2020-04-01  8:24     ` Geert Uytterhoeven
  1 sibling, 1 reply; 103+ messages in thread
From: Linus Walleij @ 2020-04-01  8:18 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Thierry Reding

On Wed, Apr 1, 2020 at 9:49 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> > +EXPORT_SYMBOL_GPL(of_pinctrl_get);
>
> As exporting symbols has its (space) cost, and of_pinctrl_get() is a tiny
> function, what about making it an inline function in
> include/linux/pinctrl/pinctrl.h instead?

I'm all for it! :)

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2020-04-01  4:19 linux-next: build failure after merge of the gpio tree Stephen Rothwell
  2020-04-01  7:49 ` Geert Uytterhoeven
@ 2020-04-01  8:19 ` Linus Walleij
  1 sibling, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2020-04-01  8:19 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Thierry Reding

On Wed, Apr 1, 2020 at 6:19 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 1 Apr 2020 15:14:32 +1100
> Subject: [PATCH] gpio: export of_pinctrl_get to modules
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

As noted by Geert I simply applied this to quickly repair
the build. Thanks a lot Stephen!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2020-04-01  8:18   ` Linus Walleij
@ 2020-04-01  8:24     ` Geert Uytterhoeven
  2020-04-01 12:29       ` Andy Shevchenko
  0 siblings, 1 reply; 103+ messages in thread
From: Geert Uytterhoeven @ 2020-04-01  8:24 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Thierry Reding

Hi Linus,

On Wed, Apr 1, 2020 at 10:19 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Apr 1, 2020 at 9:49 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > +EXPORT_SYMBOL_GPL(of_pinctrl_get);
> >
> > As exporting symbols has its (space) cost, and of_pinctrl_get() is a tiny
> > function, what about making it an inline function in
> > include/linux/pinctrl/pinctrl.h instead?
>
> I'm all for it! :)

Want me to send a patch?
Which base?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2020-04-01  8:24     ` Geert Uytterhoeven
@ 2020-04-01 12:29       ` Andy Shevchenko
  2020-04-01 12:30         ` Andy Shevchenko
  0 siblings, 1 reply; 103+ messages in thread
From: Andy Shevchenko @ 2020-04-01 12:29 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linus Walleij, Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Thierry Reding

On Wed, Apr 1, 2020 at 11:26 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Apr 1, 2020 at 10:19 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Wed, Apr 1, 2020 at 9:49 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > +EXPORT_SYMBOL_GPL(of_pinctrl_get);
> > >
> > > As exporting symbols has its (space) cost, and of_pinctrl_get() is a tiny
> > > function, what about making it an inline function in
> > > include/linux/pinctrl/pinctrl.h instead?
> >
> > I'm all for it! :)
>
> Want me to send a patch?
> Which base?

Wouldn't we need to export the inside function in that case?
If so, we need a better name for it.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2020-04-01 12:29       ` Andy Shevchenko
@ 2020-04-01 12:30         ` Andy Shevchenko
  0 siblings, 0 replies; 103+ messages in thread
From: Andy Shevchenko @ 2020-04-01 12:30 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linus Walleij, Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Thierry Reding

On Wed, Apr 1, 2020 at 3:29 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Wed, Apr 1, 2020 at 11:26 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, Apr 1, 2020 at 10:19 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> > > On Wed, Apr 1, 2020 at 9:49 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > > +EXPORT_SYMBOL_GPL(of_pinctrl_get);
> > > >
> > > > As exporting symbols has its (space) cost, and of_pinctrl_get() is a tiny
> > > > function, what about making it an inline function in
> > > > include/linux/pinctrl/pinctrl.h instead?
> > >
> > > I'm all for it! :)
> >
> > Want me to send a patch?
> > Which base?
>
> Wouldn't we need to export the inside function in that case?
> If so, we need a better name for it.

And wouldn't be cost even more expensive in such case due length of
the function name?


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2020-11-18  3:30 Stephen Rothwell
@ 2020-11-18  7:50 ` Linus Walleij
  0 siblings, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2020-11-18  7:50 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Srinivas Neeli, Linux Kernel Mailing List, Linux Next Mailing List

On Wed, Nov 18, 2020 at 4:30 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> drivers/gpio/gpio-xilinx.c: In function 'xgpio_remove':
> drivers/gpio/gpio-xilinx.c:275:2: error: implicit declaration of function 'pm_runtime_disable' [-Werror=implicit-function-declaration]
>   275 |  pm_runtime_disable(&pdev->dev);
>       |  ^~~~~~~~~~~~~~~~~~
>
> Caused by commit
>
>   fbbeb6c0a1d0 ("gpio: gpio-xilinx: Add remove function")

Ooops my fault for merging patches out-of-order, I'll go in
and fix it up manually by removing the pm call from remove().

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2020-11-18  3:30 Stephen Rothwell
  2020-11-18  7:50 ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2020-11-18  3:30 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Srinivas Neeli, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

Hi all,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpio/gpio-xilinx.c: In function 'xgpio_remove':
drivers/gpio/gpio-xilinx.c:275:2: error: implicit declaration of function 'pm_runtime_disable' [-Werror=implicit-function-declaration]
  275 |  pm_runtime_disable(&pdev->dev);
      |  ^~~~~~~~~~~~~~~~~~

Caused by commit

  fbbeb6c0a1d0 ("gpio: gpio-xilinx: Add remove function")

I have used the gpio tree from next-20201117 for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2020-03-30  7:58 Stephen Rothwell
  0 siblings, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2020-03-30  7:58 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Thierry Reding, Vidya Sagar

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

Hi all,

After merging the gpio tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

drivers/gpio/gpiolib.c: In function 'gpiochip_generic_request':
drivers/gpio/gpiolib.c:2756:32: error: 'struct gpio_device' has no member named 'pin_ranges'
 2756 |  if (!list_empty(&chip->gpiodev->pin_ranges))
      |                                ^~

Caused by commit

  2ab73c6d8323 ("gpio: Support GPIO controllers without pin-ranges")

# CONFIG_PINCTRL is not set

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2020-03-30  6:11 Stephen Rothwell
  0 siblings, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2020-03-30  6:11 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Thierry Reding, Vidya Sagar

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

Hi all,

After merging the gpio tree, today's linux-next build (x86_64 allmodconfig
build) failed like this:

ERROR: modpost: "of_pinctrl_get" [drivers/gpio/gpio-tegra186.ko] undefined!

Caused by commit

  b64d6c9a6a05 ("gpio: tegra186: Add support for pin ranges")

I have reverted that commit for today (along with the following commit).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2019-08-16 11:38 Stephen Rothwell
@ 2019-08-16 22:25 ` Linus Walleij
  0 siblings, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2019-08-16 22:25 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Thierry Reding, Brian Masney

On Fri, Aug 16, 2019 at 1:38 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the gpio tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:

Oops!

> I have applied the following patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 16 Aug 2019 21:29:30 +1000
> Subject: [PATCH] gpio: stubs in headers should be inline
>
> Fixes: fdd61a013a24 ("gpio: Add support for hierarchical IRQ domains")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

I just nicked that and applied to the GPIO tree to fix this.

Thanks Stephen!

Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2019-08-16 11:38 Stephen Rothwell
  2019-08-16 22:25 ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2019-08-16 11:38 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Thierry Reding, Brian Masney

[-- Attachment #1: Type: text/plain, Size: 2314 bytes --]

Hi all,

After merging the gpio tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

In file included from include/asm-generic/gpio.h:13,
                 from include/linux/gpio.h:62,
                 from include/linux/of_gpio.h:16,
                 from arch/powerpc/platforms/44x/warp.c:14:
include/linux/gpio/driver.h:546:13: error: 'gpiochip_populate_parent_fwspec_fourcell' defined but not used [-Werror=unused-function]
 static void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/gpio/driver.h:539:13: error: 'gpiochip_populate_parent_fwspec_twocell' defined but not used [-Werror=unused-function]
 static void gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *chip,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

and several more similar ...

Caused by commit

  fdd61a013a24 ("gpio: Add support for hierarchical IRQ domains")

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 16 Aug 2019 21:29:30 +1000
Subject: [PATCH] gpio: stubs in headers should be inline

Fixes: fdd61a013a24 ("gpio: Add support for hierarchical IRQ domains")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/gpio/driver.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index f285fee898f6..13c7d7ff497d 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -536,14 +536,14 @@ void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
 
 #else
 
-static void gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *chip,
+static inline void gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *chip,
 						    struct irq_fwspec *fwspec,
 						    unsigned int parent_hwirq,
 						    unsigned int parent_type)
 {
 }
 
-static void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
+static inline void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
 						     struct irq_fwspec *fwspec,
 						     unsigned int parent_hwirq,
 						     unsigned int parent_type)
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2018-12-17  8:24 Stephen Rothwell
  0 siblings, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2018-12-17  8:24 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

Hi all,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/memory/omap-gpmc.c: In function 'gpmc_probe_generic_child':
drivers/memory/omap-gpmc.c:2174:9: error: type of formal parameter 4 is incomplete
         0);
         ^

Caused by commit

  21abf103818a ("gpio: Pass a flag to gpiochip_request_own_desc()")

I have used the gpio tree from next-20181214 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2018-12-10  7:00 Stephen Rothwell
  0 siblings, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2018-12-10  7:00 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Vladimir Zapolskiy

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "irq_chip_retrigger_hierarchy" [drivers/gpio/gpio-lpc18xx.ko] undefined!

Caused by commit

  5ddabfe8d3de ("gpio: lpc18xx: add GPIO pin interrupt controller support")

I have used the gpio tree from next-20181207 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2017-11-13 11:33 ` Stephen Rothwell
@ 2017-11-13 13:40   ` Masahiro Yamada
  0 siblings, 0 replies; 103+ messages in thread
From: Masahiro Yamada @ 2017-11-13 13:40 UTC (permalink / raw)
  To: Stephen Rothwell, Linus Walleij
  Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra,
	Linux-Next Mailing List, Linux Kernel Mailing List

2017-11-13 20:33 GMT+09:00 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi all,
>
> On Thu, 2 Nov 2017 16:20:38 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the gpio tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> drivers/gpio/gpio-uniphier.c:324:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>>   .activate = uniphier_gpio_irq_domain_activate,
>>               ^
>>
>> Caused by commit
>>
>>   dbe776c2ca54 ("gpio: uniphier: add UniPhier GPIO controller driver")
>>
>> interacting with commit
>>
>>   72491643469a ("genirq/irqdomain: Update irq_domain_ops.activate() signature")
>>
>> from the tip tree
>>
>> I added the following merge fix patch:
>>
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Thu, 2 Nov 2017 16:10:46 +1100
>> Subject: [PATCH] gpio: uniphier: merge fix for "Update
>>  irq_domain_ops.activate() signature"
>>
>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> ---
>>  drivers/gpio/gpio-uniphier.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpio/gpio-uniphier.c b/drivers/gpio/gpio-uniphier.c
>> index d62cea4ed6b7..d0069202ade3 100644
>> --- a/drivers/gpio/gpio-uniphier.c
>> +++ b/drivers/gpio/gpio-uniphier.c
>> @@ -300,13 +300,15 @@ static int uniphier_gpio_irq_domain_alloc(struct irq_domain *domain,
>>       return irq_domain_alloc_irqs_parent(domain, virq, 1, &parent_fwspec);
>>  }
>>
>> -static void uniphier_gpio_irq_domain_activate(struct irq_domain *domain,
>> -                                           struct irq_data *data)
>> +static int uniphier_gpio_irq_domain_activate(struct irq_domain *domain,
>> +                                           struct irq_data *data,
>> +                                           bool early)
>>  {
>>       struct uniphier_gpio_priv *priv = domain->host_data;
>>       struct gpio_chip *chip = &priv->chip;
>>
>>       gpiochip_lock_as_irq(chip, data->hwirq + UNIPHIER_GPIO_IRQ_OFFSET);
>> +     return 0;
>>  }
>>
>>  static void uniphier_gpio_irq_domain_deactivate(struct irq_domain *domain,
>
> Just a reminder that this conflict still exists.
>

Thanks for the reminder.


Linus,

Is it possible to forward this one?
http://patchwork.ozlabs.org/patch/837435/


I'd like to eliminate coding style warning where possible.


Just a slight change of coding style.
I kept Stephen's authorship and Signed-off-by as-is.





-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2017-11-02  5:20 Stephen Rothwell
  2017-11-02  5:33 ` Masahiro Yamada
  2017-11-03  7:50 ` Linus Walleij
@ 2017-11-13 11:33 ` Stephen Rothwell
  2017-11-13 13:40   ` Masahiro Yamada
  2 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2017-11-13 11:33 UTC (permalink / raw)
  To: Linus Walleij, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
	Peter Zijlstra
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Masahiro Yamada

Hi all,

On Thu, 2 Nov 2017 16:20:38 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the gpio tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/gpio/gpio-uniphier.c:324:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .activate = uniphier_gpio_irq_domain_activate,
>               ^
> 
> Caused by commit
> 
>   dbe776c2ca54 ("gpio: uniphier: add UniPhier GPIO controller driver")
> 
> interacting with commit
> 
>   72491643469a ("genirq/irqdomain: Update irq_domain_ops.activate() signature")
> 
> from the tip tree
> 
> I added the following merge fix patch:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 2 Nov 2017 16:10:46 +1100
> Subject: [PATCH] gpio: uniphier: merge fix for "Update
>  irq_domain_ops.activate() signature"
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/gpio/gpio-uniphier.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-uniphier.c b/drivers/gpio/gpio-uniphier.c
> index d62cea4ed6b7..d0069202ade3 100644
> --- a/drivers/gpio/gpio-uniphier.c
> +++ b/drivers/gpio/gpio-uniphier.c
> @@ -300,13 +300,15 @@ static int uniphier_gpio_irq_domain_alloc(struct irq_domain *domain,
>  	return irq_domain_alloc_irqs_parent(domain, virq, 1, &parent_fwspec);
>  }
>  
> -static void uniphier_gpio_irq_domain_activate(struct irq_domain *domain,
> -					      struct irq_data *data)
> +static int uniphier_gpio_irq_domain_activate(struct irq_domain *domain,
> +					      struct irq_data *data,
> +					      bool early)
>  {
>  	struct uniphier_gpio_priv *priv = domain->host_data;
>  	struct gpio_chip *chip = &priv->chip;
>  
>  	gpiochip_lock_as_irq(chip, data->hwirq + UNIPHIER_GPIO_IRQ_OFFSET);
> +	return 0;
>  }
>  
>  static void uniphier_gpio_irq_domain_deactivate(struct irq_domain *domain,

Just a reminder that this conflict still exists.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2017-11-03  8:13   ` Stephen Rothwell
@ 2017-11-03 21:40     ` Linus Walleij
  0 siblings, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2017-11-03 21:40 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra,
	Linux-Next Mailing List, Linux Kernel Mailing List,
	Masahiro Yamada

On Fri, Nov 3, 2017 at 9:13 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Linus,
>
> On Fri, 3 Nov 2017 08:50:31 +0100 Linus Walleij <linus.walleij@linaro.org> wrote:
>>
>> I applied this patch to the GPIO tree, I guess it is the right thing
>> to do at this point.
>
> Umm, you can't really validly apply my merge fix patch to the gpio tree
> without merging in part of the tip tree (it will generate, at least,
> warnings in your build testing of your tree) ...

OK I take it out again...

>> I suspect the IRQ infrastructure will be pulled to Torvald's tree
>> first anyway.
>
> You just need to let Linus know that this update is require (maybe
> provide him with my merge fix patch) when you send your pull request.

OK I will try to do that.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2017-11-03  7:50 ` Linus Walleij
@ 2017-11-03  8:13   ` Stephen Rothwell
  2017-11-03 21:40     ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2017-11-03  8:13 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra,
	Linux-Next Mailing List, Linux Kernel Mailing List,
	Masahiro Yamada

Hi Linus,

On Fri, 3 Nov 2017 08:50:31 +0100 Linus Walleij <linus.walleij@linaro.org> wrote:
>
> I applied this patch to the GPIO tree, I guess it is the right thing
> to do at this point.

Umm, you can't really validly apply my merge fix patch to the gpio tree
without merging in part of the tip tree (it will generate, at least,
warnings in your build testing of your tree) ...

> I suspect the IRQ infrastructure will be pulled to Torvald's tree
> first anyway.

You just need to let Linus know that this update is require (maybe
provide him with my merge fix patch) when you send your pull request.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2017-11-02  5:20 Stephen Rothwell
  2017-11-02  5:33 ` Masahiro Yamada
@ 2017-11-03  7:50 ` Linus Walleij
  2017-11-03  8:13   ` Stephen Rothwell
  2017-11-13 11:33 ` Stephen Rothwell
  2 siblings, 1 reply; 103+ messages in thread
From: Linus Walleij @ 2017-11-03  7:50 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra,
	Linux-Next Mailing List, Linux Kernel Mailing List,
	Masahiro Yamada

On Thu, Nov 2, 2017 at 6:20 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Linus,
>
> After merging the gpio tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/gpio/gpio-uniphier.c:324:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .activate = uniphier_gpio_irq_domain_activate,
>               ^
>
> Caused by commit
>
>   dbe776c2ca54 ("gpio: uniphier: add UniPhier GPIO controller driver")
>
> interacting with commit
>
>   72491643469a ("genirq/irqdomain: Update irq_domain_ops.activate() signature")
>
> from the tip tree
>
> I added the following merge fix patch:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 2 Nov 2017 16:10:46 +1100
> Subject: [PATCH] gpio: uniphier: merge fix for "Update
>  irq_domain_ops.activate() signature"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

I applied this patch to the GPIO tree, I guess it is the right thing
to do at this point.

I suspect the IRQ infrastructure will be pulled to Torvald's tree
first anyway.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2017-11-02  5:20 Stephen Rothwell
@ 2017-11-02  5:33 ` Masahiro Yamada
  2017-11-03  7:50 ` Linus Walleij
  2017-11-13 11:33 ` Stephen Rothwell
  2 siblings, 0 replies; 103+ messages in thread
From: Masahiro Yamada @ 2017-11-02  5:33 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus Walleij, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
	Peter Zijlstra, Linux-Next Mailing List,
	Linux Kernel Mailing List

Hi Stephen,


2017-11-02 14:20 GMT+09:00 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi Linus,
>
> After merging the gpio tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/gpio/gpio-uniphier.c:324:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .activate = uniphier_gpio_irq_domain_activate,
>               ^
>
> Caused by commit
>
>   dbe776c2ca54 ("gpio: uniphier: add UniPhier GPIO controller driver")
>
> interacting with commit
>
>   72491643469a ("genirq/irqdomain: Update irq_domain_ops.activate() signature")
>
> from the tip tree
>
> I added the following merge fix patch:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 2 Nov 2017 16:10:46 +1100
> Subject: [PATCH] gpio: uniphier: merge fix for "Update
>  irq_domain_ops.activate() signature"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/gpio/gpio-uniphier.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-uniphier.c b/drivers/gpio/gpio-uniphier.c
> index d62cea4ed6b7..d0069202ade3 100644
> --- a/drivers/gpio/gpio-uniphier.c
> +++ b/drivers/gpio/gpio-uniphier.c
> @@ -300,13 +300,15 @@ static int uniphier_gpio_irq_domain_alloc(struct irq_domain *domain,
>         return irq_domain_alloc_irqs_parent(domain, virq, 1, &parent_fwspec);
>  }
>
> -static void uniphier_gpio_irq_domain_activate(struct irq_domain *domain,
> -                                             struct irq_data *data)
> +static int uniphier_gpio_irq_domain_activate(struct irq_domain *domain,
> +                                             struct irq_data *data,
> +                                             bool early)


Thanks for fixing this!

Basically it it OK, but you do not need to wrap the line.


I prefer the following style since the second line fit in 79 cols.

static int uniphier_gpio_irq_domain_activate(struct irq_domain *domain,
                                             struct irq_data *data, bool early)






>         struct uniphier_gpio_priv *priv = domain->host_data;
>         struct gpio_chip *chip = &priv->chip;
>
>         gpiochip_lock_as_irq(chip, data->hwirq + UNIPHIER_GPIO_IRQ_OFFSET);
> +       return 0;
>  }
>
>  static void uniphier_gpio_irq_domain_deactivate(struct irq_domain *domain,
> --
> 2.14.1
>
> --
> Cheers,
> Stephen Rothwell



-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2017-11-02  5:20 Stephen Rothwell
  2017-11-02  5:33 ` Masahiro Yamada
                   ` (2 more replies)
  0 siblings, 3 replies; 103+ messages in thread
From: Stephen Rothwell @ 2017-11-02  5:20 UTC (permalink / raw)
  To: Linus Walleij, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
	Peter Zijlstra
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Masahiro Yamada

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpio/gpio-uniphier.c:324:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .activate = uniphier_gpio_irq_domain_activate,
              ^

Caused by commit

  dbe776c2ca54 ("gpio: uniphier: add UniPhier GPIO controller driver")

interacting with commit

  72491643469a ("genirq/irqdomain: Update irq_domain_ops.activate() signature")

from the tip tree

I added the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 2 Nov 2017 16:10:46 +1100
Subject: [PATCH] gpio: uniphier: merge fix for "Update
 irq_domain_ops.activate() signature"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpio/gpio-uniphier.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-uniphier.c b/drivers/gpio/gpio-uniphier.c
index d62cea4ed6b7..d0069202ade3 100644
--- a/drivers/gpio/gpio-uniphier.c
+++ b/drivers/gpio/gpio-uniphier.c
@@ -300,13 +300,15 @@ static int uniphier_gpio_irq_domain_alloc(struct irq_domain *domain,
 	return irq_domain_alloc_irqs_parent(domain, virq, 1, &parent_fwspec);
 }
 
-static void uniphier_gpio_irq_domain_activate(struct irq_domain *domain,
-					      struct irq_data *data)
+static int uniphier_gpio_irq_domain_activate(struct irq_domain *domain,
+					      struct irq_data *data,
+					      bool early)
 {
 	struct uniphier_gpio_priv *priv = domain->host_data;
 	struct gpio_chip *chip = &priv->chip;
 
 	gpiochip_lock_as_irq(chip, data->hwirq + UNIPHIER_GPIO_IRQ_OFFSET);
+	return 0;
 }
 
 static void uniphier_gpio_irq_domain_deactivate(struct irq_domain *domain,
-- 
2.14.1

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2017-06-21  6:09 Stephen Rothwell
  2017-06-21  6:12 ` Jisheng Zhang
@ 2017-06-21  7:41 ` Linus Walleij
  1 sibling, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2017-06-21  7:41 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Xiaoguang Chen, Jisheng Zhang

On Wed, Jun 21, 2017 at 8:09 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> It looks like those '(' ')' chars are not what they seem ...

No the owls are not what they seem. I went in and fixed the
unicode weirdness, thanks!

Pretty hard to see this one since I can't see it.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2017-06-21  6:09 Stephen Rothwell
@ 2017-06-21  6:12 ` Jisheng Zhang
  2017-06-21  7:41 ` Linus Walleij
  1 sibling, 0 replies; 103+ messages in thread
From: Jisheng Zhang @ 2017-06-21  6:12 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus Walleij, Linux-Next Mailing List,
	Linux Kernel Mailing List, Xiaoguang Chen

On Wed, 21 Jun 2017 16:09:34 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Linus,
> 
> After merging the gpio tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/gpio/gpio-dwapb.c: In function 'dwapb_irq_set_type':
> drivers/gpio/gpio-dwapb.c:291:2: error: stray '\357' in program
>   if (type != IRQ_TYPE_EDGE_BOTH)
>   ^
> drivers/gpio/gpio-dwapb.c:291:2: error: stray '\274' in program
> drivers/gpio/gpio-dwapb.c:291:2: error: stray '\210' in program
> drivers/gpio/gpio-dwapb.c:291:8: error: expected '(' before 'type'
>   if (type != IRQ_TYPE_EDGE_BOTH)
>         ^
> drivers/gpio/gpio-dwapb.c:291:8: warning: statement with no effect [-Wunused-value]
> drivers/gpio/gpio-dwapb.c:291:8: error: stray '\357' in program
> drivers/gpio/gpio-dwapb.c:291:8: error: stray '\274' in program
> drivers/gpio/gpio-dwapb.c:291:8: error: stray '\211' in program

oops, I see this error as well, Xiaoguang uses Chinese "()" instead of
ASII "()", I fixed it locally but I forget to mention it.

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2017-06-21  6:09 Stephen Rothwell
  2017-06-21  6:12 ` Jisheng Zhang
  2017-06-21  7:41 ` Linus Walleij
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2017-06-21  6:09 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Xiaoguang Chen, Jisheng Zhang

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpio/gpio-dwapb.c: In function 'dwapb_irq_set_type':
drivers/gpio/gpio-dwapb.c:291:2: error: stray '\357' in program
  if (type != IRQ_TYPE_EDGE_BOTH)
  ^
drivers/gpio/gpio-dwapb.c:291:2: error: stray '\274' in program
drivers/gpio/gpio-dwapb.c:291:2: error: stray '\210' in program
drivers/gpio/gpio-dwapb.c:291:8: error: expected '(' before 'type'
  if (type != IRQ_TYPE_EDGE_BOTH)
        ^
drivers/gpio/gpio-dwapb.c:291:8: warning: statement with no effect [-Wunused-value]
drivers/gpio/gpio-dwapb.c:291:8: error: stray '\357' in program
drivers/gpio/gpio-dwapb.c:291:8: error: stray '\274' in program
drivers/gpio/gpio-dwapb.c:291:8: error: stray '\211' in program

Caused by commit

  a9d21d8da766 ("gpio: dwapb: fix missing first irq for edgeboth irq type")

It looks like those '(' ')' chars are not what they seem ...

I have used the gpio tree from next-20170620 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2017-05-29  5:39 Stephen Rothwell
@ 2017-05-29  8:11 ` Linus Walleij
  0 siblings, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2017-05-29  8:11 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Thomas Petazzoni, Gregory CLEMENT

On Mon, May 29, 2017 at 7:39 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the gpio tree, today's linux-next build (arm
> orion5x_defconfig) failed like this:
>
> drivers/gpio/gpio-mvebu.c:1062: undefined reference to `__devm_regmap_init_mmio_clk'
> drivers/gpio/gpio-mvebu.c:1078: undefined reference to `__devm_regmap_init_mmio_clk'
>
> Caused by commit
>
>   2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access")
>
> Presumably a missing Kconfig dependency.  Yeah, CONFIG_REGMAP_MMIO is
> not set for this build.

Yup Gregory sent a patch for this, I applied it, will be there tomorrow.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2017-05-29  5:39 Stephen Rothwell
  2017-05-29  8:11 ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2017-05-29  5:39 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Thomas Petazzoni, Gregory CLEMENT

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
orion5x_defconfig) failed like this:

drivers/gpio/gpio-mvebu.c:1062: undefined reference to `__devm_regmap_init_mmio_clk'
drivers/gpio/gpio-mvebu.c:1078: undefined reference to `__devm_regmap_init_mmio_clk'

Caused by commit

  2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access")

Presumably a missing Kconfig dependency.  Yeah, CONFIG_REGMAP_MMIO is
not set for this build.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2017-02-08  5:11 Stephen Rothwell
  2017-02-08  8:48 ` Lee Jones
@ 2017-02-13 15:18 ` Linus Walleij
  1 sibling, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2017-02-13 15:18 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Greg KH, linux-next, linux-kernel, Lee Jones, Boris Brezillon,
	Alexander Stein, Andy Shevchenko

On Wed, Feb 8, 2017 at 6:11 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Linus,
>
> After merging the gpio tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/tty/serial/st-asc.c: In function 'asc_set_termios':
> drivers/tty/serial/st-asc.c:578:12: error: implicit declaration of function 'devm_get_gpiod_from_child' [-Werror=implicit-function-declaration]
>     gpiod = devm_get_gpiod_from_child(port->dev, "rts",
>             ^
> drivers/tty/serial/st-asc.c:578:10: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>     gpiod = devm_get_gpiod_from_child(port->dev, "rts",
>           ^
>
> Caused by commits
>
>   a264d10ff45c ("gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO")
>   b2987d7438e0 ("gpio: Pass GPIO label down to gpiod_request")
>   4b0947974e59 ("gpio: Rename devm_get_gpiod_from_child()")
>
> interacting with commit
>
>   d7356256488c ("serial: st-asc: (De)Register GPIOD and swap Pinctrl profiles")
>
> from the tty tree.

Ah what a bummer, a new user colliding with the treewide changes of these
prototypes.

> I applied the following merge fix patch (I guessed about the new arguments):

Looks correct. Well not much to do about it apart from mentioning the
problem to Linus (the big penguin) when merging the trees.

Thanks for your efforts!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2017-02-08  8:48 ` Lee Jones
  2017-02-08  9:05   ` Boris Brezillon
@ 2017-02-08 10:30   ` Stephen Rothwell
  1 sibling, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2017-02-08 10:30 UTC (permalink / raw)
  To: Lee Jones
  Cc: Linus Walleij, Greg KH, linux-next, linux-kernel,
	Boris Brezillon, Alexander Stein, Andy Shevchenko

Hi Lee,

On Wed, 8 Feb 2017 08:48:54 +0000 Lee Jones <lee.jones@linaro.org> wrote:
>
> On Wed, 08 Feb 2017, Stephen Rothwell wrote:
> 
> > Hi Linus,  
> 
> I believe this patch would need to go in via Greg's tree.

Except his tree does not have the rename and extra arguments for
devm_get_gpiod_from_child(), so it can't unless he merges (part of) the
gpio tree as well ...

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2017-02-08  8:48 ` Lee Jones
@ 2017-02-08  9:05   ` Boris Brezillon
  2017-02-08 10:30   ` Stephen Rothwell
  1 sibling, 0 replies; 103+ messages in thread
From: Boris Brezillon @ 2017-02-08  9:05 UTC (permalink / raw)
  To: Lee Jones
  Cc: Stephen Rothwell, Linus Walleij, Greg KH, linux-next,
	linux-kernel, Alexander Stein, Andy Shevchenko

On Wed, 8 Feb 2017 08:48:54 +0000
Lee Jones <lee.jones@linaro.org> wrote:

> On Wed, 08 Feb 2017, Stephen Rothwell wrote:
> 
> > Hi Linus,  
> 
> I believe this patch would need to go in via Greg's tree.
> 
> (see below)
> 
> > After merging the gpio tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> > 
> > drivers/tty/serial/st-asc.c: In function 'asc_set_termios':
> > drivers/tty/serial/st-asc.c:578:12: error: implicit declaration of function 'devm_get_gpiod_from_child' [-Werror=implicit-function-declaration]
> >     gpiod = devm_get_gpiod_from_child(port->dev, "rts",
> >             ^
> > drivers/tty/serial/st-asc.c:578:10: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> >     gpiod = devm_get_gpiod_from_child(port->dev, "rts",
> >           ^
> > 
> > Caused by commits
> > 
> >   a264d10ff45c ("gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO")
> >   b2987d7438e0 ("gpio: Pass GPIO label down to gpiod_request")
> >   4b0947974e59 ("gpio: Rename devm_get_gpiod_from_child()")
> > 
> > interacting with commit
> > 
> >   d7356256488c ("serial: st-asc: (De)Register GPIOD and swap Pinctrl profiles")
> > 
> > from the tty tree.
> > 
> > I applied the following merge fix patch (I guessed about the new arguments):
> > 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Wed, 8 Feb 2017 15:50:22 +1100
> > Subject: [PATCH] serial: st-asc: merge fix for devm_get_gpiod_from_child rename
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  drivers/tty/serial/st-asc.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> > index bcf1d33e6ffe..c02e6b089364 100644
> > --- a/drivers/tty/serial/st-asc.c
> > +++ b/drivers/tty/serial/st-asc.c
> > @@ -575,8 +575,11 @@ static void asc_set_termios(struct uart_port *port, struct ktermios *termios,
> >  			pinctrl_select_state(ascport->pinctrl,
> >  					     ascport->states[NO_HW_FLOWCTRL]);
> >  
> > -			gpiod =	devm_get_gpiod_from_child(port->dev, "rts",
> > -							  &np->fwnode);
> > +			gpiod =	devm_fwnode_get_gpiod_from_child(port->dev,
> > +								 "rts",
> > +								 &np->fwnode,
> > +								 GPIOD_IN,  
> 
> GPIOD_OUT

I think it should be GPIOD_OUT_LOW ...

> 
> > +								 np->name);
> >  			if (!IS_ERR(gpiod)) {
> >  				gpiod_direction_output(gpiod, 0);

... and you should drop this call to gpiod_direction_output().

> >  				ascport->rts = gpiod;  
> 

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2017-02-08  5:11 Stephen Rothwell
@ 2017-02-08  8:48 ` Lee Jones
  2017-02-08  9:05   ` Boris Brezillon
  2017-02-08 10:30   ` Stephen Rothwell
  2017-02-13 15:18 ` Linus Walleij
  1 sibling, 2 replies; 103+ messages in thread
From: Lee Jones @ 2017-02-08  8:48 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus Walleij, Greg KH, linux-next, linux-kernel,
	Boris Brezillon, Alexander Stein, Andy Shevchenko

On Wed, 08 Feb 2017, Stephen Rothwell wrote:

> Hi Linus,

I believe this patch would need to go in via Greg's tree.

(see below)

> After merging the gpio tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/tty/serial/st-asc.c: In function 'asc_set_termios':
> drivers/tty/serial/st-asc.c:578:12: error: implicit declaration of function 'devm_get_gpiod_from_child' [-Werror=implicit-function-declaration]
>     gpiod = devm_get_gpiod_from_child(port->dev, "rts",
>             ^
> drivers/tty/serial/st-asc.c:578:10: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>     gpiod = devm_get_gpiod_from_child(port->dev, "rts",
>           ^
> 
> Caused by commits
> 
>   a264d10ff45c ("gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO")
>   b2987d7438e0 ("gpio: Pass GPIO label down to gpiod_request")
>   4b0947974e59 ("gpio: Rename devm_get_gpiod_from_child()")
> 
> interacting with commit
> 
>   d7356256488c ("serial: st-asc: (De)Register GPIOD and swap Pinctrl profiles")
> 
> from the tty tree.
> 
> I applied the following merge fix patch (I guessed about the new arguments):
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 8 Feb 2017 15:50:22 +1100
> Subject: [PATCH] serial: st-asc: merge fix for devm_get_gpiod_from_child rename
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/tty/serial/st-asc.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index bcf1d33e6ffe..c02e6b089364 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -575,8 +575,11 @@ static void asc_set_termios(struct uart_port *port, struct ktermios *termios,
>  			pinctrl_select_state(ascport->pinctrl,
>  					     ascport->states[NO_HW_FLOWCTRL]);
>  
> -			gpiod =	devm_get_gpiod_from_child(port->dev, "rts",
> -							  &np->fwnode);
> +			gpiod =	devm_fwnode_get_gpiod_from_child(port->dev,
> +								 "rts",
> +								 &np->fwnode,
> +								 GPIOD_IN,

GPIOD_OUT

> +								 np->name);
>  			if (!IS_ERR(gpiod)) {
>  				gpiod_direction_output(gpiod, 0);
>  				ascport->rts = gpiod;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2017-02-08  5:11 Stephen Rothwell
  2017-02-08  8:48 ` Lee Jones
  2017-02-13 15:18 ` Linus Walleij
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2017-02-08  5:11 UTC (permalink / raw)
  To: Linus Walleij, Greg KH
  Cc: linux-next, linux-kernel, Lee Jones, Boris Brezillon,
	Alexander Stein, Andy Shevchenko

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/tty/serial/st-asc.c: In function 'asc_set_termios':
drivers/tty/serial/st-asc.c:578:12: error: implicit declaration of function 'devm_get_gpiod_from_child' [-Werror=implicit-function-declaration]
    gpiod = devm_get_gpiod_from_child(port->dev, "rts",
            ^
drivers/tty/serial/st-asc.c:578:10: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
    gpiod = devm_get_gpiod_from_child(port->dev, "rts",
          ^

Caused by commits

  a264d10ff45c ("gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO")
  b2987d7438e0 ("gpio: Pass GPIO label down to gpiod_request")
  4b0947974e59 ("gpio: Rename devm_get_gpiod_from_child()")

interacting with commit

  d7356256488c ("serial: st-asc: (De)Register GPIOD and swap Pinctrl profiles")

from the tty tree.

I applied the following merge fix patch (I guessed about the new arguments):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 8 Feb 2017 15:50:22 +1100
Subject: [PATCH] serial: st-asc: merge fix for devm_get_gpiod_from_child rename

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/tty/serial/st-asc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index bcf1d33e6ffe..c02e6b089364 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -575,8 +575,11 @@ static void asc_set_termios(struct uart_port *port, struct ktermios *termios,
 			pinctrl_select_state(ascport->pinctrl,
 					     ascport->states[NO_HW_FLOWCTRL]);
 
-			gpiod =	devm_get_gpiod_from_child(port->dev, "rts",
-							  &np->fwnode);
+			gpiod =	devm_fwnode_get_gpiod_from_child(port->dev,
+								 "rts",
+								 &np->fwnode,
+								 GPIOD_IN,
+								 np->name);
 			if (!IS_ERR(gpiod)) {
 				gpiod_direction_output(gpiod, 0);
 				ascport->rts = gpiod;
-- 
2.10.2

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2016-09-09  4:36 Stephen Rothwell
@ 2016-09-12 13:27 ` Linus Walleij
  0 siblings, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2016-09-12 13:27 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Marc Zyngier

On Fri, Sep 9, 2016 at 6:36 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the gpio tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/gpio/gpiolib.c: In function '_gpiochip_irqchip_add':
> drivers/gpio/gpiolib.c:1622:62: error: macro "WARN_ON" passed 3 arguments, but takes just 1
>        "%s: Ignoring %d default trigger\n", of_node->full_name))
>                                                               ^
> drivers/gpio/gpiolib.c:1621:6: error: 'WARN_ON' undeclared (first use in this function)
>   if (WARN_ON(of_node && type != IRQ_TYPE_NONE,
>       ^
>
> Caused by commit
>
>   1ded8b1dafe6 ("gpio/gpiolib: Forbid irqchip default trigger if probed over DT")
>
> I used the version of the gpio tree from next-20160908 for today.

Sorry about this, fixed it up.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2016-09-09  4:36 Stephen Rothwell
  2016-09-12 13:27 ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2016-09-09  4:36 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Marc Zyngier

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpio/gpiolib.c: In function '_gpiochip_irqchip_add':
drivers/gpio/gpiolib.c:1622:62: error: macro "WARN_ON" passed 3 arguments, but takes just 1
       "%s: Ignoring %d default trigger\n", of_node->full_name))
                                                              ^
drivers/gpio/gpiolib.c:1621:6: error: 'WARN_ON' undeclared (first use in this function)
  if (WARN_ON(of_node && type != IRQ_TYPE_NONE,
      ^

Caused by commit

  1ded8b1dafe6 ("gpio/gpiolib: Forbid irqchip default trigger if probed over DT")

I used the version of the gpio tree from next-20160908 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2016-04-18  4:10 Stephen Rothwell
  0 siblings, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2016-04-18  4:10 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-f7188x.c: In function 'f7188x_gpio_set_single_ended':
drivers/gpio/gpio-f7188x.c:331:26: error: implicit declaration of function 'gpio_data_mode' [-Werror=implicit-function-declaration]
  superio_outb(sio->addr, gpio_data_mode(bank->regbase), data);
                          ^

Caused by commit

  f90c6bdb690b ("gpio: f7188x: use the new open drain callback")

I have used the gpio tree from next-20160415 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2016-03-31  2:22 Stephen Rothwell
@ 2016-03-31  7:52 ` Linus Walleij
  0 siblings, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2016-03-31  7:52 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

On Thu, Mar 31, 2016 at 4:22 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the gpio tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
>
> arch/powerpc/sysdev/ppc4xx_gpio.c: In function 'ppc4xx_gpio_set':
> arch/powerpc/sysdev/ppc4xx_gpio.c:93:26: error: unused variable 'mm_gc' [-Werror=unused-variable]
>   struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
>                           ^
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   0d36fe65f583 ("powerpc: ppc4xx: use gpiochip data pointer")
>
> I applied this patch for today:

Thanks Stephen, I indicentally merged an identical patch after
late results from the autobuilder.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2016-03-31  2:22 Stephen Rothwell
  2016-03-31  7:52 ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2016-03-31  2:22 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel

Hi Linus,

After merging the gpio tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

arch/powerpc/sysdev/ppc4xx_gpio.c: In function 'ppc4xx_gpio_set':
arch/powerpc/sysdev/ppc4xx_gpio.c:93:26: error: unused variable 'mm_gc' [-Werror=unused-variable]
  struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
                          ^
cc1: all warnings being treated as errors

Caused by commit

  0d36fe65f583 ("powerpc: ppc4xx: use gpiochip data pointer")

I applied this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 31 Mar 2016 13:18:45 +1100
Subject: [PATCH] powerpc: ppc4xx: remove unused local variable

Fixes: 0d36fe65f583 ("powerpc: ppc4xx: use gpiochip data pointer")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/sysdev/ppc4xx_gpio.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/sysdev/ppc4xx_gpio.c b/arch/powerpc/sysdev/ppc4xx_gpio.c
index 4ab83cd04785..5382d04dd872 100644
--- a/arch/powerpc/sysdev/ppc4xx_gpio.c
+++ b/arch/powerpc/sysdev/ppc4xx_gpio.c
@@ -90,7 +90,6 @@ __ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
 static void
 ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
 {
-	struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
 	struct ppc4xx_gpio_chip *chip = gpiochip_get_data(gc);
 	unsigned long flags;
 
-- 
2.7.0

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2016-02-16  3:48 Stephen Rothwell
@ 2016-02-16 14:47 ` Linus Walleij
  0 siblings, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2016-02-16 14:47 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Nicolas Saenz Julienne

On Tue, Feb 16, 2016 at 4:48 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Linus,
>
> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpio/gpio-tps65218.c: In function 'tps65218_gpio_request':
> drivers/gpio/gpio-tps65218.c:74:26: error: 'struct gpio_chip' has no member named 'desc'
>   unsigned long flags = gc->desc[offset].flags;
>                           ^
>
> Caused by commit
>
>   c366c76a2c41 ("gpio: add tps65218 gpio")
>
> interacting with commit
>
>   1c3cdb186172 ("gpio: move descriptors into gpio_device")
>
> both from the gpio tree.

What a mess. I just sent a fixup patch. I blame my ability
to manage several things at the same time.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2016-02-16  3:48 Stephen Rothwell
  2016-02-16 14:47 ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2016-02-16  3:48 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Nicolas Saenz Julienne

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-tps65218.c: In function 'tps65218_gpio_request':
drivers/gpio/gpio-tps65218.c:74:26: error: 'struct gpio_chip' has no member named 'desc'
  unsigned long flags = gc->desc[offset].flags;
                          ^

Caused by commit

  c366c76a2c41 ("gpio: add tps65218 gpio")

interacting with commit

  1c3cdb186172 ("gpio: move descriptors into gpio_device")

both from the gpio tree.

I have used the gpio tree from next-20160215 fro today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2016-02-04  2:16 ` Stephen Rothwell
@ 2016-02-08 17:36   ` Linus Walleij
  0 siblings, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2016-02-08 17:36 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Liu Gang

On Thu, Feb 4, 2016 at 3:16 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Linus,

>> I have used the gpio tree from next-20160128 for today.
>
> I am still getting this error.

Sorry for slow attendance :(

Fixed it now, I hope.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2016-01-29  1:45 Stephen Rothwell
@ 2016-02-04  2:16 ` Stephen Rothwell
  2016-02-08 17:36   ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2016-02-04  2:16 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Liu Gang

Hi Linus,

On Fri, 29 Jan 2016 12:45:57 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_save_regs':
> drivers/gpio/gpio-mpc8xxx.c:57:21: error: implicit declaration of function 'in_be32' [-Werror=implicit-function-declaration]
>   mpc8xxx_gc->data = in_be32(mm->regs + GPIO_DAT);
>                      ^
> drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_set':
> drivers/gpio/gpio-mpc8xxx.c:100:2: error: implicit declaration of function 'out_be32' [-Werror=implicit-function-declaration]
>   out_be32(mm->regs + GPIO_DAT, mpc8xxx_gc->data);
>   ^
> drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_dir_in':
> drivers/gpio/gpio-mpc8xxx.c:139:2: error: implicit declaration of function 'clrbits32' [-Werror=implicit-function-declaration]
>   clrbits32(mm->regs + GPIO_DIR, mpc8xxx_gpio2mask(gpio));
>   ^
> drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_dir_out':
> drivers/gpio/gpio-mpc8xxx.c:156:2: error: implicit declaration of function 'setbits32' [-Werror=implicit-function-declaration]
>   setbits32(mm->regs + GPIO_DIR, mpc8xxx_gpio2mask(gpio));
>   ^
> drivers/gpio/gpio-mpc8xxx.c: In function 'mpc512x_irq_set_type':
> drivers/gpio/gpio-mpc8xxx.c:289:3: error: implicit declaration of function 'clrsetbits_be32' [-Werror=implicit-function-declaration]
>    clrsetbits_be32(reg, 3 << shift, 2 << shift);
>    ^
> drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_probe':
> drivers/gpio/gpio-mpc8xxx.c:419:26: error: 'NO_IRQ' undeclared (first use in this function)
>   if (mpc8xxx_gc->irqn == NO_IRQ)   
>                           ^
> drivers/gpio/gpio-mpc8xxx.c:419:26: note: each undeclared identifier is reported only once for each function it appears in
> 
> Exposed by commit
> 
>   5df7fd46b70b ("pio/qoriq: Add qoriq platforms support")
> 
> The COMPILE_TEST dependency has revealed several implicit includes ...
> 
> I have used the gpio tree from next-20160128 for today.

I am still getting this error.
-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2016-01-29  1:45 Stephen Rothwell
  2016-02-04  2:16 ` Stephen Rothwell
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2016-01-29  1:45 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Liu Gang

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_save_regs':
drivers/gpio/gpio-mpc8xxx.c:57:21: error: implicit declaration of function 'in_be32' [-Werror=implicit-function-declaration]
  mpc8xxx_gc->data = in_be32(mm->regs + GPIO_DAT);
                     ^
drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_set':
drivers/gpio/gpio-mpc8xxx.c:100:2: error: implicit declaration of function 'out_be32' [-Werror=implicit-function-declaration]
  out_be32(mm->regs + GPIO_DAT, mpc8xxx_gc->data);
  ^
drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_dir_in':
drivers/gpio/gpio-mpc8xxx.c:139:2: error: implicit declaration of function 'clrbits32' [-Werror=implicit-function-declaration]
  clrbits32(mm->regs + GPIO_DIR, mpc8xxx_gpio2mask(gpio));
  ^
drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_dir_out':
drivers/gpio/gpio-mpc8xxx.c:156:2: error: implicit declaration of function 'setbits32' [-Werror=implicit-function-declaration]
  setbits32(mm->regs + GPIO_DIR, mpc8xxx_gpio2mask(gpio));
  ^
drivers/gpio/gpio-mpc8xxx.c: In function 'mpc512x_irq_set_type':
drivers/gpio/gpio-mpc8xxx.c:289:3: error: implicit declaration of function 'clrsetbits_be32' [-Werror=implicit-function-declaration]
   clrsetbits_be32(reg, 3 << shift, 2 << shift);
   ^
drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_probe':
drivers/gpio/gpio-mpc8xxx.c:419:26: error: 'NO_IRQ' undeclared (first use in this function)
  if (mpc8xxx_gc->irqn == NO_IRQ)   
                          ^
drivers/gpio/gpio-mpc8xxx.c:419:26: note: each undeclared identifier is reported only once for each function it appears in

Exposed by commit

  5df7fd46b70b ("pio/qoriq: Add qoriq platforms support")

The COMPILE_TEST dependency has revealed several implicit includes ...

I have used the gpio tree from next-20160128 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-12-22 23:58       ` Linus Walleij
@ 2015-12-23  0:20         ` Stephen Rothwell
  0 siblings, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2015-12-23  0:20 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Robert Jarzmik, linux-next, linux-kernel

Hi Linus,

On Wed, 23 Dec 2015 00:58:34 +0100 Linus Walleij <linus.walleij@linaro.org> wrote:
>
> Pushed now, I was waiting for the autobuilders to munch it first.
> Sorry for the delay :(

No worries, I have refetched it.

BTW, its good that the autobuilders have had a go at it :-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-12-22 20:10     ` Stephen Rothwell
@ 2015-12-22 23:58       ` Linus Walleij
  2015-12-23  0:20         ` Stephen Rothwell
  0 siblings, 1 reply; 103+ messages in thread
From: Linus Walleij @ 2015-12-22 23:58 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Robert Jarzmik, linux-next, linux-kernel

On Tue, Dec 22, 2015 at 9:10 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Tue, 22 Dec 2015 10:08:58 +0100 Linus Walleij <linus.walleij@linaro.org> wrote:
>>
>> On Tue, Dec 22, 2015 at 7:57 AM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>> > Stephen Rothwell <sfr@canb.auug.org.au> writes:
>> >
>> >> After merging the gpio tree, today's linux-next build (lots without
>> >> CONFIG_OF) failed like this:
>> >>
>> >> drivers/gpio/gpio-pxa.c: In function 'pxa_gpio_probe':
>> >> drivers/gpio/gpio-pxa.c:648:12: error: 'pxa_irq_domain_ops' undeclared (first use in this function)
>> >>
>> >> Caused by commit
>> >>
>> >>   384ca3c6a28d ("gpio: pxa: change the interrupt management")
>> >>
>> >> The reference to pxa_irq_domain_ops was moved out of the protection of
>> >> CONFIG_OF ...
>> >>
>> >> Discovered after the release.
>> >
>> > Hi Stephen,
>> >
>> > The fix has been sent in http://www.spinics.net/lists/kernel/msg2147774.html but
>> > did not reach Linus's next tree yet probably.
>>
>> Sorry, I'll pick it now-ish...
>
> Not in the published gpio tree, yet?

Pushed now, I was waiting for the autobuilders to munch it first.
Sorry for the delay :(

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-12-22  9:08   ` Linus Walleij
@ 2015-12-22 20:10     ` Stephen Rothwell
  2015-12-22 23:58       ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2015-12-22 20:10 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Robert Jarzmik, linux-next, linux-kernel

Hi Linus,

On Tue, 22 Dec 2015 10:08:58 +0100 Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Dec 22, 2015 at 7:57 AM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> > Stephen Rothwell <sfr@canb.auug.org.au> writes:
> >  
> >> After merging the gpio tree, today's linux-next build (lots without
> >> CONFIG_OF) failed like this:
> >>
> >> drivers/gpio/gpio-pxa.c: In function 'pxa_gpio_probe':
> >> drivers/gpio/gpio-pxa.c:648:12: error: 'pxa_irq_domain_ops' undeclared (first use in this function)
> >>
> >> Caused by commit
> >>
> >>   384ca3c6a28d ("gpio: pxa: change the interrupt management")
> >>
> >> The reference to pxa_irq_domain_ops was moved out of the protection of
> >> CONFIG_OF ...
> >>
> >> Discovered after the release.  
> >
> > Hi Stephen,
> >
> > The fix has been sent in http://www.spinics.net/lists/kernel/msg2147774.html but
> > did not reach Linus's next tree yet probably.  
> 
> Sorry, I'll pick it now-ish...

Not in the published gpio tree, yet?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-12-22  6:57 ` Robert Jarzmik
@ 2015-12-22  9:08   ` Linus Walleij
  2015-12-22 20:10     ` Stephen Rothwell
  0 siblings, 1 reply; 103+ messages in thread
From: Linus Walleij @ 2015-12-22  9:08 UTC (permalink / raw)
  To: Robert Jarzmik; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Tue, Dec 22, 2015 at 7:57 AM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> Stephen Rothwell <sfr@canb.auug.org.au> writes:
>
>> Hi Linus,
>>
>> After merging the gpio tree, today's linux-next build (lots without
>> CONFIG_OF) failed like this:
>>
>> drivers/gpio/gpio-pxa.c: In function 'pxa_gpio_probe':
>> drivers/gpio/gpio-pxa.c:648:12: error: 'pxa_irq_domain_ops' undeclared (first use in this function)
>>
>> Caused by commit
>>
>>   384ca3c6a28d ("gpio: pxa: change the interrupt management")
>>
>> The reference to pxa_irq_domain_ops was moved out of the protection of
>> CONFIG_OF ...
>>
>> Discovered after the release.
>
> Hi Stephen,
>
> The fix has been sent in http://www.spinics.net/lists/kernel/msg2147774.html but
> did not reach Linus's next tree yet probably.

Sorry, I'll pick it now-ish...

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-12-22  5:42 Stephen Rothwell
@ 2015-12-22  6:57 ` Robert Jarzmik
  2015-12-22  9:08   ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Robert Jarzmik @ 2015-12-22  6:57 UTC (permalink / raw)
  To: Linus Walleij, Stephen Rothwell; +Cc: linux-next, linux-kernel

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Linus,
>
> After merging the gpio tree, today's linux-next build (lots without
> CONFIG_OF) failed like this:
>
> drivers/gpio/gpio-pxa.c: In function 'pxa_gpio_probe':
> drivers/gpio/gpio-pxa.c:648:12: error: 'pxa_irq_domain_ops' undeclared (first use in this function)
>
> Caused by commit
>
>   384ca3c6a28d ("gpio: pxa: change the interrupt management")
>
> The reference to pxa_irq_domain_ops was moved out of the protection of
> CONFIG_OF ...
>
> Discovered after the release.

Hi Stephen,

The fix has been sent in http://www.spinics.net/lists/kernel/msg2147774.html but
did not reach Linus's next tree yet probably.

Cheers.

-- 
Robert

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2015-12-22  5:42 Stephen Rothwell
  2015-12-22  6:57 ` Robert Jarzmik
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2015-12-22  5:42 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Robert Jarzmik

Hi Linus,

After merging the gpio tree, today's linux-next build (lots without
CONFIG_OF) failed like this:

drivers/gpio/gpio-pxa.c: In function 'pxa_gpio_probe':
drivers/gpio/gpio-pxa.c:648:12: error: 'pxa_irq_domain_ops' undeclared (first use in this function)

Caused by commit

  384ca3c6a28d ("gpio: pxa: change the interrupt management")

The reference to pxa_irq_domain_ops was moved out of the protection of
CONFIG_OF ...

Discovered after the release.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-12-21  5:02 ` Stephen Rothwell
@ 2015-12-21  8:46   ` Linus Walleij
  0 siblings, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2015-12-21  8:46 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Yendapally Reddy Dhananjaya Reddy

On Mon, Dec 21, 2015 at 6:02 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Linus,
>
> On Wed, 16 Dec 2015 14:37:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the gpio tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
>> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
>>     set_irq_flags(irq, IRQF_VALID);
>>     ^
>> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
>>     set_irq_flags(irq, IRQF_VALID);
>>                        ^
>>
>> Caused by commit
>>
>>   8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
>>
>> set_irq_flags was removed before v4.3-rc2 ...
>>
>> I have used the gpio tree from next-20151215 for today.
>
> I am still getting this error.

Yeah I was applying the fix to the pin control tree, never fix stuff late on
fridays... will apply the patch to the GPIO tree as well, I see no better
solution.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-12-16  3:37 Stephen Rothwell
  2015-12-16  3:55 ` Yendapally Reddy Dhananjaya Reddy
@ 2015-12-21  5:02 ` Stephen Rothwell
  2015-12-21  8:46   ` Linus Walleij
  1 sibling, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2015-12-21  5:02 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Yendapally Reddy Dhananjaya Reddy

Hi Linus,

On Wed, 16 Dec 2015 14:37:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the gpio tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
>     set_irq_flags(irq, IRQF_VALID);
>     ^
> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
>     set_irq_flags(irq, IRQF_VALID);
>                        ^
> 
> Caused by commit
> 
>   8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
> 
> set_irq_flags was removed before v4.3-rc2 ...
> 
> I have used the gpio tree from next-20151215 for today.

I am still getting this error.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* RE: linux-next: build failure after merge of the gpio tree
  2015-12-16  3:37 Stephen Rothwell
@ 2015-12-16  3:55 ` Yendapally Reddy Dhananjaya Reddy
  2015-12-21  5:02 ` Stephen Rothwell
  1 sibling, 0 replies; 103+ messages in thread
From: Yendapally Reddy Dhananjaya Reddy @ 2015-12-16  3:55 UTC (permalink / raw)
  To: Stephen Rothwell, Linus Walleij; +Cc: linux-next, linux-kernel

Hi Stephen,

  Sorry. It's my mistake. In the first patch set, I tested it with "irq_clear_status_flags(irq, IRQ_NOREQUEST);" and in the v2 patch set the old one got in.

Regards
Dhananjay
 
-----Original Message-----
From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] 
Sent: Wednesday, December 16, 2015 9:08 AM
To: Linus Walleij
Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Yendapally Reddy Dhananjaya Reddy
Subject: linux-next: build failure after merge of the gpio tree

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
    set_irq_flags(irq, IRQF_VALID);
    ^
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
    set_irq_flags(irq, IRQF_VALID);
                       ^

Caused by commit

  8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")

set_irq_flags was removed before v4.3-rc2 ...

I have used the gpio tree from next-20151215 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au


^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2015-12-16  3:37 Stephen Rothwell
  2015-12-16  3:55 ` Yendapally Reddy Dhananjaya Reddy
  2015-12-21  5:02 ` Stephen Rothwell
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2015-12-16  3:37 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Yendapally Reddy Dhananjaya Reddy

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
    set_irq_flags(irq, IRQF_VALID);
    ^
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
    set_irq_flags(irq, IRQF_VALID);
                       ^

Caused by commit

  8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")

set_irq_flags was removed before v4.3-rc2 ...

I have used the gpio tree from next-20151215 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2015-12-02 23:38 Mark Brown
  0 siblings, 0 replies; 103+ messages in thread
From: Mark Brown @ 2015-12-02 23:38 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, linux-gpio

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (x86 allmodconfig)
failed like this:

make[1]: Leaving directory '/home/broonie/next/x86_64_allmodconfig'
/home/broonie/next/next/sound/soc/soc-ac97.c: In function 'snd_soc_ac97_init_gpio':
/home/broonie/next/next/sound/soc/soc-ac97.c:145:22: error: 'struct gpio_chip' has no member named 'dev'
  gpio_priv->gpio_chip.dev = codec->dev;
                      ^
/home/broonie/next/next/scripts/Makefile.build:258: recipe for target 'sound/soc/soc-ac97.o' failed
/home/broonie/next/next/scripts/Makefile.build:407: recipe for target 'sound/soc' failed
make[3]: *** [sound/soc/soc-ac97.o] Error 1

We need to cross merge the AC'97 GPIO chip into your tree for you to do the
conversion, I'll send you a pull request later (or in the mornining). For now
I used the last gpio tree that was included in a -next.

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-08-31  6:40 Stephen Rothwell
@ 2015-08-31  6:49 ` Linus Walleij
  0 siblings, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2015-08-31  6:49 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Julia Lawall, Fengguang Wu

On Mon, Aug 31, 2015 at 8:40 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpio/gpio-etraxfs.c: In function 'etraxfs_gpio_irq_request_resources':
> drivers/gpio/gpio-etraxfs.c:300:2: error: 'ret' undeclared (first use in this function)
>   ret = gpiochip_lock_as_irq(&chip->bgc.gc, d->hwirq);
>   ^
>
> Caused by commit
>
>   5e22ec019823 ("gpio: extraxfs: fix returnvar.cocci warnings")

Seems like the coccinelle patch was made against an earlier version
of the tree before some other patches went in.

Pulling this one out...

Thanks,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2015-08-31  6:40 Stephen Rothwell
  2015-08-31  6:49 ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2015-08-31  6:40 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Julia Lawall, Fengguang Wu

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-etraxfs.c: In function 'etraxfs_gpio_irq_request_resources':
drivers/gpio/gpio-etraxfs.c:300:2: error: 'ret' undeclared (first use in this function)
  ret = gpiochip_lock_as_irq(&chip->bgc.gc, d->hwirq);
  ^

Caused by commit

  5e22ec019823 ("gpio: extraxfs: fix returnvar.cocci warnings")

I have used the gpio tree from next-20150828 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-08-18 12:23   ` Uwe Kleine-König
@ 2015-08-18 13:35     ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 103+ messages in thread
From: Mauro Carvalho Chehab @ 2015-08-18 13:35 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Linus Walleij, Stephen Rothwell, linux-next, linux-kernel,
	Philipp Zabel, Hans Verkuil

Em Tue, 18 Aug 2015 14:23:26 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> escreveu:

> Hello Linus,
> 
> I forgot to add you (and also Stephen) to Cc for my slightly different
> patch. You can find it at https://patchwork.linuxtv.org/patch/30908/.
> 
> I just sent you and Stephen a bounce if you want to comment.

My plan is to either apply Stephen or Uwe version at media latter this week,
after giving some time for people to review it.

Regards,
Mauro

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-08-18 12:00 ` Linus Walleij
@ 2015-08-18 12:23   ` Uwe Kleine-König
  2015-08-18 13:35     ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 103+ messages in thread
From: Uwe Kleine-König @ 2015-08-18 12:23 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Stephen Rothwell, Mauro Carvalho Chehab, linux-next,
	linux-kernel, Philipp Zabel, Hans Verkuil

Hello Linus,

I forgot to add you (and also Stephen) to Cc for my slightly different
patch. You can find it at https://patchwork.linuxtv.org/patch/30908/.

I just sent you and Stephen a bounce if you want to comment.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-08-18  6:57 Stephen Rothwell
@ 2015-08-18 12:00 ` Linus Walleij
  2015-08-18 12:23   ` Uwe Kleine-König
  0 siblings, 1 reply; 103+ messages in thread
From: Linus Walleij @ 2015-08-18 12:00 UTC (permalink / raw)
  To: Stephen Rothwell, Mauro Carvalho Chehab
  Cc: linux-next, linux-kernel, Philipp Zabel, Hans Verkuil,
	Uwe Kleine-König

On Tue, Aug 18, 2015 at 8:57 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Linus,
>
> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/media/i2c/tc358743.c: In function 'tc358743_probe_of':
> drivers/media/i2c/tc358743.c:1786:22: error: too few arguments to function 'devm_gpiod_get'
>   state->reset_gpio = devm_gpiod_get(dev, "reset");
>                       ^
> In file included from drivers/media/i2c/tc358743.c:34:0:
> include/linux/gpio/consumer.h:73:32: note: declared here
>  struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
>                                 ^

Argh.

> I have added the following fix patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 18 Aug 2015 16:53:21 +1000
> Subject: [PATCH] [media] tc358743: fix for devm_gpiod_get API change
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/media/i2c/tc358743.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
> index fe42c9a1cb78..8f7641164d9d 100644
> --- a/drivers/media/i2c/tc358743.c
> +++ b/drivers/media/i2c/tc358743.c
> @@ -1783,7 +1783,7 @@ static int tc358743_probe_of(struct tc358743_state *state)
>         state->pdata.ths_trailcnt = 0x2;
>         state->pdata.hstxvregcnt = 0;
>
> -       state->reset_gpio = devm_gpiod_get(dev, "reset");
> +       state->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_ASIS);
>         if (IS_ERR(state->reset_gpio)) {
>                 dev_err(dev, "failed to get reset gpio\n");
>                 ret = PTR_ERR(state->reset_gpio);

This is likely the correct solution. Mauro, can you apply Stephen's
patch to your media tree?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2015-08-18  6:57 Stephen Rothwell
  2015-08-18 12:00 ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2015-08-18  6:57 UTC (permalink / raw)
  To: Linus Walleij, Mauro Carvalho Chehab
  Cc: linux-next, linux-kernel, Philipp Zabel, Hans Verkuil,
	Uwe Kleine-König

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/media/i2c/tc358743.c: In function 'tc358743_probe_of':
drivers/media/i2c/tc358743.c:1786:22: error: too few arguments to function 'devm_gpiod_get'
  state->reset_gpio = devm_gpiod_get(dev, "reset");
                      ^
In file included from drivers/media/i2c/tc358743.c:34:0:
include/linux/gpio/consumer.h:73:32: note: declared here
 struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
                                ^

Caused by commit

  b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")

interacting with commit

  256148246852 ("[media] tc358743: support probe from device tree")

from the v4l-dvb tree.

I have added the following fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 18 Aug 2015 16:53:21 +1000
Subject: [PATCH] [media] tc358743: fix for devm_gpiod_get API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/media/i2c/tc358743.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index fe42c9a1cb78..8f7641164d9d 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -1783,7 +1783,7 @@ static int tc358743_probe_of(struct tc358743_state *state)
 	state->pdata.ths_trailcnt = 0x2;
 	state->pdata.hstxvregcnt = 0;
 
-	state->reset_gpio = devm_gpiod_get(dev, "reset");
+	state->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_ASIS);
 	if (IS_ERR(state->reset_gpio)) {
 		dev_err(dev, "failed to get reset gpio\n");
 		ret = PTR_ERR(state->reset_gpio);
-- 
2.5.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-08-13  0:19     ` Chanwoo Choi
@ 2015-08-13  0:50       ` Stephen Rothwell
  0 siblings, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2015-08-13  0:50 UTC (permalink / raw)
  To: Chanwoo Choi
  Cc: Uwe Kleine-König, Linus Walleij, linux-next, linux-kernel,
	Roger Quadros

Hi Chanwoo,

On Thu, 13 Aug 2015 09:19:12 +0900 Chanwoo Choi <cw00.choi@samsung.com> wrote:
>
> Hi Stephen,
> 
> On 08/13/2015 08:02 AM, Stephen Rothwell wrote:
> > Hi Uwe,
> > 
> > On Wed, 12 Aug 2015 22:16:42 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> >>
> >> On Wed, Aug 12, 2015 at 06:10:45PM +1000, Stephen Rothwell wrote:
> >>> After merging the gpio tree, today's linux-next build (powerpc
> >>> allyesconfig) failed like this:
> >>>
> >>> drivers/extcon/extcon-palmas.c:211:25: error: too few arguments to function 'devm_gpiod_get_optional'
> >>>   palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
> >>>                          ^
> >>> In file included from /home/sfr/next/next/include/asm-generic/gpio.h:13:0,
> >>>                  from /home/sfr/next/next/include/linux/gpio.h:51,
> >>>                  from /home/sfr/next/next/include/linux/of_gpio.h:20,
> >>>                  from /home/sfr/next/next/include/linux/mfd/palmas.h:24,
> >>>                  from /home/sfr/next/next/drivers/extcon/extcon-palmas.c:28:
> >>> /home/sfr/next/next/include/linux/gpio/consumer.h:80:32: note: declared here
> >>>  struct gpio_desc *__must_check devm_gpiod_get_optional(struct device *dev,
> >>>                                 ^
> >>>
> >>> Caused by commit
> >>>
> >>>   b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
> >>>
> >>> interacting with commit
> >>>
> >>>   92b7cb5dc885 ("extcon: palmas: Support GPIO based USB ID detection")
> >> that commit is not correct. After
> >>
> >> 	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
> >>
> >> it does
> >>
> >> 	palmas_usb->gpio_id_irq = gpiod_to_irq(palmas_usb->id_gpiod);
> >>
> >> without setting the gpio to input. So the right fix is not to add
> >> GPIOD_ASIS but GPIOD_IN.
> > 
> > OK, I have fixed my merge fix patch, but can you submit a correct patch
> > to the extcon tree maintainer, please?  I assume it can be fixed in
> > that tree right now, right?
> > 
> 
> I'll fix it as Uwe comment as following:
> 
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>                         palmas_usb->wakeup = pdata->wakeup;
>         }
>  
> -       palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
> +       palmas_usb->id_gpiod =
> +               devm_gpiod_get_optional(&pdev->dev, "id", GPIOD_IN);
>         if (IS_ERR(palmas_usb->id_gpiod)) {
>                 dev_err(&pdev->dev, "failed to get id gpio\n");
>                 return PTR_ERR(palmas_usb->id_gpiod);
> 
> I'll send it to LKML and apply it on extcon-next tree.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-08-12 23:02   ` Stephen Rothwell
@ 2015-08-13  0:19     ` Chanwoo Choi
  2015-08-13  0:50       ` Stephen Rothwell
  0 siblings, 1 reply; 103+ messages in thread
From: Chanwoo Choi @ 2015-08-13  0:19 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Uwe Kleine-König, Linus Walleij, linux-next, linux-kernel,
	Roger Quadros

Hi Stephen,

On 08/13/2015 08:02 AM, Stephen Rothwell wrote:
> Hi Uwe,
> 
> On Wed, 12 Aug 2015 22:16:42 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>>
>> On Wed, Aug 12, 2015 at 06:10:45PM +1000, Stephen Rothwell wrote:
>>> After merging the gpio tree, today's linux-next build (powerpc
>>> allyesconfig) failed like this:
>>>
>>> drivers/extcon/extcon-palmas.c:211:25: error: too few arguments to function 'devm_gpiod_get_optional'
>>>   palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
>>>                          ^
>>> In file included from /home/sfr/next/next/include/asm-generic/gpio.h:13:0,
>>>                  from /home/sfr/next/next/include/linux/gpio.h:51,
>>>                  from /home/sfr/next/next/include/linux/of_gpio.h:20,
>>>                  from /home/sfr/next/next/include/linux/mfd/palmas.h:24,
>>>                  from /home/sfr/next/next/drivers/extcon/extcon-palmas.c:28:
>>> /home/sfr/next/next/include/linux/gpio/consumer.h:80:32: note: declared here
>>>  struct gpio_desc *__must_check devm_gpiod_get_optional(struct device *dev,
>>>                                 ^
>>>
>>> Caused by commit
>>>
>>>   b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>>>
>>> interacting with commit
>>>
>>>   92b7cb5dc885 ("extcon: palmas: Support GPIO based USB ID detection")
>> that commit is not correct. After
>>
>> 	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
>>
>> it does
>>
>> 	palmas_usb->gpio_id_irq = gpiod_to_irq(palmas_usb->id_gpiod);
>>
>> without setting the gpio to input. So the right fix is not to add
>> GPIOD_ASIS but GPIOD_IN.
> 
> OK, I have fixed my merge fix patch, but can you submit a correct patch
> to the extcon tree maintainer, please?  I assume it can be fixed in
> that tree right now, right?
> 

I'll fix it as Uwe comment as following:

--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
                        palmas_usb->wakeup = pdata->wakeup;
        }
 
-       palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
+       palmas_usb->id_gpiod =
+               devm_gpiod_get_optional(&pdev->dev, "id", GPIOD_IN);
        if (IS_ERR(palmas_usb->id_gpiod)) {
                dev_err(&pdev->dev, "failed to get id gpio\n");
                return PTR_ERR(palmas_usb->id_gpiod);

I'll send it to LKML and apply it on extcon-next tree.

Thanks,
Chanwoo Choi


^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-08-12 20:16 ` Uwe Kleine-König
@ 2015-08-12 23:02   ` Stephen Rothwell
  2015-08-13  0:19     ` Chanwoo Choi
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2015-08-12 23:02 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Linus Walleij, Chanwoo Choi, linux-next, linux-kernel, Roger Quadros

Hi Uwe,

On Wed, 12 Aug 2015 22:16:42 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>
> On Wed, Aug 12, 2015 at 06:10:45PM +1000, Stephen Rothwell wrote:
> > After merging the gpio tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> > 
> > drivers/extcon/extcon-palmas.c:211:25: error: too few arguments to function 'devm_gpiod_get_optional'
> >   palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
> >                          ^
> > In file included from /home/sfr/next/next/include/asm-generic/gpio.h:13:0,
> >                  from /home/sfr/next/next/include/linux/gpio.h:51,
> >                  from /home/sfr/next/next/include/linux/of_gpio.h:20,
> >                  from /home/sfr/next/next/include/linux/mfd/palmas.h:24,
> >                  from /home/sfr/next/next/drivers/extcon/extcon-palmas.c:28:
> > /home/sfr/next/next/include/linux/gpio/consumer.h:80:32: note: declared here
> >  struct gpio_desc *__must_check devm_gpiod_get_optional(struct device *dev,
> >                                 ^
> > 
> > Caused by commit
> > 
> >   b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
> > 
> > interacting with commit
> > 
> >   92b7cb5dc885 ("extcon: palmas: Support GPIO based USB ID detection")
> that commit is not correct. After
> 
> 	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
> 
> it does
> 
> 	palmas_usb->gpio_id_irq = gpiod_to_irq(palmas_usb->id_gpiod);
> 
> without setting the gpio to input. So the right fix is not to add
> GPIOD_ASIS but GPIOD_IN.

OK, I have fixed my merge fix patch, but can you submit a correct patch
to the extcon tree maintainer, please?  I assume it can be fixed in
that tree right now, right?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-08-12  8:10 Stephen Rothwell
  2015-08-12  8:21 ` Uwe Kleine-König
@ 2015-08-12 20:16 ` Uwe Kleine-König
  2015-08-12 23:02   ` Stephen Rothwell
  1 sibling, 1 reply; 103+ messages in thread
From: Uwe Kleine-König @ 2015-08-12 20:16 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus Walleij, Chanwoo Choi, linux-next, linux-kernel, Roger Quadros

Hello,

On Wed, Aug 12, 2015 at 06:10:45PM +1000, Stephen Rothwell wrote:
> After merging the gpio tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/extcon/extcon-palmas.c:211:25: error: too few arguments to function 'devm_gpiod_get_optional'
>   palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
>                          ^
> In file included from /home/sfr/next/next/include/asm-generic/gpio.h:13:0,
>                  from /home/sfr/next/next/include/linux/gpio.h:51,
>                  from /home/sfr/next/next/include/linux/of_gpio.h:20,
>                  from /home/sfr/next/next/include/linux/mfd/palmas.h:24,
>                  from /home/sfr/next/next/drivers/extcon/extcon-palmas.c:28:
> /home/sfr/next/next/include/linux/gpio/consumer.h:80:32: note: declared here
>  struct gpio_desc *__must_check devm_gpiod_get_optional(struct device *dev,
>                                 ^
> 
> Caused by commit
> 
>   b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
> 
> interacting with commit
> 
>   92b7cb5dc885 ("extcon: palmas: Support GPIO based USB ID detection")
that commit is not correct. After

	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");

it does

	palmas_usb->gpio_id_irq = gpiod_to_irq(palmas_usb->id_gpiod);

without setting the gpio to input. So the right fix is not to add
GPIOD_ASIS but GPIOD_IN.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-08-12 12:27   ` Stephen Rothwell
@ 2015-08-12 15:03     ` Stephen Rothwell
  0 siblings, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2015-08-12 15:03 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Linus Walleij, Chanwoo Choi, linux-next, linux-kernel, Roger Quadros

Hi Uwe,

On Wed, 12 Aug 2015 22:27:58 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Wed, 12 Aug 2015 10:21:07 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> >
> > On Wed, Aug 12, 2015 at 06:10:45PM +1000, Stephen Rothwell wrote:
> > > After merging the gpio tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > > 
> > > drivers/extcon/extcon-palmas.c:211:25: error: too few arguments to function 'devm_gpiod_get_optional'
> > >   palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
> > >                          ^
> > > In file included from /home/sfr/next/next/include/asm-generic/gpio.h:13:0,
> > >                  from /home/sfr/next/next/include/linux/gpio.h:51,
> > >                  from /home/sfr/next/next/include/linux/of_gpio.h:20,
> > >                  from /home/sfr/next/next/include/linux/mfd/palmas.h:24,
> > >                  from /home/sfr/next/next/drivers/extcon/extcon-palmas.c:28:
> > > /home/sfr/next/next/include/linux/gpio/consumer.h:80:32: note: declared here
> > >  struct gpio_desc *__must_check devm_gpiod_get_optional(struct device *dev,
> > >                                 ^
> > > 
> > > Caused by commit
> > > 
> > >   b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
> > > 
> > > interacting with commit
> > > 
> > >   92b7cb5dc885 ("extcon: palmas: Support GPIO based USB ID detection")
> >
> > I don't find this commit, can you tell me though which tree this comes
> > into next?
> 
> Umm, the next line of that email said:
> 
> "from the extcon tree."
> 
> :-)
> 
> That would be
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git#extcon-next
> 
> run by Chanwoo Choi.

Sorry about that, but I hadn't pushed the linux-tree out yet ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-08-12  8:21 ` Uwe Kleine-König
@ 2015-08-12 12:27   ` Stephen Rothwell
  2015-08-12 15:03     ` Stephen Rothwell
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2015-08-12 12:27 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Linus Walleij, Chanwoo Choi, linux-next, linux-kernel, Roger Quadros

Hi Uwe,

On Wed, 12 Aug 2015 10:21:07 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>
> On Wed, Aug 12, 2015 at 06:10:45PM +1000, Stephen Rothwell wrote:
> > After merging the gpio tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> > 
> > drivers/extcon/extcon-palmas.c:211:25: error: too few arguments to function 'devm_gpiod_get_optional'
> >   palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
> >                          ^
> > In file included from /home/sfr/next/next/include/asm-generic/gpio.h:13:0,
> >                  from /home/sfr/next/next/include/linux/gpio.h:51,
> >                  from /home/sfr/next/next/include/linux/of_gpio.h:20,
> >                  from /home/sfr/next/next/include/linux/mfd/palmas.h:24,
> >                  from /home/sfr/next/next/drivers/extcon/extcon-palmas.c:28:
> > /home/sfr/next/next/include/linux/gpio/consumer.h:80:32: note: declared here
> >  struct gpio_desc *__must_check devm_gpiod_get_optional(struct device *dev,
> >                                 ^
> > 
> > Caused by commit
> > 
> >   b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
> > 
> > interacting with commit
> > 
> >   92b7cb5dc885 ("extcon: palmas: Support GPIO based USB ID detection")
>
> I don't find this commit, can you tell me though which tree this comes
> into next?

Umm, the next line of that email said:

"from the extcon tree."

:-)

That would be

  git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git#extcon-next

run by Chanwoo Choi.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-08-12  8:10 Stephen Rothwell
@ 2015-08-12  8:21 ` Uwe Kleine-König
  2015-08-12 12:27   ` Stephen Rothwell
  2015-08-12 20:16 ` Uwe Kleine-König
  1 sibling, 1 reply; 103+ messages in thread
From: Uwe Kleine-König @ 2015-08-12  8:21 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus Walleij, Chanwoo Choi, linux-next, linux-kernel, Roger Quadros

Hello Stephen,

On Wed, Aug 12, 2015 at 06:10:45PM +1000, Stephen Rothwell wrote:
> After merging the gpio tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/extcon/extcon-palmas.c:211:25: error: too few arguments to function 'devm_gpiod_get_optional'
>   palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
>                          ^
> In file included from /home/sfr/next/next/include/asm-generic/gpio.h:13:0,
>                  from /home/sfr/next/next/include/linux/gpio.h:51,
>                  from /home/sfr/next/next/include/linux/of_gpio.h:20,
>                  from /home/sfr/next/next/include/linux/mfd/palmas.h:24,
>                  from /home/sfr/next/next/drivers/extcon/extcon-palmas.c:28:
> /home/sfr/next/next/include/linux/gpio/consumer.h:80:32: note: declared here
>  struct gpio_desc *__must_check devm_gpiod_get_optional(struct device *dev,
>                                 ^
> 
> Caused by commit
> 
>   b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
> 
> interacting with commit
> 
>   92b7cb5dc885 ("extcon: palmas: Support GPIO based USB ID detection")
I don't find this commit, can you tell me though which tree this comes
into next?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2015-08-12  8:10 Stephen Rothwell
  2015-08-12  8:21 ` Uwe Kleine-König
  2015-08-12 20:16 ` Uwe Kleine-König
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2015-08-12  8:10 UTC (permalink / raw)
  To: Linus Walleij, Chanwoo Choi
  Cc: linux-next, linux-kernel, Roger Quadros, Uwe Kleine-König

Hi Linus,

After merging the gpio tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/extcon/extcon-palmas.c:211:25: error: too few arguments to function 'devm_gpiod_get_optional'
  palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
                         ^
In file included from /home/sfr/next/next/include/asm-generic/gpio.h:13:0,
                 from /home/sfr/next/next/include/linux/gpio.h:51,
                 from /home/sfr/next/next/include/linux/of_gpio.h:20,
                 from /home/sfr/next/next/include/linux/mfd/palmas.h:24,
                 from /home/sfr/next/next/drivers/extcon/extcon-palmas.c:28:
/home/sfr/next/next/include/linux/gpio/consumer.h:80:32: note: declared here
 struct gpio_desc *__must_check devm_gpiod_get_optional(struct device *dev,
                                ^

Caused by commit

  b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")

interacting with commit

  92b7cb5dc885 ("extcon: palmas: Support GPIO based USB ID detection")

from the extcon tree.

I have applied this merge fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 12 Aug 2015 18:05:55 +1000
Subject: [PATCH] extcon: palmas: fix for devm_gpiod_get_optional API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/extcon/extcon-palmas.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index 662e91778cb0..4ce4106b8f4f 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -208,7 +208,7 @@ static int palmas_usb_probe(struct platform_device *pdev)
 			palmas_usb->wakeup = pdata->wakeup;
 	}
 
-	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
+	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", GPIOD_ASIS);
 	if (IS_ERR(palmas_usb->id_gpiod)) {
 		dev_err(&pdev->dev, "failed to get id gpio\n");
 		return PTR_ERR(palmas_usb->id_gpiod);
-- 
2.5.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2015-08-12  6:59 Stephen Rothwell
  0 siblings, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2015-08-12  6:59 UTC (permalink / raw)
  To: Linus Walleij, Gustavo Padovan
  Cc: linux-next, linux-kernel, Uwe Kleine-König, Frederic Danis,
	Marcel Holtmann

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/bluetooth/hci_bcm.c: In function 'bcm_acpi_probe':
drivers/bluetooth/hci_bcm.c:429:9: error: too few arguments to function 'devm_gpiod_get'
  gpio = devm_gpiod_get(&pdev->dev, "device-wakeup");
         ^
In file included from drivers/bluetooth/hci_bcm.c:32:0:
include/linux/gpio/consumer.h:73:32: note: declared here
 struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
                                ^
drivers/bluetooth/hci_bcm.c:437:9: error: too few arguments to function 'devm_gpiod_get'
  gpio = devm_gpiod_get(&pdev->dev, "shutdown");
         ^
In file included from drivers/bluetooth/hci_bcm.c:32:0:
include/linux/gpio/consumer.h:73:32: note: declared here
 struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
                                ^

Caused by commit

  b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")

Interacting with commit

  0395ffc1ee05 ("Bluetooth: hci_bcm: Add PM for BCM devices")

from the bluetooth tree.

I added the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 12 Aug 2015 16:55:58 +1000
Subject: [PATCH] Bluetooth: hci_bcm: fix for devm_gpiod_get API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/bluetooth/hci_bcm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index cb7fe837f7d9..c3291a4ab2e8 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -426,7 +426,7 @@ static int bcm_acpi_probe(struct bcm_device *dev)
 
 	dev->clk = devm_clk_get(&pdev->dev, NULL);
 
-	gpio = devm_gpiod_get(&pdev->dev, "device-wakeup");
+	gpio = devm_gpiod_get(&pdev->dev, "device-wakeup", GPIOD_ASIS);
 	if (!IS_ERR(gpio)) {
 		ret = gpiod_direction_output(gpio, 0);
 		if (ret)
@@ -434,7 +434,7 @@ static int bcm_acpi_probe(struct bcm_device *dev)
 		dev->device_wakeup = gpio;
 	}
 
-	gpio = devm_gpiod_get(&pdev->dev, "shutdown");
+	gpio = devm_gpiod_get(&pdev->dev, "shutdown", GPIOD_ASIS);
 	if (!IS_ERR(gpio)) {
 		ret = gpiod_direction_output(gpio, 0);
 		if (ret)
-- 
2.5.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-08-10  5:46 ` Dmitry Torokhov
@ 2015-08-10 22:51   ` Stephen Rothwell
  0 siblings, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2015-08-10 22:51 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: Linus Walleij, linux-next, linux-kernel, Uwe Kleine-König

Hi Dmitry,

On Sun, 9 Aug 2015 22:46:52 -0700 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> Thank you for the patch. I think we actually want GPIOD_OUT_LOW and kill
> the "else" branch altogether, like below.

I will use your patch from today.  Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-08-10  5:07 Stephen Rothwell
@ 2015-08-10  5:46 ` Dmitry Torokhov
  2015-08-10 22:51   ` Stephen Rothwell
  0 siblings, 1 reply; 103+ messages in thread
From: Dmitry Torokhov @ 2015-08-10  5:46 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus Walleij, linux-next, linux-kernel, Uwe Kleine-König

Hi Stephen,

On Mon, Aug 10, 2015 at 03:07:41PM +1000, Stephen Rothwell wrote:
> Hi Linus,
> 
> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/input/touchscreen/elants_i2c.c: In function 'elants_i2c_probe':
> drivers/input/touchscreen/elants_i2c.c:1176:19: error: too few arguments to function 'devm_gpiod_get'
>   ts->reset_gpio = devm_gpiod_get(&client->dev, "reset");
>                    ^
> In file included from drivers/input/touchscreen/elants_i2c.c:41:0:
> include/linux/gpio/consumer.h:73:32: note: declared here
>  struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
>                                 ^
> 
> Caused by commit
> 
>   b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
> 
> Interacting with commit
> 
>   afe10358e47a ("Input: elants_i2c - wire up regulator support")
> 
> from the input tree.
> 
> I have added the following merge fix patch:

Thank you for the patch. I think we actually want GPIOD_OUT_LOW and kill
the "else" branch altogether, like below.

Thanks.

-- 
Dmitry

Input: elants_i2c - fix for devm_gpiod_get API change

From: Stephen Rothwell <sfr@canb.auug.org.au>

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/elants_i2c.c |   10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index 6f71556..ddac134 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -1173,7 +1173,7 @@ static int elants_i2c_probe(struct i2c_client *client,
 		return error;
 	}
 
-	ts->reset_gpio = devm_gpiod_get(&client->dev, "reset");
+	ts->reset_gpio = devm_gpiod_get(&client->dev, "reset", GPIOD_OUT_LOW);
 	if (IS_ERR(ts->reset_gpio)) {
 		error = PTR_ERR(ts->reset_gpio);
 
@@ -1188,14 +1188,6 @@ static int elants_i2c_probe(struct i2c_client *client,
 		}
 
 		ts->keep_power_in_suspend = true;
-	} else {
-		error = gpiod_direction_output(ts->reset_gpio, 0);
-		if (error) {
-			dev_err(&client->dev,
-				"failed to configure reset gpio as output: %d\n",
-				error);
-			return error;
-		}
 	}
 
 	error = elants_i2c_power_on(ts);

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2015-08-10  5:07 Stephen Rothwell
  2015-08-10  5:46 ` Dmitry Torokhov
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2015-08-10  5:07 UTC (permalink / raw)
  To: Linus Walleij, Dmitry Torokhov
  Cc: linux-next, linux-kernel, Uwe Kleine-König

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/input/touchscreen/elants_i2c.c: In function 'elants_i2c_probe':
drivers/input/touchscreen/elants_i2c.c:1176:19: error: too few arguments to function 'devm_gpiod_get'
  ts->reset_gpio = devm_gpiod_get(&client->dev, "reset");
                   ^
In file included from drivers/input/touchscreen/elants_i2c.c:41:0:
include/linux/gpio/consumer.h:73:32: note: declared here
 struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
                                ^

Caused by commit

  b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")

Interacting with commit

  afe10358e47a ("Input: elants_i2c - wire up regulator support")

from the input tree.

I have added the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 10 Aug 2015 15:01:19 +1000
Subject: [PATCH] Input: elants_i2c: fix for devm_gpiod_get API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/input/touchscreen/elants_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index 6f7155641591..1e7b931d6112 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -1173,7 +1173,7 @@ static int elants_i2c_probe(struct i2c_client *client,
 		return error;
 	}
 
-	ts->reset_gpio = devm_gpiod_get(&client->dev, "reset");
+	ts->reset_gpio = devm_gpiod_get(&client->dev, "reset", GPIOD_ASIS);
 	if (IS_ERR(ts->reset_gpio)) {
 		error = PTR_ERR(ts->reset_gpio);
 
-- 
2.5.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2015-07-21  3:29 Stephen Rothwell
  0 siblings, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2015-07-21  3:29 UTC (permalink / raw)
  To: Linus Walleij, Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, Chris Zhong, Uwe Kleine-König

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/rk808-regulator.c: In function 'rk808_regulator_dt_parse_pdata':
drivers/regulator/rk808-regulator.c:543:24: error: too few arguments to function 'gpiod_get_index'
   pdata->dvs_gpio[i] = gpiod_get_index(client_dev, "dvs", i);
                        ^
In file included from include/asm-generic/gpio.h:13:0,
                 from include/linux/gpio.h:51,
                 from drivers/regulator/rk808-regulator.c:20:
include/linux/gpio/consumer.h:53:32: note: declared here
 struct gpio_desc *__must_check gpiod_get_index(struct device *dev,
                                ^

Caused by commit

  bad47ad2eef3 ("regulator: rk808: fixed the overshoot when adjust voltage")

from the regulator tree interactings with commit

  b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")

from the gpio tree.

I added teh following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 21 Jul 2015 13:23:56 +1000
Subject: [PATCH] regulator: rk808: fix up for gpiod_get_index() API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/regulator/rk808-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c
index ca913fd15598..cfec52c1a4a2 100644
--- a/drivers/regulator/rk808-regulator.c
+++ b/drivers/regulator/rk808-regulator.c
@@ -540,7 +540,7 @@ static int rk808_regulator_dt_parse_pdata(struct device *dev,
 		goto dt_parse_end;
 
 	for (i = 0; i < ARRAY_SIZE(pdata->dvs_gpio); i++) {
-		pdata->dvs_gpio[i] = gpiod_get_index(client_dev, "dvs", i);
+		pdata->dvs_gpio[i] = gpiod_get_index(client_dev, "dvs", i, GPIOD_ASIS);
 		if (IS_ERR(pdata->dvs_gpio[i])) {
 			dev_warn(dev, "there is no dvs%d gpio\n", i);
 			continue;
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-05-13  6:55 Stephen Rothwell
  2015-05-13  7:04 ` Alexandre Courbot
@ 2015-05-13  7:36 ` Johan Hovold
  1 sibling, 0 replies; 103+ messages in thread
From: Johan Hovold @ 2015-05-13  7:36 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus Walleij, linux-next, linux-kernel, Johan Hovold, Alexandre Courbot

On Wed, May 13, 2015 at 04:55:16PM +1000, Stephen Rothwell wrote:
> Hi Linus,
> 
> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpio/gpio-dln2.c: In function 'dln2_gpio_probe':
> drivers/gpio/gpio-dln2.c:469:12: error: 'struct gpio_chip' has no member named 'exported'
>   dln2->gpio.exported = true;
>             ^
> 
> Caused by commit 6a4b6b0a3b55 ("gpio: sysfs: clean up chip class-device
> handling").
> 
> I have used the gpio tree from next-20150512 for today.

A fix for this was posted yesterday (when detected by the kbuild test
robot):

	https://lkml.org/lkml/2015/5/12/437

Johan

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-05-13  6:55 Stephen Rothwell
@ 2015-05-13  7:04 ` Alexandre Courbot
  2015-05-13  7:36 ` Johan Hovold
  1 sibling, 0 replies; 103+ messages in thread
From: Alexandre Courbot @ 2015-05-13  7:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus Walleij, linux-next, Linux Kernel Mailing List,
	Johan Hovold, Alexandre Courbot

On Wed, May 13, 2015 at 3:55 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Linus,
>
> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpio/gpio-dln2.c: In function 'dln2_gpio_probe':
> drivers/gpio/gpio-dln2.c:469:12: error: 'struct gpio_chip' has no member named 'exported'
>   dln2->gpio.exported = true;
>             ^
>
> Caused by commit 6a4b6b0a3b55 ("gpio: sysfs: clean up chip class-device
> handling").

Johan has submitted a fix for this:

https://lkml.org/lkml/2015/5/12/437

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2015-05-13  6:55 Stephen Rothwell
  2015-05-13  7:04 ` Alexandre Courbot
  2015-05-13  7:36 ` Johan Hovold
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2015-05-13  6:55 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Johan Hovold, Alexandre Courbot

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-dln2.c: In function 'dln2_gpio_probe':
drivers/gpio/gpio-dln2.c:469:12: error: 'struct gpio_chip' has no member named 'exported'
  dln2->gpio.exported = true;
            ^

Caused by commit 6a4b6b0a3b55 ("gpio: sysfs: clean up chip class-device
handling").

I have used the gpio tree from next-20150512 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2015-04-10  9:08 Stephen Rothwell
@ 2015-04-10  9:35 ` Linus Walleij
  0 siblings, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2015-04-10  9:35 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Michael S. Tsirkin

On Fri, Apr 10, 2015 at 11:08 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Linus,
>
> After merging the gpio tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/gpio/gpio-sch.c:28:32: fatal error: uapi/linux/pci_ids.h: No such file or directory
>  #include <uapi/linux/pci_ids.h>
>                                 ^
>
> Caused by commit d1e10dc8c104 ("gpio: sch: use uapi/linux/pci_ids.h
> directly"). Clearly this depends on some other patch.

Oh OK so much for not reading patch 0.

OK I'm taking it out of my tree,
Michael, please use my ACK and handle this however you prefer.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2015-04-10  9:08 Stephen Rothwell
  2015-04-10  9:35 ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2015-04-10  9:08 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Michael S. Tsirkin

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/gpio/gpio-sch.c:28:32: fatal error: uapi/linux/pci_ids.h: No such file or directory
 #include <uapi/linux/pci_ids.h>
                                ^

Caused by commit d1e10dc8c104 ("gpio: sch: use uapi/linux/pci_ids.h
directly"). Clearly this depends on some other patch.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2014-08-04  4:10   ` Alexandre Courbot
@ 2014-08-04  4:28     ` Stephen Rothwell
  0 siblings, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2014-08-04  4:28 UTC (permalink / raw)
  To: Alexandre Courbot
  Cc: Thierry Reding, Linus Walleij, Olof Johansson, Arnd Bergmann,
	linux-arm-kernel, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

Hi Alexandre,

On Mon, 4 Aug 2014 13:10:14 +0900 Alexandre Courbot <gnurou@gmail.com> wrote:
>
> I have sent a patch to fix this. In the meantime, if the merge
> conflict of the GPIO tree on board-paz00.c is solved by taking the
> GPIO version, there is no build error.
> 
> There are a few important patches pending in the GPIO tree that should
> undergo testing - Stephen, do you think you could resolve the conflict
> that way to enable the latest GPIO tree to be tested again?

No, but I will apply that fix patch in my merge of the gpio tree - just
make sure it is applied to the gpio tree before Linus (Torvalds) is
asked to pull it.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2014-07-29  8:42 ` Thierry Reding
@ 2014-08-04  4:10   ` Alexandre Courbot
  2014-08-04  4:28     ` Stephen Rothwell
  0 siblings, 1 reply; 103+ messages in thread
From: Alexandre Courbot @ 2014-08-04  4:10 UTC (permalink / raw)
  To: Thierry Reding, Stephen Rothwell
  Cc: Linus Walleij, Olof Johansson, Arnd Bergmann, linux-arm-kernel,
	linux-next, linux-kernel

I have sent a patch to fix this. In the meantime, if the merge
conflict of the GPIO tree on board-paz00.c is solved by taking the
GPIO version, there is no build error.

There are a few important patches pending in the GPIO tree that should
undergo testing - Stephen, do you think you could resolve the conflict
that way to enable the latest GPIO tree to be tested again?

Thanks,
Alex.

On Tue, Jul 29, 2014 at 5:42 PM, Thierry Reding <treding@nvidia.com> wrote:
> On Tue, Jul 29, 2014 at 10:31:53AM +0200, Stephen Rothwell wrote:
>> * PGP Signed by an unknown key
>>
>> Hi Linus,
>>
>> After merging the gpio tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> In file included from arch/arm/mach-tegra/board-paz00.c:20:0:
>> include/linux/gpio/machine.h:24:2: error: unknown type name 'u16'
>>   u16 chip_hwnum;
>>   ^
>> include/linux/gpio/machine.h:31:19: error: field 'list' has incomplete type
>>   struct list_head list;
>>                    ^
>>
>> Caused by commit 0a6d315827ee ("gpio: split gpiod board registration
>> into machine header") or an interaction of that with commit
>> a0524acc94c9 ("ARM: tegra: Sort includes alphabetically") from the
>> arm-soc tree.
>>
>> linux/gpio/machine.h needs to include some of the same files that
>> linux/gpio/driver.h does.  See Rule 1 in Documentation/SubmitChecklist.
>>
>> I have used the version of the gpio tree from next-20140728 for today.
>
> I think linux/gpio/machine.h needs at least linux/types.h (for u16,
> though I guess that "dependency" could be removed by simply making
> gpiod_lookup.chip_hwnum an unsigned int) and linux/list.h for struct
> list_head.
>
> Thierry

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2014-07-29  8:31 Stephen Rothwell
@ 2014-07-29  8:42 ` Thierry Reding
  2014-08-04  4:10   ` Alexandre Courbot
  0 siblings, 1 reply; 103+ messages in thread
From: Thierry Reding @ 2014-07-29  8:42 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus Walleij, Olof Johansson, Arnd Bergmann, linux-arm-kernel,
	linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

On Tue, Jul 29, 2014 at 10:31:53AM +0200, Stephen Rothwell wrote:
> * PGP Signed by an unknown key
> 
> Hi Linus,
> 
> After merging the gpio tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> In file included from arch/arm/mach-tegra/board-paz00.c:20:0:
> include/linux/gpio/machine.h:24:2: error: unknown type name 'u16'
>   u16 chip_hwnum;
>   ^
> include/linux/gpio/machine.h:31:19: error: field 'list' has incomplete type
>   struct list_head list;
>                    ^
> 
> Caused by commit 0a6d315827ee ("gpio: split gpiod board registration
> into machine header") or an interaction of that with commit
> a0524acc94c9 ("ARM: tegra: Sort includes alphabetically") from the
> arm-soc tree.
> 
> linux/gpio/machine.h needs to include some of the same files that
> linux/gpio/driver.h does.  See Rule 1 in Documentation/SubmitChecklist.
> 
> I have used the version of the gpio tree from next-20140728 for today.

I think linux/gpio/machine.h needs at least linux/types.h (for u16,
though I guess that "dependency" could be removed by simply making
gpiod_lookup.chip_hwnum an unsigned int) and linux/list.h for struct
list_head.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2014-07-29  8:31 Stephen Rothwell
  2014-07-29  8:42 ` Thierry Reding
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2014-07-29  8:31 UTC (permalink / raw)
  To: Linus Walleij, Olof Johansson, Arnd Bergmann, linux-arm-kernel
  Cc: linux-next, linux-kernel, Thierry Reding

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from arch/arm/mach-tegra/board-paz00.c:20:0:
include/linux/gpio/machine.h:24:2: error: unknown type name 'u16'
  u16 chip_hwnum;
  ^
include/linux/gpio/machine.h:31:19: error: field 'list' has incomplete type
  struct list_head list;
                   ^

Caused by commit 0a6d315827ee ("gpio: split gpiod board registration
into machine header") or an interaction of that with commit
a0524acc94c9 ("ARM: tegra: Sort includes alphabetically") from the
arm-soc tree.

linux/gpio/machine.h needs to include some of the same files that
linux/gpio/driver.h does.  See Rule 1 in Documentation/SubmitChecklist.

I have used the version of the gpio tree from next-20140728 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2014-05-14  7:13 Stephen Rothwell
@ 2014-05-16 15:54 ` Linus Walleij
  0 siblings, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2014-05-16 15:54 UTC (permalink / raw)
  To: Stephen Rothwell, Lee Jones; +Cc: linux-next, linux-kernel

On Wed, May 14, 2014 at 9:13 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Linus,
>
> After merging the gpio tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
>
> drivers/mfd/stmpe.c: In function 'stmpe_irq_init':
> drivers/mfd/stmpe.c:1000:15: error: 'struct stmpe' has no member named 'irq_base'
>    base = stmpe->irq_base;
>                ^
>
> Caused by commit 3ba1d516d5fe ("mfd: stmpe: root out static GPIO and
> IRQ assignments").
>
> I have reverted that commit for today (and e013a5148882 "gpio: stmpe:
> switch to use gpiolib irqchip helpers" that depends on it).
>
> Also, that commit has no Signed-off-by for its committer (Lee).

Hm I know has struggled with this series sorry if it's all my fault :-/

I've un-pulled that branch from the GPIO tree, let's get the immutable
branch in MFD right first then.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2014-05-14  7:13 Stephen Rothwell
  2014-05-16 15:54 ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2014-05-14  7:13 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Lee Jones

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (powerpc allyesconfig)
failed like this:

drivers/mfd/stmpe.c: In function 'stmpe_irq_init':
drivers/mfd/stmpe.c:1000:15: error: 'struct stmpe' has no member named 'irq_base'
   base = stmpe->irq_base;
               ^

Caused by commit 3ba1d516d5fe ("mfd: stmpe: root out static GPIO and
IRQ assignments").

I have reverted that commit for today (and e013a5148882 "gpio: stmpe:
switch to use gpiolib irqchip helpers" that depends on it).

Also, that commit has no Signed-off-by for its committer (Lee).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2014-01-20  5:42 Stephen Rothwell
  0 siblings, 0 replies; 103+ messages in thread
From: Stephen Rothwell @ 2014-01-20  5:42 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Lars Poeschel

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-mcp23s08.c: In function 'mcp23s08_irq_setup':
drivers/gpio/gpio-mcp23s08.c:482:46: error: 'struct gpio_chip' has no member named 'of_node'
  mcp->irq_domain = irq_domain_add_linear(chip->of_node, chip->ngpio,
                                              ^
drivers/gpio/gpio-mcp23s08.c: In function 'mcp23s08_probe_one':
drivers/gpio/gpio-mcp23s08.c:651:55: error: 'struct gpio_chip' has no member named 'of_node'
  mcp->irq_controller = of_property_read_bool(mcp->chip.of_node,
                                                       ^
drivers/gpio/gpio-mcp23s08.c:654:43: error: 'struct gpio_chip' has no member named 'of_node'
   mirror = of_property_read_bool(mcp->chip.of_node,
                                           ^

Caused by commit 4e47f91bf741 ("gpio: mcp23s08: Add irq functionality for
i2c chips").  The presence of of_node depends on CONFIG_OF_GPIO.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2013-09-18  3:12 Stephen Rothwell
@ 2013-09-18 11:24 ` Linus Walleij
  0 siblings, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2013-09-18 11:24 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, George Cherian

On Wed, Sep 18, 2013 at 5:12 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpio/gpio-pcf857x.c: In function 'pcf857x_irq_domain_map':
> drivers/gpio/gpio-pcf857x.c:206:2: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
>   set_irq_flags(virq, IRQF_VALID);
>   ^

How typical to miss this. OK I've submitted a fix and pushed
to my tree.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2013-09-18  3:12 Stephen Rothwell
  2013-09-18 11:24 ` Linus Walleij
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2013-09-18  3:12 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, George Cherian

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-pcf857x.c: In function 'pcf857x_irq_domain_map':
drivers/gpio/gpio-pcf857x.c:206:2: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
  set_irq_flags(virq, IRQF_VALID);
  ^
drivers/gpio/gpio-pcf857x.c:206:22: error: 'IRQF_VALID' undeclared (first use in this function)
  set_irq_flags(virq, IRQF_VALID);
                      ^

Caused by commit 21fd3cd1874a ("gpio: pcf857x: call the gpio user handler
iff gpio_to_irq is done").

set_irq_flags() only exists on arm (and arm64).

I have used the gpio tree from next-20130917 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2013-03-04  1:45 Stephen Rothwell
  2013-03-04  2:30 ` Linus Walleij
@ 2013-03-04  2:32 ` Grant Likely
  1 sibling, 0 replies; 103+ messages in thread
From: Grant Likely @ 2013-03-04  2:32 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Gabriel Fernandez, Linus Walleij

On Mon, 4 Mar 2013 12:45:13 +1100, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Grant,
> 
> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpio/gpio-stmpe.c: In function 'stmpe_gpio_irq_init':
> drivers/gpio/gpio-stmpe.c:313:23: error: 'struct gpio_chip' has no member named 'of_node'
> drivers/gpio/gpio-stmpe.c:316:61: error: 'struct gpio_chip' has no member named 'of_node'
> drivers/gpio/gpio-stmpe.c: In function 'stmpe_gpio_probe':
> drivers/gpio/gpio-stmpe.c:351:18: error: 'struct gpio_chip' has no member named 'of_node'
> 
> Caused by commit f7719903b7c7 ("").
> 
> I have used the gpio tree from next-20130301 for today.

Yup, I messed that one up. I've now pushed out a fixed branch.

g.

> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2013-03-04  1:45 Stephen Rothwell
@ 2013-03-04  2:30 ` Linus Walleij
  2013-03-04  2:32 ` Grant Likely
  1 sibling, 0 replies; 103+ messages in thread
From: Linus Walleij @ 2013-03-04  2:30 UTC (permalink / raw)
  To: Grant Likely, Gabriel Fernandez
  Cc: linux-next, linux-kernel, Stephen Rothwell

On Mon, Mar 4, 2013 at 2:45 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpio/gpio-stmpe.c: In function 'stmpe_gpio_irq_init':
> drivers/gpio/gpio-stmpe.c:313:23: error: 'struct gpio_chip' has no member named 'of_node'
> drivers/gpio/gpio-stmpe.c:316:61: error: 'struct gpio_chip' has no member named 'of_node'
> drivers/gpio/gpio-stmpe.c: In function 'stmpe_gpio_probe':
> drivers/gpio/gpio-stmpe.c:351:18: error: 'struct gpio_chip' has no member named 'of_node'

So basically when I look at this issue the way we have
the of node optional in gpiolib is inconsistent with the device
core and that makes it easy to do things like this :-(

include/linux/device.h:
struct device {
(...)
         struct device_node      *of_node; /* associated device tree node */
(...)
}

No #ifdef, it used to be there but I guess we deleted it because
of #ifdef clutter elsewhere.

include/asm-generic/gpio.h:
struct gpio_chip {
(...)
#if defined(CONFIG_OF_GPIO)
        /*
         * If CONFIG_OF is enabled, then all GPIO controllers described in the
         * device tree automatically may have an OF translation
         */
        struct device_node *of_node;
        int of_gpio_n_cells;
        int (*of_xlate)(struct gpio_chip *gc,
                        const struct of_phandle_args *gpiospec, u32 *flags);
#endif
(...)
}

Will it help if we just move the of_node outside of the #ifdef
in this case? Or does it have hard deps such that the
of_gpio_n_cells and of_xlate also need to be moved out
in that case?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2013-03-04  1:45 Stephen Rothwell
  2013-03-04  2:30 ` Linus Walleij
  2013-03-04  2:32 ` Grant Likely
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2013-03-04  1:45 UTC (permalink / raw)
  To: Grant Likely; +Cc: linux-next, linux-kernel, Gabriel Fernandez, Linus Walleij

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

Hi Grant,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-stmpe.c: In function 'stmpe_gpio_irq_init':
drivers/gpio/gpio-stmpe.c:313:23: error: 'struct gpio_chip' has no member named 'of_node'
drivers/gpio/gpio-stmpe.c:316:61: error: 'struct gpio_chip' has no member named 'of_node'
drivers/gpio/gpio-stmpe.c: In function 'stmpe_gpio_probe':
drivers/gpio/gpio-stmpe.c:351:18: error: 'struct gpio_chip' has no member named 'of_node'

Caused by commit f7719903b7c7 ("").

I have used the gpio tree from next-20130301 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2012-02-03 23:18 ` Grant Likely
@ 2012-02-04 12:10   ` Mark Brown
  0 siblings, 0 replies; 103+ messages in thread
From: Mark Brown @ 2012-02-04 12:10 UTC (permalink / raw)
  To: Grant Likely; +Cc: Stephen Rothwell, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

On Fri, Feb 03, 2012 at 04:18:08PM -0700, Grant Likely wrote:

> I've dropped the patch from my tree.  Looks like there are still a few
> drivers that need to be either fixed up or made "depends on
> ARCH_HAVE_CUSTOM_GPIO_H".

Would it not be better to add a followup patch replacing the removed
headers with something like:

  #ifndef __LINUX_GPIO_H
  #warn Don't include asm/gpio.h directly, include linux/gpio.h instead
  #endif

instead?  Perhaps even without the ifdef.  That will mean we still get
rid of the boilerplate and will encourage fixups to drivers, nothing
that hits these can be relying on a custom implementation since all the
headers concerned are boilerplate ones.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2012-02-03  2:54 Stephen Rothwell
@ 2012-02-03 23:18 ` Grant Likely
  2012-02-04 12:10   ` Mark Brown
  0 siblings, 1 reply; 103+ messages in thread
From: Grant Likely @ 2012-02-03 23:18 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Mark Brown

On Thu, Feb 2, 2012 at 7:54 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Grant,
>
> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/i2c/busses/i2c-gpio.c:18:22: fatal error: asm/gpio.h: No such file or directory
> drivers/input/mouse/gpio_mouse.c:17:22: fatal error: asm/gpio.h: No such file or directory
> drivers/leds/leds-gpio.c:23:22: fatal error: asm/gpio.h: No such file or directory
>
> Caused by commit 4f79dfb562c2 ("gpiolib/arches: Centralise bolierplate
> asm/gpio.h").  Grep is your friend ...
>
> I have used the gpio tree from next-20120202 for today.

I've dropped the patch from my tree.  Looks like there are still a few
drivers that need to be either fixed up or made "depends on
ARCH_HAVE_CUSTOM_GPIO_H".

g.

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2012-02-03  2:54 Stephen Rothwell
  2012-02-03 23:18 ` Grant Likely
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2012-02-03  2:54 UTC (permalink / raw)
  To: Grant Likely; +Cc: linux-next, linux-kernel, Mark Brown

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

Hi Grant,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/i2c/busses/i2c-gpio.c:18:22: fatal error: asm/gpio.h: No such file or directory
drivers/input/mouse/gpio_mouse.c:17:22: fatal error: asm/gpio.h: No such file or directory
drivers/leds/leds-gpio.c:23:22: fatal error: asm/gpio.h: No such file or directory

Caused by commit 4f79dfb562c2 ("gpiolib/arches: Centralise bolierplate
asm/gpio.h").  Grep is your friend ...

I have used the gpio tree from next-20120202 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2011-10-13  8:22               ` Tomoya MORINAGA
@ 2011-10-13 17:31                 ` Grant Likely
  0 siblings, 0 replies; 103+ messages in thread
From: Grant Likely @ 2011-10-13 17:31 UTC (permalink / raw)
  To: Tomoya MORINAGA
  Cc: Nobuhiro Iwamatsu, Stephen Rothwell, linux-next, linux-kernel

On Thu, Oct 13, 2011 at 05:22:06PM +0900, Tomoya MORINAGA wrote:
> (2011/10/13 12:57), Grant Likely wrote:
> >I've temporarily pushed out a commit that makes the pch and ml_ioh
> >bool instead of tristate.  If that other patch gets acked by Thomas,
> >then I should probably take it through the gpio tree.
> Let me clarify your intention.
> Does previous patch for generic-chip posted by Nobuhiro enable
> pch/ml_ioh gpio driver works on both module and built-in ?
> If yes, why do you need to change tristate to bool ?

Thomas requested changes to that patch.  I cannot pick it up until I
see the new patch and get an ack from Thomas.

g.

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2011-10-13  3:57             ` Grant Likely
@ 2011-10-13  8:22               ` Tomoya MORINAGA
  2011-10-13 17:31                 ` Grant Likely
  0 siblings, 1 reply; 103+ messages in thread
From: Tomoya MORINAGA @ 2011-10-13  8:22 UTC (permalink / raw)
  To: Grant Likely
  Cc: Nobuhiro Iwamatsu, Stephen Rothwell, linux-next, linux-kernel

(2011/10/13 12:57), Grant Likely wrote:
> I've temporarily pushed out a commit that makes the pch and ml_ioh
> bool instead of tristate.  If that other patch gets acked by Thomas,
> then I should probably take it through the gpio tree.
Let me clarify your intention.
Does previous patch for generic-chip posted by Nobuhiro enable 
pch/ml_ioh gpio driver works on both module and built-in ?
If yes, why do you need to change tristate to bool ?

-- 
tomoya
ROHM Co., Ltd.

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2011-10-12  8:37           ` Tomoya MORINAGA
@ 2011-10-13  3:57             ` Grant Likely
  2011-10-13  8:22               ` Tomoya MORINAGA
  0 siblings, 1 reply; 103+ messages in thread
From: Grant Likely @ 2011-10-13  3:57 UTC (permalink / raw)
  To: Tomoya MORINAGA
  Cc: Nobuhiro Iwamatsu, Stephen Rothwell, linux-next, linux-kernel

On Wed, Oct 12, 2011 at 05:37:12PM +0900, Tomoya MORINAGA wrote:
> (2011/10/12 16:21), Nobuhiro Iwamatsu wrote:
> >This is a problem of generic-chip.
> >I created the patch and contributed the point to LKML.
> >He forgot to put you into CC, sorry.
> >
> >Please check LKML for subject of "[PATCH] irq: Add EXPORT_SYMBOL to
> >function of irq generic-chip".
> >
> 
> OK,
> We will be able to use our GPIO driver with module soon.
> Good information.

I've temporarily pushed out a commit that makes the pch and ml_ioh
bool instead of tristate.  If that other patch gets acked by Thomas,
then I should probably take it through the gpio tree.

g.


^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2011-10-12  7:21         ` Nobuhiro Iwamatsu
@ 2011-10-12  8:37           ` Tomoya MORINAGA
  2011-10-13  3:57             ` Grant Likely
  0 siblings, 1 reply; 103+ messages in thread
From: Tomoya MORINAGA @ 2011-10-12  8:37 UTC (permalink / raw)
  To: Nobuhiro Iwamatsu
  Cc: Stephen Rothwell, Grant Likely, linux-next, linux-kernel

(2011/10/12 16:21), Nobuhiro Iwamatsu wrote:
> This is a problem of generic-chip.
> I created the patch and contributed the point to LKML.
> He forgot to put you into CC, sorry.
>
> Please check LKML for subject of "[PATCH] irq: Add EXPORT_SYMBOL to
> function of irq generic-chip".
>

OK,
We will be able to use our GPIO driver with module soon.
Good information.

thanks,
------
tomoya
ROHM Co., Ltd.

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2011-10-12  5:29       ` Tomoya MORINAGA
@ 2011-10-12  7:21         ` Nobuhiro Iwamatsu
  2011-10-12  8:37           ` Tomoya MORINAGA
  0 siblings, 1 reply; 103+ messages in thread
From: Nobuhiro Iwamatsu @ 2011-10-12  7:21 UTC (permalink / raw)
  To: Tomoya MORINAGA
  Cc: Stephen Rothwell, Grant Likely, linux-next, linux-kernel,
	Tomoya MORINAGA

Hi,

2011年10月12日14:29 Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>:
> Hi, Stephen
>
> (2011/10/12 13:24), Stephen Rothwell wrote:
>>
>> Just try building gpio-pch and gpio-ml-ioh as modules ...
>> irq_setup_generic_chip() does not have an EXPORT_SYMBOL (and didn't in
>> v3.0 either).
>>
>
> Your report looks like the same as ours.
> In our develop environment,
> build becomes success only gpio-pch/gpio-ml-ioh is integrated as built-in.
> In case of integrated as modules, build becomes failure.
>
> I understood this behavior is specification/limitation of GPIO interrupt
> function.
> Is it true ?
>

This is a problem of generic-chip.
I created the patch and contributed the point to LKML.
He forgot to put you into CC, sorry.

Please check LKML for subject of "[PATCH] irq: Add EXPORT_SYMBOL to
function of irq generic-chip".

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2011-10-12  4:24     ` Stephen Rothwell
@ 2011-10-12  5:29       ` Tomoya MORINAGA
  2011-10-12  7:21         ` Nobuhiro Iwamatsu
  0 siblings, 1 reply; 103+ messages in thread
From: Tomoya MORINAGA @ 2011-10-12  5:29 UTC (permalink / raw)
  To: Stephen Rothwell, Grant Likely; +Cc: linux-next, linux-kernel, Tomoya MORINAGA

Hi, Stephen

(2011/10/12 13:24), Stephen Rothwell wrote:
> 
> Just try building gpio-pch and gpio-ml-ioh as modules ...
> irq_setup_generic_chip() does not have an EXPORT_SYMBOL (and didn't in
> v3.0 either).
> 

Your report looks like the same as ours.
In our develop environment,
build becomes success only gpio-pch/gpio-ml-ioh is integrated as built-in.
In case of integrated as modules, build becomes failure.

I understood this behavior is specification/limitation of GPIO interrupt
function.
Is it true ?

-- 
tomoya
ROHM Co., Ltd.

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2011-10-11  7:02   ` Tomoya MORINAGA
@ 2011-10-12  4:24     ` Stephen Rothwell
  2011-10-12  5:29       ` Tomoya MORINAGA
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2011-10-12  4:24 UTC (permalink / raw)
  To: Tomoya MORINAGA; +Cc: Grant Likely, linux-next, linux-kernel, Tomoya MORINAGA

[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]

Hi,

On Tue, 11 Oct 2011 16:02:40 +0900 Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com> wrote:
>
> (2011/10/11 15:37), Stephen Rothwell wrote:
> > 
> > On Thu, 6 Oct 2011 14:48:26 +1100 Stephen Rothwell<sfr@canb.auug.org.au>  wrote:
> >>
> >> After merging the gpio tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >>
> >> ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
> >> ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
> >> ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!
> >> ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!
> >>
> >> Presumably caused by commits 54be566317b6 ("gpio-ml-ioh: Support
> >> interrupt function") and 38eb18a6f92d ("gpio-pch: Support interrupt
> >> function").
> >>
> >> I have used the gpio tree from next-20111005 for today.
> > 
> > I am still getting this build failure.
> > 
> I built this driver with success using linux-3.0.
> I want to try to build with the same as your build environment.
> Where can I get your environment ?

Just try building gpio-pch and gpio-ml-ioh as modules ...
irq_setup_generic_chip() does not have an EXPORT_SYMBOL (and didn't in
v3.0 either).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2011-10-11  6:37 ` Stephen Rothwell
@ 2011-10-11  7:02   ` Tomoya MORINAGA
  2011-10-12  4:24     ` Stephen Rothwell
  0 siblings, 1 reply; 103+ messages in thread
From: Tomoya MORINAGA @ 2011-10-11  7:02 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Grant Likely, linux-next, linux-kernel, Tomoya MORINAGA

(2011/10/11 15:37), Stephen Rothwell wrote:
> Hi Grant,
> 
> On Thu, 6 Oct 2011 14:48:26 +1100 Stephen Rothwell<sfr@canb.auug.org.au>  wrote:
>>
>> After merging the gpio tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
>> ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
>> ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!
>> ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!
>>
>> Presumably caused by commits 54be566317b6 ("gpio-ml-ioh: Support
>> interrupt function") and 38eb18a6f92d ("gpio-pch: Support interrupt
>> function").
>>
>> I have used the gpio tree from next-20111005 for today.
> 
> I am still getting this build failure.
> 
I built this driver with success using linux-3.0.
I want to try to build with the same as your build environment.
Where can I get your environment ?

Thanks,
-- 
tomoya
ROHM Co., Ltd.

^ permalink raw reply	[flat|nested] 103+ messages in thread

* Re: linux-next: build failure after merge of the gpio tree
  2011-10-06  3:48 Stephen Rothwell
@ 2011-10-11  6:37 ` Stephen Rothwell
  2011-10-11  7:02   ` Tomoya MORINAGA
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2011-10-11  6:37 UTC (permalink / raw)
  To: Grant Likely; +Cc: linux-next, linux-kernel, Tomoya MORINAGA

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

Hi Grant,

On Thu, 6 Oct 2011 14:48:26 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
> ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
> ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!
> ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!
> 
> Presumably caused by commits 54be566317b6 ("gpio-ml-ioh: Support
> interrupt function") and 38eb18a6f92d ("gpio-pch: Support interrupt
> function").
> 
> I have used the gpio tree from next-20111005 for today.

I am still getting this build failure.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

* linux-next: build failure after merge of the gpio tree
@ 2011-10-06  3:48 Stephen Rothwell
  2011-10-11  6:37 ` Stephen Rothwell
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2011-10-06  3:48 UTC (permalink / raw)
  To: Grant Likely; +Cc: linux-next, linux-kernel, Tomoya MORINAGA

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

Hi Grant,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!
ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!

Presumably caused by commits 54be566317b6 ("gpio-ml-ioh: Support
interrupt function") and 38eb18a6f92d ("gpio-pch: Support interrupt
function").

I have used the gpio tree from next-20111005 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

end of thread, other threads:[~2020-11-18  7:51 UTC | newest]

Thread overview: 103+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-01  4:19 linux-next: build failure after merge of the gpio tree Stephen Rothwell
2020-04-01  7:49 ` Geert Uytterhoeven
2020-04-01  7:57   ` Stephen Rothwell
2020-04-01  8:18   ` Linus Walleij
2020-04-01  8:24     ` Geert Uytterhoeven
2020-04-01 12:29       ` Andy Shevchenko
2020-04-01 12:30         ` Andy Shevchenko
2020-04-01  8:19 ` Linus Walleij
  -- strict thread matches above, loose matches on Subject: below --
2020-11-18  3:30 Stephen Rothwell
2020-11-18  7:50 ` Linus Walleij
2020-03-30  7:58 Stephen Rothwell
2020-03-30  6:11 Stephen Rothwell
2019-08-16 11:38 Stephen Rothwell
2019-08-16 22:25 ` Linus Walleij
2018-12-17  8:24 Stephen Rothwell
2018-12-10  7:00 Stephen Rothwell
2017-11-02  5:20 Stephen Rothwell
2017-11-02  5:33 ` Masahiro Yamada
2017-11-03  7:50 ` Linus Walleij
2017-11-03  8:13   ` Stephen Rothwell
2017-11-03 21:40     ` Linus Walleij
2017-11-13 11:33 ` Stephen Rothwell
2017-11-13 13:40   ` Masahiro Yamada
2017-06-21  6:09 Stephen Rothwell
2017-06-21  6:12 ` Jisheng Zhang
2017-06-21  7:41 ` Linus Walleij
2017-05-29  5:39 Stephen Rothwell
2017-05-29  8:11 ` Linus Walleij
2017-02-08  5:11 Stephen Rothwell
2017-02-08  8:48 ` Lee Jones
2017-02-08  9:05   ` Boris Brezillon
2017-02-08 10:30   ` Stephen Rothwell
2017-02-13 15:18 ` Linus Walleij
2016-09-09  4:36 Stephen Rothwell
2016-09-12 13:27 ` Linus Walleij
2016-04-18  4:10 Stephen Rothwell
2016-03-31  2:22 Stephen Rothwell
2016-03-31  7:52 ` Linus Walleij
2016-02-16  3:48 Stephen Rothwell
2016-02-16 14:47 ` Linus Walleij
2016-01-29  1:45 Stephen Rothwell
2016-02-04  2:16 ` Stephen Rothwell
2016-02-08 17:36   ` Linus Walleij
2015-12-22  5:42 Stephen Rothwell
2015-12-22  6:57 ` Robert Jarzmik
2015-12-22  9:08   ` Linus Walleij
2015-12-22 20:10     ` Stephen Rothwell
2015-12-22 23:58       ` Linus Walleij
2015-12-23  0:20         ` Stephen Rothwell
2015-12-16  3:37 Stephen Rothwell
2015-12-16  3:55 ` Yendapally Reddy Dhananjaya Reddy
2015-12-21  5:02 ` Stephen Rothwell
2015-12-21  8:46   ` Linus Walleij
2015-12-02 23:38 Mark Brown
2015-08-31  6:40 Stephen Rothwell
2015-08-31  6:49 ` Linus Walleij
2015-08-18  6:57 Stephen Rothwell
2015-08-18 12:00 ` Linus Walleij
2015-08-18 12:23   ` Uwe Kleine-König
2015-08-18 13:35     ` Mauro Carvalho Chehab
2015-08-12  8:10 Stephen Rothwell
2015-08-12  8:21 ` Uwe Kleine-König
2015-08-12 12:27   ` Stephen Rothwell
2015-08-12 15:03     ` Stephen Rothwell
2015-08-12 20:16 ` Uwe Kleine-König
2015-08-12 23:02   ` Stephen Rothwell
2015-08-13  0:19     ` Chanwoo Choi
2015-08-13  0:50       ` Stephen Rothwell
2015-08-12  6:59 Stephen Rothwell
2015-08-10  5:07 Stephen Rothwell
2015-08-10  5:46 ` Dmitry Torokhov
2015-08-10 22:51   ` Stephen Rothwell
2015-07-21  3:29 Stephen Rothwell
2015-05-13  6:55 Stephen Rothwell
2015-05-13  7:04 ` Alexandre Courbot
2015-05-13  7:36 ` Johan Hovold
2015-04-10  9:08 Stephen Rothwell
2015-04-10  9:35 ` Linus Walleij
2014-07-29  8:31 Stephen Rothwell
2014-07-29  8:42 ` Thierry Reding
2014-08-04  4:10   ` Alexandre Courbot
2014-08-04  4:28     ` Stephen Rothwell
2014-05-14  7:13 Stephen Rothwell
2014-05-16 15:54 ` Linus Walleij
2014-01-20  5:42 Stephen Rothwell
2013-09-18  3:12 Stephen Rothwell
2013-09-18 11:24 ` Linus Walleij
2013-03-04  1:45 Stephen Rothwell
2013-03-04  2:30 ` Linus Walleij
2013-03-04  2:32 ` Grant Likely
2012-02-03  2:54 Stephen Rothwell
2012-02-03 23:18 ` Grant Likely
2012-02-04 12:10   ` Mark Brown
2011-10-06  3:48 Stephen Rothwell
2011-10-11  6:37 ` Stephen Rothwell
2011-10-11  7:02   ` Tomoya MORINAGA
2011-10-12  4:24     ` Stephen Rothwell
2011-10-12  5:29       ` Tomoya MORINAGA
2011-10-12  7:21         ` Nobuhiro Iwamatsu
2011-10-12  8:37           ` Tomoya MORINAGA
2011-10-13  3:57             ` Grant Likely
2011-10-13  8:22               ` Tomoya MORINAGA
2011-10-13 17:31                 ` Grant Likely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).