From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A6F6C433E9 for ; Thu, 4 Mar 2021 10:34:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D40564F37 for ; Thu, 4 Mar 2021 10:34:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238741AbhCDKeL (ORCPT ); Thu, 4 Mar 2021 05:34:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235607AbhCDKd7 (ORCPT ); Thu, 4 Mar 2021 05:33:59 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24C60C061574; Thu, 4 Mar 2021 02:33:19 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id u12so6601600pjr.2; Thu, 04 Mar 2021 02:33:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=DbTGwtwN+3FwBHptevJXZkE1kRcgS++9qmkLPqlJEgM=; b=DEMEpGAJ8h04MK/Ux5i21+AZZ4hE66NtW86NckRm18a0lCmN3Ib9iR7vc29mpZlQEp 6snIV33kEKDq/gumlRe6dbRFX7pv93WLSXjPvlEj8OciNFSSKhtoMsTstJKZlzAPbXys PM/z6Mgq0atzVfBcxMP4x10J4Re2LX78ZLtKRGxNHvfhBYFkFeWdaHD2w5AcN0893q5U SM3MZvQvOVms5NGjx3fyte8bdTpRtnFGjl3HcyCoIvXLMleqNmKMvxIvOOdGqKS7O1yh 5xeyY7+XJygG2taB12Cm51CMCdHCbBLorZ03tHtWQ+oXsjD/+EOU5jXN64dv5ufw0gQv 4Nhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DbTGwtwN+3FwBHptevJXZkE1kRcgS++9qmkLPqlJEgM=; b=rD8egkSv5lZ4kNoL4uBh+rZ4wwHND51GMmLTlklYPRBqfCcc6BbCouMPZXaf8VsUx9 zcP0HPPAKowniVi3MvP8zzsBVNWdqfPgPMfh/p4YKQlKfZqxw8cXl3BBcSaT6QMxvntr xTCxi7PMzPN+K0m0fBfG/G5lMu9je7Cj543PzjLa7FR50E73BcUTYTIg37ESLWZ62bJw SqTgL7z3if+0OVRQeuEEqZHhFaAyo53hCrwMaEhnPN2B9mvdcTrqnjZQcWjGbcyHofat 75Bizpa1JSZOQ1JmQ3d3HqhjKrdBxHsY34R4q5rCMttFOQiLafxP6LudE2ak8sjDoCAr Uoog== X-Gm-Message-State: AOAM532WqOr6JpM50CFmwL3W7mzg6TGEFAwQlmkLA9sPkxO6vinIYsZL 3OARCLFaKTJO8OvNvw9Dv+W6eddlzDlAkFNfbJg= X-Google-Smtp-Source: ABdhPJxNQSj0S3iGBlwnK8egDCqTMJ+MAyl7DDSfnL4kOfExCG5mu9h72f+jq68lZPe/6mS1ajKMEMejq2LS/diUXJ8= X-Received: by 2002:a17:90a:4586:: with SMTP id v6mr2220656pjg.129.1614853998595; Thu, 04 Mar 2021 02:33:18 -0800 (PST) MIME-Version: 1.0 References: <20210304085710.7128-1-noltari@gmail.com> <20210304085710.7128-2-noltari@gmail.com> In-Reply-To: <20210304085710.7128-2-noltari@gmail.com> From: Andy Shevchenko Date: Thu, 4 Mar 2021 12:33:02 +0200 Message-ID: Subject: Re: [PATCH v4 01/15] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= Cc: Linus Walleij , Rob Herring , Michael Walle , Bartosz Golaszewski , Florian Fainelli , bcm-kernel-feedback-list , Jonas Gorski , Necip Fazil Yildiran , "open list:GPIO SUBSYSTEM" , devicetree , Linux Kernel Mailing List , linux-arm Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 4, 2021 at 10:57 AM =C3=81lvaro Fern=C3=A1ndez Rojas wrote: > > The current code doesn't check if GPIOLIB_IRQCHIP is enabled, which resul= ts in > a compilation error when trying to build gpio-regmap if CONFIG_GPIOLIB_IR= QCHIP > isn't enabled. Suggested-by: ? > Fixes: 6a45b0e2589f ("gpiolib: Introduce gpiochip_irqchip_add_domain()") > Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas > --- > v4: add patch (fix include instead of gpio-regmap.c) > > include/linux/gpio/driver.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h > index 286de0520574..ecf0032a0995 100644 > --- a/include/linux/gpio/driver.h > +++ b/include/linux/gpio/driver.h > @@ -624,8 +624,17 @@ void gpiochip_irq_domain_deactivate(struct irq_domai= n *domain, > bool gpiochip_irqchip_irq_valid(const struct gpio_chip *gc, > unsigned int offset); > > +#ifdef CONFIG_GPIOLIB_IRQCHIP > int gpiochip_irqchip_add_domain(struct gpio_chip *gc, > struct irq_domain *domain); > +#else > +static inline int gpiochip_irqchip_add_domain(struct gpio_chip *gc, > + struct irq_domain *domain) > +{ > + WARN_ON(1); > + return -EINVAL; > +} > +#endif > > int gpiochip_generic_request(struct gpio_chip *gc, unsigned int offset); > void gpiochip_generic_free(struct gpio_chip *gc, unsigned int offset); > -- > 2.20.1 > --=20 With Best Regards, Andy Shevchenko