From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Calvin Johnson <calvin.johnson@oss.nxp.com>
Cc: linux.cj@gmail.com, Jeremy Linton <jeremy.linton@arm.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Madalin Bucur <madalin.bucur@oss.nxp.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Diana Madalina Craciun <diana.craciun@nxp.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Pankaj Bansal <pankaj.bansal@nxp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>, Varun Sethi <V.Sethi@nxp.com>,
Marcin Wojtas <mw@semihalf.com>,
Makarand Pawagi <makarand.pawagi@nxp.com>,
"Rajesh V . Bikkina" <rajesh.bikkina@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [net-next PATCH v1 2/2] phylink: introduce phylink_fwnode_phy_connect()
Date: Fri, 24 Apr 2020 12:56:37 +0300 [thread overview]
Message-ID: <CAHp75Vftq3OEEC5DfW8CgV4yQKZ3doD-r6khXxgn0oOmrLnLkA@mail.gmail.com> (raw)
In-Reply-To: <20200424031617.24033-3-calvin.johnson@oss.nxp.com>
On Fri, Apr 24, 2020 at 6:17 AM Calvin Johnson
<calvin.johnson@oss.nxp.com> wrote:
>
> Define phylink_fwnode_phy_connect() to connect phy specified by
> a fwnode to a phylink instance. This function will handle both
> DT and ACPI nodes.
> #include <linux/spinlock.h>
> #include <linux/timer.h>
> #include <linux/workqueue.h>
> +#include <linux/acpi.h>
Looks like broken order.
> + if (is_of_node(fwnode)) {
> + } else if (is_acpi_node(fwnode)) {
> + }
I'm wondering if there is an API that allows you to drop all this
stuff. In property provider agnostic code we really don't want to see
this.
> + if (!phy_dev)
> + return -ENODEV;
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-04-24 9:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 3:16 [net-next PATCH v1 0/2] Introduce new APIs to support phylink and phy layers Calvin Johnson
2020-04-24 3:16 ` [net-next PATCH v1 1/2] device property: Introduce fwnode_phy_find_device() Calvin Johnson
2020-04-24 3:45 ` Florian Fainelli
2020-04-24 9:26 ` Calvin Johnson
2020-04-24 9:34 ` Greg Kroah-Hartman
2020-04-24 9:54 ` Andy Shevchenko
2020-04-24 13:41 ` Calvin Johnson
2020-04-24 10:04 ` Heikki Krogerus
2020-04-24 3:16 ` [net-next PATCH v1 2/2] phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson
2020-04-24 9:56 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vftq3OEEC5DfW8CgV4yQKZ3doD-r6khXxgn0oOmrLnLkA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=V.Sethi@nxp.com \
--cc=andrew@lunn.ch \
--cc=calvin.johnson@oss.nxp.com \
--cc=cristian.sovaiala@nxp.com \
--cc=davem@davemloft.net \
--cc=diana.craciun@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=florinlaurentiu.chiculita@nxp.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=makarand.pawagi@nxp.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pankaj.bansal@nxp.com \
--cc=rajesh.bikkina@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).