From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] test_hexdump: Replace strncpy with memcpy
Date: Thu, 5 Jul 2018 00:23:26 +0300 [thread overview]
Message-ID: <CAHp75VfvuMgH40Fq0A94gZGF5buf5yDKUEckMhnSnbvyb4S5xw@mail.gmail.com> (raw)
In-Reply-To: <1530478650-20922-1-git-send-email-linux@roeck-us.net>
On Sun, Jul 1, 2018 at 11:57 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> gcc 8.1.0 complains:
>
> lib/test_hexdump.c:84:3: warning:
> 'strncpy' output truncated before terminating
> nul copying as many bytes from a string as its length
> lib/test_hexdump.c:82:19: note: length computed here
>
> Using strncpy() is indeed less than perfect since the length of data to
> be copied has already been determined with strlen(). Replace strncpy()
> with memcpy() to address the warning and optimize the code a little.
>
If it helps for some reason I'm not objecting to switch to memcpy().
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> lib/test_hexdump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c
> index 3f415d8101f3..1c3c513add77 100644
> --- a/lib/test_hexdump.c
> +++ b/lib/test_hexdump.c
> @@ -81,7 +81,7 @@ static void __init test_hexdump_prepare_test(size_t len, int rowsize,
> const char *q = *result++;
> size_t amount = strlen(q);
>
> - strncpy(p, q, amount);
> + memcpy(p, q, amount);
> p += amount;
>
> *p++ = ' ';
> --
> 2.7.4
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2018-07-04 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-01 20:57 [PATCH] test_hexdump: Replace strncpy with memcpy Guenter Roeck
2018-07-04 21:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfvuMgH40Fq0A94gZGF5buf5yDKUEckMhnSnbvyb4S5xw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).