From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750794AbdE0R3h (ORCPT ); Sat, 27 May 2017 13:29:37 -0400 Received: from mail-qk0-f174.google.com ([209.85.220.174]:36828 "EHLO mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbdE0R3f (ORCPT ); Sat, 27 May 2017 13:29:35 -0400 MIME-Version: 1.0 In-Reply-To: <1495701227-28809-7-git-send-email-brgl@bgdev.pl> References: <1495701227-28809-1-git-send-email-brgl@bgdev.pl> <1495701227-28809-7-git-send-email-brgl@bgdev.pl> From: Andy Shevchenko Date: Sat, 27 May 2017 20:29:33 +0300 Message-ID: Subject: Re: [PATCH 06/10] gpio: mockup: refuse to accept an odd number of GPIO ranges To: Bartosz Golaszewski Cc: Linus Walleij , Alexandre Courbot , Bamvor Jian Zhang , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 25, 2017 at 11:33 AM, Bartosz Golaszewski wrote: > Currently we ignore the last odd range value, since each chip is > described by two values. Be more strict and require the user to > pass an even number of ranges. > - if (gpio_mockup_params_nr < 2) > + if (gpio_mockup_params_nr < 2 || (gpio_mockup_params_nr % 2)) if (((gpio_mockup_params_nr + 1) & ~3) < 3) 3 might have a suffix regarding to the type of variable. -- With Best Regards, Andy Shevchenko