From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: trix@redhat.com
Cc: Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
tomasz.figa@gmail.com, s.nawrocki@samsung.com,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc@vger.kernel.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: remove unneeded break
Date: Mon, 19 Oct 2020 22:22:08 +0300 [thread overview]
Message-ID: <CAHp75VfwQB4hnDpk9uo2heWqNc2iv4AVZay4EacznY+why7nZQ@mail.gmail.com> (raw)
In-Reply-To: <20201019190055.7371-1-trix@redhat.com>
On Mon, Oct 19, 2020 at 10:04 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
When it's a single driver, use the proper prefix in the Subject line.
Also use proper English punctuation, i.e. period at the end of commit message.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> index 5e24838a582f..2223ead5bd72 100644
> --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> @@ -108,19 +108,14 @@ static int s3c24xx_eint_get_trigger(unsigned int type)
> switch (type) {
> case IRQ_TYPE_EDGE_RISING:
> return EINT_EDGE_RISING;
> - break;
> case IRQ_TYPE_EDGE_FALLING:
> return EINT_EDGE_FALLING;
> - break;
> case IRQ_TYPE_EDGE_BOTH:
> return EINT_EDGE_BOTH;
> - break;
> case IRQ_TYPE_LEVEL_HIGH:
> return EINT_LEVEL_HIGH;
> - break;
> case IRQ_TYPE_LEVEL_LOW:
> return EINT_LEVEL_LOW;
> - break;
> default:
> return -EINVAL;
> }
> --
> 2.18.1
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-10-19 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 19:00 [PATCH] pinctrl: remove unneeded break trix
2020-10-19 19:22 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfwQB4hnDpk9uo2heWqNc2iv4AVZay4EacznY+why7nZQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).