From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C35B0C43457 for ; Wed, 14 Oct 2020 17:13:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F8802173E for ; Wed, 14 Oct 2020 17:13:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NgMprzvA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732029AbgJNRNc (ORCPT ); Wed, 14 Oct 2020 13:13:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727162AbgJNRNc (ORCPT ); Wed, 14 Oct 2020 13:13:32 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 455D5C061755; Wed, 14 Oct 2020 10:13:32 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id r10so19726pgb.10; Wed, 14 Oct 2020 10:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6uo0zZpvzDaSDdtJhTUWqOqljbE66RmGZ5TF4JiXQbs=; b=NgMprzvA3pyrmzjyu6aqJz6i63CdTgW4HgryJA4IoO6JaMJAvfohuBk9B5gzIwZuKF WKVtfAUZ2J3KMq8u8QS1rPERmLAV1whI8XZnO7PmvHFxvc9HBIA3tk5GypHif5aFN9pj ma3p04RPnlBerUQl0NZYSql+u0vZienklGMcMV+1YTyS0PnB2rhKWCixwl/oI447/0az pYHTQ/7A1JWsQdy+HaeDlkCHa0e4YYf9+iIksWlUA3AHsjsYtw8IFuHt/41o4NHuVx+4 6BUVuhqP8CPKbqAiJYcPPsXLcRPyHaaQRsRjeBVdhS5gBCAsybCxaHxZVG7xKveCgTdE yrUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6uo0zZpvzDaSDdtJhTUWqOqljbE66RmGZ5TF4JiXQbs=; b=eq2CVz42rPfYOtSNvEt/hEzgaKFkGqNbcct3wnOX4pxIXf60eFpnjxBnkxdGTJvoPj BwvIBMMSY1ywO5v0tiusLuoOSD8C9vUFGU7Wsk4GDJLlYP4KsEOrbbTi1Ybs6yRHCAl4 8nQ0veOCsn2l+gFT/SIS83PkQsjhaKap8j3iBgzgDeD1Z827+qYVjNPpsX8N8YKrGihC 9S4VZ9nXs/NSo2X1lY7emEH9pw7CkA/eMHxn3szqmincGxw/tks6dSUmSaDepWcUIdop PIPZ9HI/xrkQRUK03l1BK424HwPDTBzKfRxHLQn1aZNuzsEpYgWEng034WzzWjnOhe/Y RtfQ== X-Gm-Message-State: AOAM533QgugEc50Tu/niSlxIH3kZkppYemifQcP15qg0VwuPF0KqMMRS Mi9T8qkcEEE0YhkfO+eft+FVIDLqBbYOgPLhitE= X-Google-Smtp-Source: ABdhPJxQ7kvfm3lLhbpiPFW6Qynyw1p5YmPMm/QgaNYKlFnjI4Bozg99wlTZFKaJzaXZ+63YaffmiGqy+94vIiIMhjo= X-Received: by 2002:a65:47c2:: with SMTP id f2mr43510pgs.4.1602695611776; Wed, 14 Oct 2020 10:13:31 -0700 (PDT) MIME-Version: 1.0 References: <20201005070329.21055-1-warthog618@gmail.com> <20201013132952.GA219958@sol> In-Reply-To: <20201013132952.GA219958@sol> From: Andy Shevchenko Date: Wed, 14 Oct 2020 20:14:20 +0300 Message-ID: Subject: Re: [PATCH 0/5] gpio: uapi: documentation improvements To: Kent Gibson Cc: Linus Walleij , Bartosz Golaszewski , LKML , linux-gpio Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2020 at 7:34 PM Kent Gibson wrote: > On Tue, Oct 13, 2020 at 03:21:47PM +0200, Linus Walleij wrote: > > On Thu, Oct 8, 2020 at 5:46 PM Bartosz Golaszewski > > wrote: ... > > I am waiting for Kent to respin them addressing Andy's comments > > on patch 5/5 then they can go in as fixes I think. > > > > I had replied to Andy's comments - I'm prefer with my version than his > suggestion: > > "I'm not keen on that alternative as what it suggests is actually a > pointer comparison, and even if the user realizes that they may instead > use "strlen(label) == 0", when they shouldn't be assuming that a null > terminator is present in the array. I avoided mentioning "string" and > kept it in terms of the char array for the same reason." My point is to make documentation less cryptic (= less programming language stylish). If you can rephrase it that way - nice! Otherwise, I leave this to Linus. -- With Best Regards, Andy Shevchenko