From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: John Garry <john.garry@huawei.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Borislav Petkov <bp@suse.de>, Guenter Roeck <linux@roeck-us.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Linuxarm <linuxarm@huawei.com>, Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH v2 3/3] lib: logic_pio: Make some prints explicitly hex
Date: Sat, 23 Mar 2019 21:12:52 +0200 [thread overview]
Message-ID: <CAHp75VfyU5ZDqCZ55SoxW1pQt1KXZQZJeYixHQf8Kw2EZcXWrQ@mail.gmail.com> (raw)
In-Reply-To: <1553105650-28012-4-git-send-email-john.garry@huawei.com>
On Wed, Mar 20, 2019 at 8:14 PM John Garry <john.garry@huawei.com> wrote:
>
> Some prints in the code are for a hex number, but don't prefix "0x". Add
> the prefix, as is the norm.
> - pr_err("addr %llx not registered in io_range_list\n",
> + pr_err("addr 0x%llx not registered in io_range_list\n",
> (unsigned long long) addr);
Can we use %pa at the same time?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-03-23 19:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 18:14 [PATCH v2 0/3] Fix system crash for accessing unmapped IO port regions John Garry
2019-03-20 18:14 ` [RFC PATCH v2 1/3] resource: Request IO port regions from children of ioport_resource John Garry
2019-03-25 23:32 ` Bjorn Helgaas
2019-03-26 16:33 ` John Garry
2019-03-26 22:48 ` Bjorn Helgaas
2019-03-27 11:24 ` John Garry
2019-03-28 17:46 ` Lorenzo Pieralisi
2019-03-29 10:42 ` John Garry
2019-03-29 12:22 ` Lorenzo Pieralisi
2019-04-02 9:46 ` John Garry
2019-03-20 18:14 ` [PATCH v2 2/3] lib: logic_pio: Reject access to unregistered CPU MMIO regions John Garry
2019-03-23 19:15 ` Andy Shevchenko
2019-03-25 9:59 ` John Garry
2019-03-20 18:14 ` [PATCH v2 3/3] lib: logic_pio: Make some prints explicitly hex John Garry
2019-03-23 19:12 ` Andy Shevchenko [this message]
2019-03-25 9:48 ` John Garry
2019-03-25 15:03 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfyU5ZDqCZ55SoxW1pQt1KXZQZJeYixHQf8Kw2EZcXWrQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=rafael@kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).