From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932553AbcKHUSp (ORCPT <rfc822;w@1wt.eu>);
        Tue, 8 Nov 2016 15:18:45 -0500
Received: from mail-qk0-f195.google.com ([209.85.220.195]:32779 "EHLO
        mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752144AbcKHUSo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 8 Nov 2016 15:18:44 -0500
MIME-Version: 1.0
In-Reply-To: <20161108201114.GQ3117@twins.programming.kicks-ass.net>
References: <1474307267-3081-1-git-send-email-Frank.Li@nxp.com>
 <CAP=VYLo_p3ZmOFcyM9om_31-=5O3ZiRLCBkJDDtj84JxAA7h8Q@mail.gmail.com>
 <CAHrpEqQGRLY7ZB6moP9FZ0w-t63QkyLE1fUb3heRZJfRd2Y9sw@mail.gmail.com> <20161108201114.GQ3117@twins.programming.kicks-ass.net>
From: Zhi Li <lznuaa@gmail.com>
Date: Tue, 8 Nov 2016 14:18:42 -0600
Message-ID: <CAHrpEqSxhsemUFLB1AQ1xAaOZ14jdtsUFiMPyky1i+g7SuuRUg@mail.gmail.com>
Subject: Re: [PATCH 1/1 v7] ARM: imx: Added perf functionality to mmdc driver
To: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
        Frank Li <Frank.Li@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
        acme@kernel.org, alexander.shishkin@linux.intel.com,
        Mark Rutland <mark.rutland@arm.com>,
        jerry shen <jerry.zhengyu.shen@gmail.com>,
        Zhengyu Shen <zhengyu.shen@nxp.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 8, 2016 at 2:11 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, Nov 08, 2016 at 01:21:47PM -0600, Zhi Li wrote:
>> On Tue, Nov 8, 2016 at 1:00 PM, Paul Gortmaker
>> > I just noticed this commit now that linux-next is back after the week off.
>> >
>> > This should probably use core_param or setup_param since the Kconfig
>> > for this is bool and not tristate.
>
>
>> I think pmu_pmu_poll_period_us should be removed because no benefit to
>> change it.
>> I can delete .remove
>
> Why not make it tristate ?

The based code provided a function, which need by suspend and resume.

best regards
Frank Li