From: Binoy Jayan <binoy.jayan@linaro.org>
To: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Masami <masami.hiramatsu@linaro.org>
Subject: Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints
Date: Tue, 30 Aug 2016 17:19:41 +0530 [thread overview]
Message-ID: <CAHv-k_-E8DBC9YCnaNSJbxE22nra-1QLSNC5i5K0oQDTtdZ1Ow@mail.gmail.com> (raw)
In-Reply-To: <fba4d013-5bfa-54af-fa96-483b71964f7c@bmw-carit.de>
Hi Daniel,
On 30 August 2016 at 17:00, Daniel Wagner <daniel.wagner@bmw-carit.de> wrote:
> Hi Binoy,
>
>
> As Masami has pointed out, the prefix trace_ should not be used. Also having
> trace_latency_ and latency_trace_ is kind of confusing. What about
> {start|stop}_latency_timing()? It would match the existing
> {start|stop}_critical_timing(). Or is it too close and it leads to
> confusion?
>
> Another idea is {start|stop}_latency_preempt(). This matches the
> trace_latency_preempt_enable() function.
>
Sure, I'll make this change. And how about the 'cpu' field not being
available to be used
as a key field or as a value field when we do not define it explicitly
(mentioned in the
other email). Can we live with that ?
Thanks,
Binoy
next prev parent reply other threads:[~2016-08-30 11:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 10:28 [PATCH v4 0/3] *** Latency histograms - IRQSOFF,PREEMPTOFF *** Binoy Jayan
2016-08-30 10:28 ` [PATCH v4 1/3] tracing: Deference pointers without RCU checks Binoy Jayan
2016-08-30 10:28 ` [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints Binoy Jayan
2016-08-30 11:30 ` Daniel Wagner
2016-08-30 11:49 ` Binoy Jayan [this message]
2016-08-30 14:08 ` Steven Rostedt
2016-08-31 11:39 ` Binoy Jayan
2016-08-30 10:28 ` [PATCH v4 3/3] tracing: Histogram for missed timer offsets Binoy Jayan
2016-08-30 10:50 ` Masami Hiramatsu
2016-09-02 12:41 ` Binoy Jayan
2016-09-02 15:54 ` Masami Hiramatsu
2016-08-30 14:15 ` Steven Rostedt
2016-08-31 11:34 ` Binoy Jayan
2016-08-31 12:42 ` Steven Rostedt
2016-08-30 11:39 ` [PATCH v4 0/3] *** Latency histograms - IRQSOFF,PREEMPTOFF *** Daniel Wagner
2016-08-30 12:02 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHv-k_-E8DBC9YCnaNSJbxE22nra-1QLSNC5i5K0oQDTtdZ1Ow@mail.gmail.com \
--to=binoy.jayan@linaro.org \
--cc=arnd@arndb.de \
--cc=daniel.wagner@bmw-carit.de \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).