From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933372AbcHaLfA (ORCPT ); Wed, 31 Aug 2016 07:35:00 -0400 Received: from mail-ua0-f181.google.com ([209.85.217.181]:34381 "EHLO mail-ua0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933140AbcHaLe4 (ORCPT ); Wed, 31 Aug 2016 07:34:56 -0400 MIME-Version: 1.0 In-Reply-To: <20160830101527.3acd6ad6@gandalf.local.home> References: <1472552924-22297-1-git-send-email-binoy.jayan@linaro.org> <1472552924-22297-4-git-send-email-binoy.jayan@linaro.org> <20160830101527.3acd6ad6@gandalf.local.home> From: Binoy Jayan Date: Wed, 31 Aug 2016 17:04:54 +0530 Message-ID: Subject: Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets To: Steven Rostedt Cc: Ingo Molnar , Daniel Wagner , Arnd Bergmann , Linux kernel mailing list , Masami Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30 August 2016 at 19:45, Steven Rostedt wrote: > On Tue, 30 Aug 2016 15:58:44 +0530 > Binoy Jayan wrote: > >> + >> + TP_STRUCT__entry( >> + __field(long long, toffset) >> + __array(char, ccomm, TASK_COMM_LEN) > > Can curr be different than current? If not, lets not record it. > > -- Steve > Hi Steve, If my understanding is right, I think both are not the same. The predefined field relates to the current process which was interrupted by the hrtimer. This I guess does not have a meaning in this context. Mostly it is the idle process which is interrupted by the hrtimer. But the ccomm field refers to the task woken up by the process. The latencies are measured for this task. So I it is needed. -Binoy