From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756621AbcHYGdV (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 Aug 2016 02:33:21 -0400
Received: from mail-ua0-f172.google.com ([209.85.217.172]:34956 "EHLO
        mail-ua0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752517AbcHYGdT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 Aug 2016 02:33:19 -0400
MIME-Version: 1.0
In-Reply-To: <2dd1733a-44c8-378e-2807-f27bb0c4f1a7@bmw-carit.de>
References: <1472037450-8907-1-git-send-email-binoy.jayan@linaro.org> <2dd1733a-44c8-378e-2807-f27bb0c4f1a7@bmw-carit.de>
From: Binoy Jayan <binoy.jayan@linaro.org>
Date: Thu, 25 Aug 2016 12:03:18 +0530
Message-ID: <CAHv-k_-v-TQhqyFRM5mt4DQ-pnp6oF=7eN2-4f-zQuLP8+oj=w@mail.gmail.com>
Subject: Re: [PATCH v2 0/3] *** Latency histograms - IRQSOFF,PREEMPTOFF ***
To: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Arnd Bergmann <arnd@arndb.de>, linaro-kernel@lists.linaro.org,
        Carsten Emde <C.Emde@osadl.org>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>,
        "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25 August 2016 at 10:56, Daniel Wagner <daniel.wagner@bmw-carit.de> wrote:
> Hi Binoy,
>
> On 08/24/2016 01:17 PM, Binoy Jayan wrote:
>>
>> Histogram output:
>> cat /sys/kernel/debug/tracing/events/latency/latency_irqs/hist
>> cat /sys/kernel/debug/tracing/events/latency/latency_preempt/hist
>> cat /sys/kernel/debug/tracing/events/latency/latency_critical_timings/hist
>> cat
>> /sys/kernel/debug/tracing/events/latency/latency_hrtimer_interrupt/hist
>
>
> [...]
>
>> Changes from v1 as per comments from Steven/Daniel
>>   - Use single tracepoint for irq/preempt/critical timings by introducing
>>     a trace type field to differentiate trace type in the same tracepoint.
>
>
> Did you send out the right patches? This version still looks like the
> previous one in this regard. And wouldn't be the 'Histogram output' have
> only one file? Maybe I just understood something wrong here.
>
> cheers,
> daniel

Hi Daniel,

This patch is after incorporating changes w.r.t. comments by steven.
And regarding
using one tracepoint, I have mentioned the same in the cover letter. I have sent
you (only) another patch with that change. When I do it like that I
get an RCU error,
the first time the "type" key is used. It is weird that it happens
only for the first time
something is echo-ed to the trigger file. I haven't been able to
figure out why yet.

Binoy