From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D96EC4167B for ; Tue, 13 Dec 2022 17:48:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236181AbiLMRsJ (ORCPT ); Tue, 13 Dec 2022 12:48:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235907AbiLMRsG (ORCPT ); Tue, 13 Dec 2022 12:48:06 -0500 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 402B83898 for ; Tue, 13 Dec 2022 09:48:05 -0800 (PST) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-3c090251d59so203030347b3.4 for ; Tue, 13 Dec 2022 09:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IJk386cPKRY//Y7MO6HtNee/KHa+FUorRyHnWTGhV8A=; b=d08kAh2br1YOFfRW5pF0TrY/ZNTrz9x9nQwRu0RUw++RQFsMqu4i8sLoPRe7BawPGS ESqup7asnlEPOL1zt4LTi5uNfyreYK+f+Et70il6JT+jSudf7izzjiV4EK2fqw5d3W96 OqSb/unEd+7X0hM6R5Pj2XcL+2RpV9p1oYy3ddcverkyTVdNVQ6K3BLlaZU330bhusZM ijGzNA1KUox9BPuGdDQGGWRIR12SaHnOI8Lyg9Zo6V9IC5elwdnT6bEYAAido5K4iXM2 VsxzxbE7YgrIpiHyQzCFWai7WFpK8Gy8o6T+NFNf86CrsjIdLkqGTqgZtH0P3v/iTzb3 d+vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IJk386cPKRY//Y7MO6HtNee/KHa+FUorRyHnWTGhV8A=; b=wiCq+W2p0RyPyrGELxzIFTM3xdooZ/JRV8/rkiKwT101M5DrgvmuhnBWfV6Bo1GxU5 cHN4ozbARH8ItA1yU5aeacxBYvh7nlIsJeDQD5DZVS8U3j8oIcGqFQR+RYKHNpn5zzlt v+fV4yNbQewsBfp9vUZqDWja68tPGdzPgmR1Orq3DgsmChj0VljGQvXhIZLy2XDmscXP 5Fob8Nl8AmFGHvuta0z1ZkxTJbUubmAbPjoM0h8syAunwwb+rr+MGtMwh31q8TqPMEBr KXS5ty9pYe8YP/aqp/QOQzcVhAEyLYP7Oun7zMxlGjuGYfl3LL56EZhvc1CE/NnxUUFj RsMg== X-Gm-Message-State: ANoB5pldy737ONrnKG/UzBoNde4ehkxuSx/2CVOgd26dAb7Gw7TB9No2 iesZgzyT2jSHb1cnNbFdCb+gVx8BsIgQWFM4lWRYQw== X-Google-Smtp-Source: AA0mqf7RoXg62KCh1fzwVblmwOYc9OTRss5iJCbzpnG/aMuvB1Q0/G+e/o2T1TAAdqqmRpocYOU83g3L0k9gaJmAQUw= X-Received: by 2002:a81:8316:0:b0:3d6:1fa3:e402 with SMTP id t22-20020a818316000000b003d61fa3e402mr37201681ywf.167.1670953684414; Tue, 13 Dec 2022 09:48:04 -0800 (PST) MIME-Version: 1.0 References: <20221212180732.79167-1-sudip.mukherjee@sifive.com> <20221212180732.79167-15-sudip.mukherjee@sifive.com> <20221213163209.GA1684072-robh@kernel.org> In-Reply-To: From: Sudip Mukherjee Date: Tue, 13 Dec 2022 17:47:53 +0000 Message-ID: Subject: Re: [PATCH v2 14/15] spi: dt-bindings: snps,dw-ahb-ssi: Add generic dw-ahb-ssi version To: Rob Herring Cc: Serge Semin , Krzysztof Kozlowski , jude.onyenegecha@sifive.com, ben.dooks@sifive.com, jeegar.lakhani@sifive.com, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 13, 2022 at 4:59 PM Mark Brown wrote: > > On Tue, Dec 13, 2022 at 10:32:09AM -0600, Rob Herring wrote: > > On Mon, Dec 12, 2022 at 06:07:31PM +0000, Sudip Mukherjee wrote: > > > > Add new snps,dw-ahb-ssi version to the bindings. > > > Really, this should probably only be a fallback with an SoC specific > > compatible. Future quirk properties which are not board specific only > > will be rejected. You've been warned. > > Given how widely used DesignWare stuff is and usage in FPGAs it does > seem reasonable to have compatibles for just the IP rather than SoC > specific ones - we do have quirked versions that have been modified but > these are things that people manage to deploy without needing that and > SoC specific compatibles for FPGA instantiations would get painful. Also, this patchset adds the autodetect procedure as discussed in the review of the previous series at https://lore.kernel.org/lkml/20220826233116.uulisbo663cxiadt@mobilestation/ So, we should be able to replace "snps,dw-apb-ssi" and "snps,dwc-ssi-1.01a" with "snps,dw-ahb-ssi" after this. And, also this generic compatible has been tested with the new 1.03a version we are working with, which was mentioned in my v1 at https://lore.kernel.org/lkml/20220826233305.5ugpukokzldum7y5@mobilestation/ -- Regards Sudip