From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-mm@kvack.org, open list <linux-kernel@vger.kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Hugh Dickins <hughd@google.com>,
nyc@holomorphy.com, Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
David Herrmann <dh.herrmann@gmail.com>
Subject: Re: [PATCH v3 0/9] memfd: add sealing to hugetlb-backed memory
Date: Wed, 20 Dec 2017 15:15:50 +0100 [thread overview]
Message-ID: <CAJ+F1CJCbmUHSMfKou_LP3eMq+p-b7S9vbe1Vv=JsGMFr7bk_w@mail.gmail.com> (raw)
In-Reply-To: <aca9951c-7b8a-7884-5b31-c505e4e35d8a@oracle.com>
Hi
On Wed, Nov 15, 2017 at 4:13 AM, Mike Kravetz <mike.kravetz@oracle.com> wrote:
> +Cc: Andrew, Michal, David
>
> Are there any other comments on this patch series from Marc-André? Is anything
> else needed to move forward?
>
> I have reviewed the patches in the series. David Herrmann (the original
> memfd_create/file sealing author) has also taken a look at the patches.
>
> One outstanding issue is sorting out the config option dependencies. Although,
> IMO this is not a strict requirement for this series. I have addressed this
> issue in a follow on series:
> http://lkml.kernel.org/r/20171109014109.21077-1-mike.kravetz@oracle.com
Are we good for the next merge window? Is Hugh Dickins the maintainer
with the final word, and doing the pull request? (sorry, I am not very
familiar with kernel development)
thanks!
>> Hi,
>>
>> Recently, Mike Kravetz added hugetlbfs support to memfd. However, he
>> didn't add sealing support. One of the reasons to use memfd is to have
>> shared memory sealing when doing IPC or sharing memory with another
>> process with some extra safety. qemu uses shared memory & hugetables
>> with vhost-user (used by dpdk), so it is reasonable to use memfd
>> now instead for convenience and security reasons.
>>
>> Thanks!
>>
>> v3:
>> - do remaining MFD_DEF_SIZE/mfd_def_size substitutions
>> - fix missing unistd.h include in common.c
>> - tweaked a bit commit message prefixes
>> - added reviewed-by tags
>>
>> v2:
>> - add "memfd-hugetlb:" prefix in memfd-test
>> - run fuse test on hugetlb backend memory
>> - rename function memfd_file_get_seals() -> memfd_file_seals_ptr()
>> - update commit messages
>> - added reviewed-by tags
>>
>> RFC->v1:
>> - split rfc patch, after early review feedback
>> - added patch for memfd-test changes
>> - fix build with hugetlbfs disabled
>> - small code and commit messages improvements
>>
>> Marc-André Lureau (9):
>> shmem: unexport shmem_add_seals()/shmem_get_seals()
>> shmem: rename functions that are memfd-related
>> hugetlb: expose hugetlbfs_inode_info in header
>> hugetlb: implement memfd sealing
>> shmem: add sealing support to hugetlb-backed memfd
>> memfd-test: test hugetlbfs sealing
>> memfd-test: add 'memfd-hugetlb:' prefix when testing hugetlbfs
>> memfd-test: move common code to a shared unit
>> memfd-test: run fuse test on hugetlb backend memory
>>
>> fs/fcntl.c | 2 +-
>> fs/hugetlbfs/inode.c | 39 +++--
>> include/linux/hugetlb.h | 11 ++
>> include/linux/shmem_fs.h | 6 +-
>> mm/shmem.c | 59 ++++---
>> tools/testing/selftests/memfd/Makefile | 5 +
>> tools/testing/selftests/memfd/common.c | 46 ++++++
>> tools/testing/selftests/memfd/common.h | 9 ++
>> tools/testing/selftests/memfd/fuse_test.c | 44 +++--
>> tools/testing/selftests/memfd/memfd_test.c | 212 ++++---------------------
>> tools/testing/selftests/memfd/run_fuse_test.sh | 2 +-
>> tools/testing/selftests/memfd/run_tests.sh | 1 +
>> 12 files changed, 200 insertions(+), 236 deletions(-)
>> create mode 100644 tools/testing/selftests/memfd/common.c
>> create mode 100644 tools/testing/selftests/memfd/common.h
>>
--
Marc-André Lureau
next prev parent reply other threads:[~2017-12-20 14:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 12:27 [PATCH v3 0/9] memfd: add sealing to hugetlb-backed memory Marc-André Lureau
2017-11-07 12:27 ` [PATCH v3 1/9] shmem: unexport shmem_add_seals()/shmem_get_seals() Marc-André Lureau
2017-11-07 12:27 ` [PATCH v3 2/9] shmem: rename functions that are memfd-related Marc-André Lureau
2017-11-07 12:27 ` [PATCH v3 3/9] hugetlb: expose hugetlbfs_inode_info in header Marc-André Lureau
2017-11-07 12:27 ` [PATCH v3 4/9] hugetlb: implement memfd sealing Marc-André Lureau
2017-11-07 12:27 ` [PATCH v3 5/9] shmem: add sealing support to hugetlb-backed memfd Marc-André Lureau
2017-11-07 12:27 ` [PATCH v3 6/9] memfd-test: test hugetlbfs sealing Marc-André Lureau
2017-11-07 12:27 ` [PATCH v3 7/9] memfd-test: add 'memfd-hugetlb:' prefix when testing hugetlbfs Marc-André Lureau
2017-11-07 12:27 ` [PATCH v3 8/9] memfd-test: move common code to a shared unit Marc-André Lureau
2017-11-07 12:28 ` [PATCH v3 9/9] memfd-test: run fuse test on hugetlb backend memory Marc-André Lureau
2017-11-07 21:35 ` Mike Kravetz
2017-11-15 3:13 ` [PATCH v3 0/9] memfd: add sealing to hugetlb-backed memory Mike Kravetz
2017-12-20 14:15 ` Marc-André Lureau [this message]
2017-12-20 15:10 ` Michal Hocko
2017-12-21 0:26 ` Andrew Morton
2017-12-21 0:40 ` Mike Kravetz
2017-12-22 18:30 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+F1CJCbmUHSMfKou_LP3eMq+p-b7S9vbe1Vv=JsGMFr7bk_w@mail.gmail.com' \
--to=marcandre.lureau@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dh.herrmann@gmail.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=nyc@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).