From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E62E5C2BB1D for ; Tue, 17 Mar 2020 17:07:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB25420714 for ; Tue, 17 Mar 2020 17:07:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gateworks-com.20150623.gappssmtp.com header.i=@gateworks-com.20150623.gappssmtp.com header.b="sIqg0Vzx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726851AbgCQRHS (ORCPT ); Tue, 17 Mar 2020 13:07:18 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:39138 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726833AbgCQRHR (ORCPT ); Tue, 17 Mar 2020 13:07:17 -0400 Received: by mail-ot1-f65.google.com with SMTP id r2so7014217otn.6 for ; Tue, 17 Mar 2020 10:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VudPPbgid+IOVvMAP116P9IN7W1PK4r6e92xmQ1xmVM=; b=sIqg0VzxFQwfl+NWdXDi591J6crh9n/XZpMU6biUNq1ohIi87AXY3udpx2XqMHkG9G AmFbSuaTV0n71kWgl2dwunxBA3bdTceAz5Tv6B7qbX+ChY+tJ8rO4aySoZwGR8ugZwWe JletsY23VuybykQ/pY2k6o4WLc9+SMC9quU/Z035kTOMLlD3FORwXXL7orXMI9gJ6bpO 13TIqF+0JAf8hKTlpUgovjbiqHvCPNDR5K49lKbQ3IXF6Pr8vp0reLw6qA3Wz6J39zec we0h7fcwjRIXljWqhkCLie48zTmUzg17Vg16TPXJmn75bDntjrDD60Ilz7aU34a84sKu cUog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VudPPbgid+IOVvMAP116P9IN7W1PK4r6e92xmQ1xmVM=; b=fF4ZjdA9vo5vnRwtqd9SJ3A0ARg3wPMrwReQTd31KXmIdL5FGyv+EC10akHF4nwROH aA2NIuJ2LxLZQXALn3fs5UJrm4fkaDUlEiYkjWA0eYdqLJO/8wRwpoyjzjzUDO2Lu1lu oJbkriTmyEzt0QM3YsmlP6CTZX9YjRFg3UwA7h4oxY0MFaZdu5Pp4PXgSBZ9Uins6xSc U70shUdGigG6k9Hqcy3y7Z43uy/04RwVEizRV8oH8XVrq6ws33wp8uaOibHLRI3x+Kkt EiC6antKV6lG/cg3DA/0KUI8i3Imu56mzTxgXukk8V76ze+2KSivaTzSOpMVIqg3Td3B giDA== X-Gm-Message-State: ANhLgQ0CwB3XXpuZ1iPG8KXaEVOoG+EChrfKJNkFgRJhwb4L9LxwBWwp 17rBboQxrll5VK6DAPzfLXhciLktRNrCk5c+pUhsiw== X-Google-Smtp-Source: ADFU+vu5W+BZZpY/VMpqNkUZ9RU5okoO9lMPTYpCARTmV5yjADrHMwmK0PiXPRTBtmoi8/X9ZZHucwoULMi4fh6GVLk= X-Received: by 2002:a9d:63d2:: with SMTP id e18mr158576otl.277.1584464835611; Tue, 17 Mar 2020 10:07:15 -0700 (PDT) MIME-Version: 1.0 References: <1584464453-28200-1-git-send-email-tharvey@gateworks.com> <1584464453-28200-4-git-send-email-tharvey@gateworks.com> In-Reply-To: From: Tim Harvey Date: Tue, 17 Mar 2020 10:07:04 -0700 Message-ID: Subject: Re: [PATCH v6 3/3] hwmon: add Gateworks System Controller support To: Randy Dunlap Cc: Lee Jones , Jean Delvare , Guenter Roeck , Linux HWMON List , Rob Herring , Frank Rowand , Device Tree Mailing List , open list , Robert Jones Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2020 at 10:03 AM Randy Dunlap wrote: > > On 3/17/20 10:00 AM, Tim Harvey wrote: > > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > > index 23dfe84..99dae13 100644 > > --- a/drivers/hwmon/Kconfig > > +++ b/drivers/hwmon/Kconfig > > @@ -494,6 +494,15 @@ config SENSORS_F75375S > > This driver can also be built as a module. If so, the module > > will be called f75375s. > > > > +config SENSORS_GSC > > + tristate "Gateworks System Controller ADC" > > + depends on MFD_GATEWORKS_GSC > > + help > > + Support for the Gateworks System Controller A/D converters. > > Hi Tim, > Those 4 lines above should be using tabs for indentation. > + 2 spaces on the final "Support" line. Randy, Thanks - can't believe I didn't see that. Checkpatch didn't catch it either. I'll fix for v7. Tim