From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932323AbcHKUs0 (ORCPT ); Thu, 11 Aug 2016 16:48:26 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:35670 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932180AbcHKUsX (ORCPT ); Thu, 11 Aug 2016 16:48:23 -0400 MIME-Version: 1.0 In-Reply-To: <20160811094509.GP9347@sirena.org.uk> References: <1470785767-4426-1-git-send-email-tharvey@gateworks.com> <20160810114140.GJ9347@sirena.org.uk> <20160811094509.GP9347@sirena.org.uk> From: Tim Harvey Date: Thu, 11 Aug 2016 13:48:21 -0700 Message-ID: Subject: Re: [PATCH] regulator: Add LTC3676 support To: Mark Brown Cc: Liam Girdwood , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Jaffer Kapasi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 11, 2016 at 2:45 AM, Mark Brown wrote: > On Wed, Aug 10, 2016 at 05:44:55PM -0700, Tim Harvey wrote: >> On Wed, Aug 10, 2016 at 4:41 AM, Mark Brown wrote: > >> >> +/* LDO1 always on fixed 0.8V-3.3V via scalar via R1/R2 feeback res */ >> >> +static struct regulator_ops ltc3676_fixed_standby_regulator_ops = { >> >> +}; > >> > Remove this, it's pointless. > >> as I'm using macro's to define the ops, removing this ends up breaking >> compilation: > >> do you know of some macro foo to best handle this? Part of me wants to >> ditch the macro's and just simply declare the array of regulators >> directly as its much easier to read/follow. > > Just don't use the macro for that regulator? > Mark, regulators must have a non-null ops field or they will fail registration so I can't just not assign it. What would be an appropriate ops structure for a always-on fixed regulator? Regards, Tim