From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Rajagopal Venkat <rajagopal.venkat@linaro.org>, jonghwa3.lee@samsung.com
Cc: kyungmin.park@samsung.com, mturquette@linaro.org, rjw@sisk.pl,
patches@linaro.org, linaro-dev@lists.linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] PM / devfreq: fix stats start time stamp
Date: Mon, 14 Jan 2013 23:42:14 +0900 [thread overview]
Message-ID: <CAJ0PZbQ1FOk0LMxDCpANqAJ5MOciGy1fvyN__TrEgTGRz-63KA@mail.gmail.com> (raw)
In-Reply-To: <1357624239-13938-2-git-send-email-rajagopal.venkat@linaro.org>
On Tue, Jan 8, 2013 at 2:50 PM, Rajagopal Venkat
<rajagopal.venkat@linaro.org> wrote:
> Mark the stats start time stamp when actual load monitoring is
> started for accuracy.
>
It appears that you are changing the semantics of the information here.
For example, in the case:
- devfreq started at 0 w/ 100MHz
- at 10, devfreq monitor starts w/ 100MHz
- at 20, devfreq updates the freq to 200MHz
- at 30, devfreq is requested to show the stat
The conventional:
20 @ 100MHz / 10 @ 200MHz
You proposed:
10 @ 100MHz / 10 @ 200MHz
Could you please give some reasons why the latter is "more accurate"?
To me, the former seems appropriate.
Cheers,
MyungJoo
> Signed-off-by: Rajagopal Venkat <rajagopal.venkat@linaro.org>
> ---
> drivers/devfreq/devfreq.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 5782c9b..2843a22 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -254,9 +254,12 @@ static void devfreq_monitor(struct work_struct *work)
> void devfreq_monitor_start(struct devfreq *devfreq)
> {
> INIT_DEFERRABLE_WORK(&devfreq->work, devfreq_monitor);
> - if (devfreq->profile->polling_ms)
> + if (devfreq->profile->polling_ms) {
> queue_delayed_work(devfreq_wq, &devfreq->work,
> msecs_to_jiffies(devfreq->profile->polling_ms));
> +
> + devfreq->last_stat_updated = jiffies;
> + }
> }
> EXPORT_SYMBOL(devfreq_monitor_start);
>
> @@ -498,7 +501,6 @@ struct devfreq *devfreq_add_device(struct device *dev,
> devfreq->time_in_state = devm_kzalloc(dev, sizeof(unsigned int) *
> devfreq->profile->max_state,
> GFP_KERNEL);
> - devfreq->last_stat_updated = jiffies;
> devfreq_set_freq_limits(devfreq);
>
> dev_set_name(&devfreq->dev, dev_name(dev));
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
MyungJoo Ham, Ph.D.
Mobile Software Platform Lab, DMC Business, Samsung Electronics
next prev parent reply other threads:[~2013-01-14 14:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 5:50 [PATCH 1/3] PM / devfreq: set min/max freq limit from freq table Rajagopal Venkat
2013-01-08 5:50 ` [PATCH 2/3] PM / devfreq: fix stats start time stamp Rajagopal Venkat
2013-01-14 14:42 ` MyungJoo Ham [this message]
2013-01-15 11:40 ` Rajagopal Venkat
2013-01-08 5:50 ` [PATCH 3/3] PM / devfreq: account suspend/resume for stats Rajagopal Venkat
2013-01-14 14:48 ` MyungJoo Ham
2013-01-15 11:46 ` Rajagopal Venkat
2013-02-04 8:34 ` Rajagopal Venkat
2013-02-05 6:29 ` MyungJoo Ham
2013-01-14 14:36 ` [PATCH 1/3] PM / devfreq: set min/max freq limit from freq table MyungJoo Ham
2013-01-15 11:21 ` Rajagopal Venkat
2013-02-04 8:33 ` Rajagopal Venkat
2013-02-05 6:51 ` MyungJoo Ham
2013-02-05 10:42 ` Rajagopal Venkat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ0PZbQ1FOk0LMxDCpANqAJ5MOciGy1fvyN__TrEgTGRz-63KA@mail.gmail.com \
--to=myungjoo.ham@samsung.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=myungjoo.ham@gmail.com \
--cc=patches@linaro.org \
--cc=rajagopal.venkat@linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).