From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752156AbdGAHvH (ORCPT ); Sat, 1 Jul 2017 03:51:07 -0400 Received: from mail-yb0-f193.google.com ([209.85.213.193]:36524 "EHLO mail-yb0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbdGAHvF (ORCPT ); Sat, 1 Jul 2017 03:51:05 -0400 MIME-Version: 1.0 Reply-To: myungjoo.ham@gmail.com In-Reply-To: <5956057D.3070704@samsung.com> References: <20170630071522.GA20486@embeddedgus> <5956057D.3070704@samsung.com> From: MyungJoo Ham Date: Sat, 1 Jul 2017 16:50:49 +0900 X-Google-Sender-Auth: 3dWQEI5sAdsQNqLGxpSqF6br_uc Message-ID: Subject: Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() To: Chanwoo Choi Cc: "Gustavo A. R. Silva" , Kyungmin Park , Linux PM list , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v617pOP7029654 On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi wrote: > Hi, > > On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote: >> Print and propagate the return value of platform_get_irq on failure. >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/devfreq/rk3399_dmc.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c >> index 40a2499..1b89ebb 100644 >> --- a/drivers/devfreq/rk3399_dmc.c >> +++ b/drivers/devfreq/rk3399_dmc.c >> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) >> >> irq = platform_get_irq(pdev, 0); >> if (irq < 0) { >> - dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n"); >> - return -EINVAL; >> + dev_err(&pdev->dev, >> + "Cannot get the dmc interrupt resource: %d\n", irq); >> + return irq; >> } >> data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL); >> if (!data) >> > > Reviewed-by: Chanwoo Choi Acked-by: MyungJoo Ham > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics -- MyungJoo Ham, Ph.D. S/W Center, Samsung Electronics