From: Alexander Kapshuk <alexander.kapshuk@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Daniel Vetter" <daniel@ffwll.ch>,
"Christian König" <christian.koenig@amd.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-next <linux-next@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Sean Paul" <sean@poorly.run>, "Dave Airlie" <airlied@linux.ie>
Subject: Re: Kernel panic during drm/nouveau init 5.3.0-rc7-next-20190903
Date: Mon, 23 Sep 2019 09:50:41 +0300 [thread overview]
Message-ID: <CAJ1xhMV2ikra9udRhhLLntLxZKO23jLkU=9AeP=denALhw8r_w@mail.gmail.com> (raw)
In-Reply-To: <20190923063803.c7zpqwcqq5f2acq5@sirius.home.kraxel.org>
On Mon, Sep 23, 2019 at 9:38 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> > > 'Git bisect' has identified the following commits as being 'bad'.
> > >
> > > b96f3e7c8069b749a40ca3a33c97835d57dd45d2 is the first bad commit
> > > commit b96f3e7c8069b749a40ca3a33c97835d57dd45d2
> > > Author: Gerd Hoffmann <kraxel@redhat.com>
> > > Date: Mon Aug 5 16:01:10 2019 +0200
> > >
> > > drm/ttm: use gem vma_node
> > >
> > > Drop vma_node from ttm_buffer_object, use the gem struct
> > > (base.vma_node) instead.
> > >
> > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > > Reviewed-by: Christian König <christian.koenig@amd.com>
> > > Link: http://patchwork.freedesktop.org/patch/msgid/20190805140119.7337-9-kraxel@redhat.com
>
> > > Today, I upgraded the kernel to 5.3.0-next-20190919, which booted fine
> > > with no Xorg regressions to report.
> > >
> > > Just wondering if the earlier kernels would not boot for me because of
> > > the changes introduced by the 'bad' commits being perhaps incomplete?
>
> Yes, we had a regression in nouveau, fixed by this patch (in drm-misc-next):
>
> commit 019cbd4a4feb3aa3a917d78e7110e3011bbff6d5
> Author: Thierry Reding <treding@nvidia.com>
> Date: Wed Aug 14 11:00:48 2019 +0200
>
> drm/nouveau: Initialize GEM object before TTM object
>
> TTM assumes that drivers initialize the embedded GEM object before
> calling the ttm_bo_init() function. This is not currently the case
> in the Nouveau driver. Fix this by splitting up nouveau_bo_new()
> into nouveau_bo_alloc() and nouveau_bo_init() so that the GEM can
> be initialized before TTM BO initialization when necessary.
>
> Fixes: b96f3e7c8069 ("drm/ttm: use gem vma_node")
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> Acked-by: Ben Skeggs <bskeggs@redhat.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20190814093524.GA31345@ulmo
>
> HTH,
> Gerd
>
Terrific.
Thanks for the info.
prev parent reply other threads:[~2019-09-23 6:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 9:05 Kernel panic during drm/nouveau init 5.3.0-rc7-next-20190903 Alexander Kapshuk
2019-09-07 10:32 ` Daniel Vetter
2019-09-08 14:13 ` Alexander Kapshuk
2019-09-09 10:11 ` Stephen Rothwell
2019-09-09 10:21 ` Stephen Rothwell
2019-09-09 10:24 ` Alexander Kapshuk
2019-09-13 17:19 ` Daniel Vetter
2019-09-20 19:44 ` Alexander Kapshuk
2019-09-20 19:48 ` Daniel Vetter
2019-09-23 6:38 ` Gerd Hoffmann
2019-09-23 6:50 ` Alexander Kapshuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ1xhMV2ikra9udRhhLLntLxZKO23jLkU=9AeP=denALhw8r_w@mail.gmail.com' \
--to=alexander.kapshuk@gmail.com \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).