From: Alexander Kapshuk <alexander.kapshuk@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fwd: Fwd: [PATCH 01/32] ver_linux: complete awk implementation
Date: Mon, 22 Aug 2016 19:59:35 +0300 [thread overview]
Message-ID: <CAJ1xhMVoTAwhk8_VVhDpDsMdwtPhDiHFw0dhjnFUFJG0-WvV7A@mail.gmail.com> (raw)
In-Reply-To: <20160822100005.GA11170@kroah.com>
On Mon, Aug 22, 2016 at 1:00 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Aug 22, 2016 at 07:14:10AM +0300, Alexander Kapshuk wrote:
>> ---------- Forwarded message ----------
>> From: Alexander Kapshuk <alexander.kapshuk@gmail.com>
>> Date: Sun, Aug 21, 2016 at 5:07 PM
>> Subject: Re: Fwd: [PATCH 01/32] ver_linux: complete awk implementation
>> To: Greg KH <gregkh@linuxfoundation.org>
>>
>>
>> On Sun, Aug 21, 2016 at 11:19 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> >
>> > On Fri, Aug 19, 2016 at 09:12:28PM +0300, Alexander Kapshuk wrote:
>> > > Hello Greg,
>> > >
>> > > This is a follow-up on the series of 'ver_linux' patches I submitted at the end
>> > > of June, proposing a complete rewrite of the script in awk.
>> > >
>> > > So far, I have had feedback from one person, and I just wanted to get some
>> > > feedback from yourself too.
>> > >
>> > > I do appreciate the fact that you have other more pressing matters to attend to
>> > > at the moment, so there is no rush.
>> > >
>> > > I would appreciate hearing from you about my patches at your convenience.
>> >
>> > Last I saw, your patch series broke the build in the beginning and then
>> > fixed it up at the end, right?
>> >
>> > All patches have to never break the build, or functionality, at every
>> > step of the way.
>> >
>> > Sorry, it's a pain, but that's how the Linux kernel development model
>> > works.
>> >
>> > thanks,
>> >
>> > greg k-h
>>
>>
>> Thanks for your feedback and for clarifying how the Linux kernel
>> development model works.
>>
>> Which of the two avenues presented below would you recommend taking?
>>
>> (1). Submit a complete rewrite in awk as a single patch, to satisfy
>> the kernel development model requirements;
>> (2). Submit individual patches with repeating pieces of code
>> implemented as shell functions;
>>
>> While my personal preference lies with option (1), I am willing to go
>> ahead with option (2), should the community prefer the shell
>> implementation over the awk one.
>
> I think 1 might be good, but do it in 3 patches:
> - add new file scripts/ver_linux.awk
> - delete scripts/ver_linux
> - rename scripts/ver_linux.awk to scripts/ver_linux
>
> the first one people can review, the second no one cares about, and the
> third you can generate with the '-M' option to git format-patch so it
> shows up as nothing at all.
>
> Yes, for one patch there will not be the script, but I think we can live
> with that :)
>
> Sound better?
>
> thanks,
>
> greg k-h
Heaps better. Thanks.
prev parent reply other threads:[~2016-08-22 17:00 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 10:18 [PATCH 01/32] ver_linux: complete awk implementation Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 02/32] ver_linux: assign the usage message to a variable and print it Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 03/32] ver_linux: execute 'uname -a' from awk Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 04/32] ver_linux: wrap up call to 'gcc -dumpversion' in awk function Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 05/32] ver_linux: wrap up call to 'make --version' " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 06/32] ver_linux: wrap up call to 'ld -v' " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 07/32] ver_linux: wrap up call to 'mount --version' " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 08/32] ver_linux: wrap up call to 'depmod -V' " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 09/32] ver_linux: wrap up call to 'tune2fs' " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 10/32] ver_linux: wrap up call to 'fsck.jfs -V' " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 11/32] ver_linux: wrap up call to 'reiserfsck " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 12/32] ver_linux: wrap up call to 'fsck.reiser4 " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 13/32] ver_linux: wrap up call to 'xfs_db " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 14/32] ver_linux: wrap up call to 'pccardctl " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 15/32] ver_linux: wrap up call to 'cardmgr " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 16/32] ver_linux: wrap up call to 'quota " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 17/32] ver_linux: wrap up call to 'pppd --version' " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 18/32] ver_linux: wrap up call to 'isdnctrl' " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 19/32] ver_linux: wrap up call to 'showmount --version' " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 20/32] ver_linux: wrap up querying for version of 'Linux C Library' " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 21/32] ver_linux: wrap up call to 'ldd --version' " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 22/32] ver_linux: wrap up querying for version of 'Linux C++ Library' in awk functions Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 23/32] ver_linux: wrap up call to 'ps --version' in awk function Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 24/32] ver_linux: wrap up call to 'ifconfig " Alexander Kapshuk
2016-06-28 10:18 ` [PATCH 25/32] ver_linux: wrap up call to 'loadkeys -V' " Alexander Kapshuk
2016-06-28 10:19 ` [PATCH 26/32] ver_linux: wrap up call to 'oprofiled --version' " Alexander Kapshuk
2016-06-28 10:19 ` [PATCH 27/32] ver_linux: wrap up call to 'expr --v' " Alexander Kapshuk
2016-06-28 10:19 ` [PATCH 28/32] ver_linux: wrap up call to 'udevadm --version' " Alexander Kapshuk
2016-06-28 10:19 ` [PATCH 29/32] ver_linux: wrap up call to 'iwconfig " Alexander Kapshuk
2016-06-28 10:19 ` [PATCH 30/32] ver_linux: build a list of kernel modules as a string and print it Alexander Kapshuk
2016-06-28 10:19 ` [PATCH 31/32] ver_linux: 'version()' function definition Alexander Kapshuk
2016-06-28 10:19 ` [PATCH 32/32] ver_linux: 'printversion()' " Alexander Kapshuk
2016-06-28 12:47 ` Valdis.Kletnieks
2016-06-28 14:40 ` Alexander Kapshuk
2016-06-28 14:48 ` Valdis.Kletnieks
2016-07-02 7:29 ` Alexander Kapshuk
[not found] ` <CAJ1xhMX3=tr3=EuFHjU6oiFTNrW5M2K32hEodBq_MrVtbKZB4g@mail.gmail.com>
[not found] ` <20160821081931.GA14367@kroah.com>
[not found] ` <CAJ1xhMWea18Jo_Xk5aDn3uy=uF_cwdC8eYo_mUMPLWvNH+jX9Q@mail.gmail.com>
2016-08-22 4:14 ` Fwd: Fwd: [PATCH 01/32] ver_linux: complete awk implementation Alexander Kapshuk
2016-08-22 10:00 ` Greg KH
2016-08-22 16:59 ` Alexander Kapshuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ1xhMVoTAwhk8_VVhDpDsMdwtPhDiHFw0dhjnFUFJG0-WvV7A@mail.gmail.com \
--to=alexander.kapshuk@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).