From: "Christian Göttsche" <cgzones@googlemail.com>
To: Paul Moore <paul@paul-moore.com>
Cc: "Casey Schaufler" <casey@schaufler-ca.com>,
"SElinux list" <selinux@vger.kernel.org>,
"James Morris" <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Xin Long" <lucien.xin@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Ondrej Mosnacek" <omosnace@redhat.com>,
"Mickaël Salaün" <mic@linux.microsoft.com>,
"Todd Kjos" <tkjos@google.com>,
"Olga Kornievskaia" <kolga@netapp.com>,
"Linux kernel mailing list" <linux-kernel@vger.kernel.org>,
linux-security-module@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] security: declare member holding string literal const
Date: Fri, 13 May 2022 19:16:36 +0200 [thread overview]
Message-ID: <CAJ2a_Ddy8Kkp6SHxktguSQ4WqHwpA=zrQUz8UYkajF5-YtPerw@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhR-Xk65iSfZxVvaK+mJoFszxT2E8vF=cus1aAKcB0EgYg@mail.gmail.com>
On Tue, 3 May 2022 at 22:02, Paul Moore <paul@paul-moore.com> wrote:
>
> On Mon, May 2, 2022 at 9:38 AM Christian Göttsche
> <cgzones@googlemail.com> wrote:
> > On Thu, 17 Feb 2022 at 23:50, Casey Schaufler <casey@schaufler-ca.com> wrote:
> > > On 2/17/2022 6:18 AM, Christian Göttsche wrote:
> > > > The struct security_hook_list member lsm is assigned in
> > > > security_add_hooks() with string literals passed from the individual
> > > > security modules. Declare the function parameter and the struct member
> > > > const to signal their immutability.
> > > >
> > > > Reported by Clang [-Wwrite-strings]:
> > > >
> > > > security/selinux/hooks.c:7388:63: error: passing 'const char [8]' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> > > > security_add_hooks(selinux_hooks, ARRAY_SIZE(selinux_hooks), selinux);
> > > > ^~~~~~~~~
> > > > ./include/linux/lsm_hooks.h:1629:11: note: passing argument to parameter 'lsm' here
> > > > char *lsm);
> > > > ^
> > > >
> > > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> > >
> > > Reviewed-by: Casey Schaufler <casey@schaufler-ca.com>
> > >
> >
> > Kindly ping;
> > any progress on this one?
>
> I've already added my Reviewed-by tag, as has Casey, so I think it's
> pretty "safe" at this point. The next step is for James to pull this
> into the LSM tree. If it is still collecting dust at the end of this
> week, ping us again and I can just go ahead and pull it into the
> SELinux tree, it's small enough that it shouldn't cause any problems.
end-of-the-week-ping
>
> --
> paul-moore.com
next prev parent reply other threads:[~2022-05-13 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 14:18 [PATCH] security: declare member holding string literal const Christian Göttsche
2022-02-17 22:27 ` Paul Moore
2022-02-17 22:50 ` Casey Schaufler
2022-05-02 13:38 ` Christian Göttsche
2022-05-03 20:02 ` Paul Moore
2022-05-13 17:16 ` Christian Göttsche [this message]
2022-05-13 18:55 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ2a_Ddy8Kkp6SHxktguSQ4WqHwpA=zrQUz8UYkajF5-YtPerw@mail.gmail.com' \
--to=cgzones@googlemail.com \
--cc=casey@schaufler-ca.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kolga@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=lucien.xin@gmail.com \
--cc=mic@linux.microsoft.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).