From: Rayagond Kokatanur <rayagond@vayavyalabs.com>
To: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Cc: netdev <netdev@vger.kernel.org>,
alexandre.torgue@st.com,
Richard Cochran <richardcochran@gmail.com>,
linux-kernel@vger.kernel.org, seraphin.bonnaffe@st.com
Subject: Re: [PATCH (net.git) 2/3] stmmac: fix PTP support for GMAC4
Date: Thu, 27 Oct 2016 16:21:23 +0530 [thread overview]
Message-ID: <CAJ3bTp7YON-+EiXCY+eaBP6NhtGJTngh2pLaKXdp2YPP1i+C6w@mail.gmail.com> (raw)
In-Reply-To: <743ffe4a-2c8f-e5f7-f93c-6be16a8a0350@st.com>
On Thu, Oct 27, 2016 at 4:02 PM, Giuseppe CAVALLARO
<peppe.cavallaro@st.com> wrote:
> Hello Rayagond !
>
> On 10/27/2016 12:25 PM, Rayagond Kokatanur wrote:
>>>
>>> +static int dwmac4_wrback_get_rx_timestamp_status(void *desc, u32 ats)
>>> > {
>>> > struct dma_desc *p = (struct dma_desc *)desc;
>>> > + int ret = -EINVAL;
>>> > +
>>> > + /* Get the status from normal w/b descriptor */
>>> > + if (likely(p->des3 & TDES3_RS1V)) {
>>> > + if (likely(p->des1 & RDES1_TIMESTAMP_AVAILABLE)) {
>>> > + int i = 0;
>>> > +
>>> > + /* Check if timestamp is OK from context
>>> > descriptor */
>>> > + do {
>>> > + ret = dwmac4_rx_check_timestamp(desc);
>>
>> Here, "desc" is not pointing to next descriptor (ie context
>> descriptor). Driver should check the context descriptor.
>
>
> you are right and this is done by the caller: stmmac_get_rx_hwtstamp
Yes.
>
> Cheers
> peppe
>
--
wwr
Rayagond
next prev parent reply other threads:[~2016-10-27 14:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 6:56 [PATCH (net.git) 0/3] stmmac: fix PTP support Giuseppe Cavallaro
2016-10-26 6:56 ` [PATCH (net.git) 1/3] stmmac: update the PTP header file Giuseppe Cavallaro
2016-10-26 6:56 ` [PATCH (net.git) 2/3] stmmac: fix PTP support for GMAC4 Giuseppe Cavallaro
2016-10-27 10:25 ` Rayagond Kokatanur
2016-10-27 10:32 ` Giuseppe CAVALLARO
2016-10-27 10:51 ` Rayagond Kokatanur [this message]
2016-11-02 6:34 ` Giuseppe CAVALLARO
2016-11-02 7:04 ` Rayagond Kokatanur
2016-10-26 6:56 ` [PATCH (net.git) 3/3] stmmac: fix PTP type ethtool stats Giuseppe Cavallaro
2016-10-26 7:29 ` [PATCH (net.git) 0/3] stmmac: fix PTP support Alexandre Torgue
2016-10-26 8:58 ` Richard Cochran
2016-11-02 7:03 ` Rayagond Kokatanur
2016-11-04 13:53 ` Giuseppe CAVALLARO
2016-11-04 15:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3bTp7YON-+EiXCY+eaBP6NhtGJTngh2pLaKXdp2YPP1i+C6w@mail.gmail.com \
--to=rayagond@vayavyalabs.com \
--cc=alexandre.torgue@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=seraphin.bonnaffe@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).