From: Allen Hubbe <allenbh@gmail.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>,
linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ntb_tool: Fix infinite loop bug when writing spad/peer_spad file
Date: Sat, 28 May 2016 09:09:20 -0400 [thread overview]
Message-ID: <CAJ80satFd9z=tdgHSPJy_BKUXRGOfUV_Kc5_dgeaChsUF62h3Q@mail.gmail.com> (raw)
In-Reply-To: <1464381511-18491-1-git-send-email-logang@deltatee.com>
On Fri, May 27, 2016 at 4:38 PM, Logan Gunthorpe <logang@deltatee.com> wrote:
> If you tried to write two spads in one line, as per the example:
>
> root@peer# echo '0 0x01010101 1 0x7f7f7f7f' > $DBG_DIR/peer_spad
>
> then the CPU would freeze in an infinite loop.
>
> This wasn't immediately obvious but 'pos' was not incrementing the
> buffer, so after reading the second pair of values, 'pos' would once
> again be 3 and it would re-read the second pair of values ad infinitum.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Good catch. Thanks Logan.
Acked-by: Allen Hubbe <Allen.Hubbe@emc.com>
> ---
> drivers/ntb/test/ntb_tool.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> index 6f5dc6c..209ef7c 100644
> --- a/drivers/ntb/test/ntb_tool.c
> +++ b/drivers/ntb/test/ntb_tool.c
> @@ -268,7 +268,7 @@ static ssize_t tool_spadfn_write(struct tool_ctx *tc,
> {
> int spad_idx;
> u32 spad_val;
> - char *buf;
> + char *buf, *buf_ptr;
> int pos, n;
> ssize_t rc;
>
> @@ -288,14 +288,15 @@ static ssize_t tool_spadfn_write(struct tool_ctx *tc,
> }
>
> buf[size] = 0;
> -
> - n = sscanf(buf, "%d %i%n", &spad_idx, &spad_val, &pos);
> + buf_ptr = buf;
> + n = sscanf(buf_ptr, "%d %i%n", &spad_idx, &spad_val, &pos);
> while (n == 2) {
> + buf_ptr += pos;
> rc = spad_write_fn(tc->ntb, spad_idx, spad_val);
> if (rc)
> break;
>
> - n = sscanf(buf + pos, "%d %i%n", &spad_idx, &spad_val, &pos);
> + n = sscanf(buf_ptr, "%d %i%n", &spad_idx, &spad_val, &pos);
> }
>
> if (n < 0)
> --
> 2.1.4
next parent reply other threads:[~2016-05-28 13:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1464381511-18491-1-git-send-email-logang@deltatee.com>
2016-05-28 13:09 ` Allen Hubbe [this message]
2016-06-04 15:19 ` [PATCH] ntb_tool: Fix infinite loop bug when writing spad/peer_spad file Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ80satFd9z=tdgHSPJy_BKUXRGOfUV_Kc5_dgeaChsUF62h3Q@mail.gmail.com' \
--to=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).