From: Mike Leach <mike.leach@linaro.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org,
Robert Walker <robert.walker@arm.com>,
Coresight ML <coresight@lists.linaro.org>
Subject: Re: [PATCH v3 4/5] perf cs-etm: Optimize copying last branches
Date: Thu, 6 Feb 2020 11:47:54 +0000 [thread overview]
Message-ID: <CAJ9a7VipUiYZYVkOA-rEakmOhRJp0EhKzoZMFQO0QZmfKhvScg@mail.gmail.com> (raw)
In-Reply-To: <20200203015203.27882-5-leo.yan@linaro.org>
Reviewed by: Mike Leach <mike.leach@linaro.org>
On Mon, 3 Feb 2020 at 01:53, Leo Yan <leo.yan@linaro.org> wrote:
>
> If an instruction range packet can generate multiple instruction
> samples, these samples share the same last branches; it's not necessary
> to copy the same last branches repeatedly for these samples within the
> same packet.
>
> This patch moves out the last branches copying from function
> cs_etm__synth_instruction_sample(), and execute it prior to generating
> instruction samples.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> tools/perf/util/cs-etm.c | 22 +++++++++++++++++-----
> 1 file changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
> index c5a05f728eac..dbddf1eec2be 100644
> --- a/tools/perf/util/cs-etm.c
> +++ b/tools/perf/util/cs-etm.c
> @@ -1134,10 +1134,8 @@ static int cs_etm__synth_instruction_sample(struct cs_etm_queue *etmq,
>
> cs_etm__copy_insn(etmq, tidq->trace_chan_id, tidq->packet, &sample);
>
> - if (etm->synth_opts.last_branch) {
> - cs_etm__copy_last_branch_rb(etmq, tidq);
> + if (etm->synth_opts.last_branch)
> sample.branch_stack = tidq->last_branch;
> - }
>
> if (etm->synth_opts.inject) {
> ret = cs_etm__inject_event(event, &sample,
> @@ -1407,6 +1405,10 @@ static int cs_etm__sample(struct cs_etm_queue *etmq,
> */
> u64 instrs_over = instrs_executed;
>
> + /* Prepare last branches for instruction sample */
> + if (etm->synth_opts.last_branch)
> + cs_etm__copy_last_branch_rb(etmq, tidq);
> +
> /*
> * 'head' is the instructions number of the head in the new
> * packet, it combines with the tail of previous packet to
> @@ -1526,6 +1528,11 @@ static int cs_etm__flush(struct cs_etm_queue *etmq,
>
> if (etmq->etm->synth_opts.last_branch &&
> tidq->prev_packet->sample_type == CS_ETM_RANGE) {
> + u64 addr;
> +
> + /* Prepare last branches for instruction sample */
> + cs_etm__copy_last_branch_rb(etmq, tidq);
> +
> /*
> * Generate a last branch event for the branches left in the
> * circular buffer at the end of the trace.
> @@ -1533,7 +1540,7 @@ static int cs_etm__flush(struct cs_etm_queue *etmq,
> * Use the address of the end of the last reported execution
> * range
> */
> - u64 addr = cs_etm__last_executed_instr(tidq->prev_packet);
> + addr = cs_etm__last_executed_instr(tidq->prev_packet);
>
> err = cs_etm__synth_instruction_sample(
> etmq, tidq, addr,
> @@ -1587,11 +1594,16 @@ static int cs_etm__end_block(struct cs_etm_queue *etmq,
> */
> if (etmq->etm->synth_opts.last_branch &&
> tidq->prev_packet->sample_type == CS_ETM_RANGE) {
> + u64 addr;
> +
> + /* Prepare last branches for instruction sample */
> + cs_etm__copy_last_branch_rb(etmq, tidq);
> +
> /*
> * Use the address of the end of the last reported execution
> * range.
> */
> - u64 addr = cs_etm__last_executed_instr(tidq->prev_packet);
> + addr = cs_etm__last_executed_instr(tidq->prev_packet);
>
> err = cs_etm__synth_instruction_sample(
> etmq, tidq, addr,
> --
> 2.17.1
>
--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK
next prev parent reply other threads:[~2020-02-06 11:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 1:51 [PATCH v3 0/5] perf cs-etm: Fix synthesizing instruction samples Leo Yan
2020-02-03 1:51 ` [PATCH v3 1/5] perf cs-etm: Swap packets for " Leo Yan
2020-02-05 15:59 ` Mike Leach
2020-02-06 7:43 ` Leo Yan
2020-02-03 1:52 ` [PATCH v3 2/5] perf cs-etm: Continuously record last branch Leo Yan
2020-02-05 16:01 ` Mike Leach
2020-02-03 1:52 ` [PATCH v3 3/5] perf cs-etm: Correct synthesizing instruction samples Leo Yan
2020-02-05 16:09 ` Mike Leach
2020-02-06 8:24 ` Leo Yan
2020-02-03 1:52 ` [PATCH v3 4/5] perf cs-etm: Optimize copying last branches Leo Yan
2020-02-06 11:47 ` Mike Leach [this message]
2020-02-03 1:52 ` [PATCH v3 5/5] perf cs-etm: Fix unsigned variable comparison to zero Leo Yan
2020-02-06 11:48 ` Mike Leach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ9a7VipUiYZYVkOA-rEakmOhRJp0EhKzoZMFQO0QZmfKhvScg@mail.gmail.com \
--to=mike.leach@linaro.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robert.walker@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).