From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbdCBK0g (ORCPT ); Thu, 2 Mar 2017 05:26:36 -0500 Received: from mail-qk0-f169.google.com ([209.85.220.169]:33808 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534AbdCBK0c (ORCPT ); Thu, 2 Mar 2017 05:26:32 -0500 MIME-Version: 1.0 In-Reply-To: References: <20170224103309.19463-1-kernel@kempniu.pl> From: Alex Hung Date: Thu, 2 Mar 2017 18:17:44 +0800 Message-ID: Subject: Re: [PATCH 0/4] Improve intel-hid's self-consistency To: Andy Shevchenko Cc: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= , Darren Hart , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v22AQpW5007154 On Thu, Mar 2, 2017 at 7:03 AM, Andy Shevchenko wrote: > On Fri, Feb 24, 2017 at 12:33 PM, Michał Kępień wrote: >> Commit 2cfa4b311acc ("platform/x86: intel-hid: Support 5 button array") >> contains some coding style cleanups compared to the code it was based >> on. This patch series "backports" these cleanups to the rest of the >> driver in order to make it more self-consistent and removes a redundant >> set_bit() call as a bonus. >> >> This series was not tested on hardware supported by intel-hid. > > Alex, do you have an access to hardware to test? I wouldn't going to > apply this until I get your tag(s) (in the best case > Reviewed-and-tested-by). The patches look good and tested on Latitude 7480 Reviewed-and-tested-by: Alex Hung > > -- > With Best Regards, > Andy Shevchenko