linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Nicholson <dbn@endlessos.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Chris Chiu <chiu@endlessos.org>,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	peterz@infradead.org, Andy Lutomirski <luto@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	linux@endlessos.org, Dan Nicholson <nicholson@endlessos.org>,
	Jian-Hong Pan <jhp@endlessos.org>
Subject: Re: [PATCH v2] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk
Date: Thu, 10 Dec 2020 16:01:06 -0700	[thread overview]
Message-ID: <CAJAOzpAC8V7iNnXDjdJS8Gu0pWsdZgy77ofcZftmfyOoOTDNeg@mail.gmail.com> (raw)
In-Reply-To: <20201210184930.GF26529@zn.tnic>

On Thu, Dec 10, 2020 at 11:49 AM Borislav Petkov <bp@alien8.de> wrote:
>
> On Thu, Dec 10, 2020 at 12:19:46PM +0800, Chris Chiu wrote:
> > From: Dan Nicholson <nicholson@endlessos.org>
> >
> > The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi
> > reboot.
>
> Is that what the "hard disk crash" in the comment below, refers to?

Hmm, when I wrote this patch several years back there wasn't any hang
when rebooting. According to our internal bug tracker, you could hear
the disk head crashing on reboot. The workaround was to do a BIOS
reboot rather than an ACPI reboot. My original commit message was:

    x86/reboot: Use bios reboot for GIGABYTE BRIX BXBT-2807

    Using ACPI, the hard disk crashes on reboot. This seems to be avoided
    when using the BIOS to reboot.

I don't know if this became a hang with more recent kernels as
described in this commit message. Chris?

--
Dan

      reply	other threads:[~2020-12-10 23:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10  4:19 [PATCH v2] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk Chris Chiu
2020-12-10 18:49 ` Borislav Petkov
2020-12-10 23:01   ` Dan Nicholson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJAOzpAC8V7iNnXDjdJS8Gu0pWsdZgy77ofcZftmfyOoOTDNeg@mail.gmail.com \
    --to=dbn@endlessos.org \
    --cc=bp@alien8.de \
    --cc=chiu@endlessos.org \
    --cc=hpa@zytor.com \
    --cc=jhp@endlessos.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessos.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=nicholson@endlessos.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).